<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>yes, it must have, so I will look into that.</p>
<p>/Daniel<br>
</p>
<div class="moz-signature">
<pre>
</pre>
</div>
<div class="moz-cite-prefix">On 2021-03-12 14:07, Joel Sherrill
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAF9ehCWxeYiTBZsLC_sA0nO3ai61vAiGQxH9TKPiDeD3UXpbYw@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="auto">Without looking, I would assume this was
introduced by Daniel's recent patches.</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">---------- Forwarded message
---------<br>
From: <span dir="auto"><<a
href="mailto:scan-admin@coverity.com"
moz-do-not-send="true">scan-admin@coverity.com</a>></span><br>
Date: Fri, Mar 12, 2021, 12:55 AM<br>
Subject: New Defects reported by Coverity Scan for RTEMS<br>
To: <<a href="mailto:build@rtems.org"
moz-do-not-send="true">build@rtems.org</a>><br>
</div>
<br>
<br>
Hi,<br>
<br>
Please find the latest report on new defect(s) introduced to
RTEMS found with Coverity Scan.<br>
<br>
1 new defect(s) introduced to RTEMS found with Coverity Scan.<br>
<br>
<br>
New defect(s) Reported-by: Coverity Scan<br>
Showing 1 of 1 defect(s)<br>
<br>
<br>
** CID 1473629: Control flow issues (NO_EFFECT)<br>
/bsps/shared/grlib/can/grcanfd.c: 323 in grcan_hw_write_try_fd()<br>
<br>
<br>
________________________________________________________________________________________________________<br>
*** CID 1473629: Control flow issues (NO_EFFECT)<br>
/bsps/shared/grlib/can/grcanfd.c: 323 in grcan_hw_write_try_fd()<br>
317 bds = 1;<br>
318 if (space_left < bds)<br>
319 break;<br>
320 <br>
321 /* Convert and write CAN message to DMA
buffer */<br>
322 dlc = grcan_len2dlc(source->len);<br>
>>> CID 1473629: Control flow issues (NO_EFFECT)<br>
>>> This less-than-zero comparison of an unsigned
value is never true. "dlc < 0".<br>
323 if (dlc < 0) {<br>
324 /* Bad user input. Report the
number of written messages<br>
325 * or an error when non sent.<br>
326 */<br>
327 if (ret <= 0)<br>
328 return GRCAN_RET_INVARG;<br>
<br>
<br>
________________________________________________________________________________________________________<br>
To view the defects in Coverity Scan visit, <a
href="https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypUUzi-2FdSNmuyRB7BEFT8xQ4-2B8hpujh0hTgQljRGId4Dg-3D-3DVX3j_EU3W9teASMK00lBXX9WT4lsogDrkCcNZLvg-2FVxwAXMppdCoTOdWUHKtQLrEQ1MfSyaNP2M1HWoDjjoKTjy-2FIq1HdvVcL1npIuQDJWa-2FDWEQ-2FAOQo8VzAxUCWwGfT9lbXVNqnU0jQl-2FWSYNQAJPY2Tylmw5hG5KcV6hC39VfLDFtSor5xgUxBh-2BcdibW34mNQFj7qSSTl6hW9DF4ywtf1oYStmZyjbwIV0D1AeB2dPto-3D"
rel="noreferrer noreferrer" target="_blank"
moz-do-not-send="true">https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypUUzi-2FdSNmuyRB7BEFT8xQ4-2B8hpujh0hTgQljRGId4Dg-3D-3DVX3j_EU3W9teASMK00lBXX9WT4lsogDrkCcNZLvg-2FVxwAXMppdCoTOdWUHKtQLrEQ1MfSyaNP2M1HWoDjjoKTjy-2FIq1HdvVcL1npIuQDJWa-2FDWEQ-2FAOQo8VzAxUCWwGfT9lbXVNqnU0jQl-2FWSYNQAJPY2Tylmw5hG5KcV6hC39VfLDFtSor5xgUxBh-2BcdibW34mNQFj7qSSTl6hW9DF4ywtf1oYStmZyjbwIV0D1AeB2dPto-3D</a><br>
<br>
_______________________________________________<br>
build mailing list<br>
<a href="mailto:build@rtems.org" target="_blank"
rel="noreferrer" moz-do-not-send="true">build@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/build"
rel="noreferrer noreferrer" target="_blank"
moz-do-not-send="true">http://lists.rtems.org/mailman/listinfo/build</a><br>
</div>
</blockquote>
</body>
</html>