<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Mar 15, 2021, 5:53 AM Hesham Almatary <<a href="mailto:hesham.almatary@cl.cam.ac.uk">hesham.almatary@cl.cam.ac.uk</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello Gedare,<br>
<br>
Yeah adding Make support should be straightforward. I just assumed<br>
Make will be deprecated soon based on [1] and haven't bothered<br>
supporting it.<br>
<br>
[1] <a href="https://github.com/RTEMS/rtems-examples/blob/983926a7e519be85f630c620430e7e1ac3e0f4ea/README.Makefile#L32" rel="noreferrer noreferrer" target="_blank">https://github.com/RTEMS/rtems-examples/blob/983926a7e519be85f630c620430e7e1ac3e0f4ea/README.Makefile#L32</a></blockquote></div></div><div dir="auto"><br></div><div dir="auto">There are projects that use it. Although it is old and it would be nice to go to something else, that something else isn't there. It's there.foenthe foreseeable future.</div><div dir="auto"><br></div><div dir="auto">--joel</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
<br>
<br>
On Sun, 14 Mar 2021 at 18:47, Gedare Bloom <<a href="mailto:gedare@rtems.org" target="_blank" rel="noreferrer">gedare@rtems.org</a>> wrote:<br>
><br>
> Hi Hesham,<br>
><br>
> Nice work getting this integrated in the upstream. I guess that the<br>
> git submodule instructions for building with waf will work for this,<br>
> but not Make. How hard would it be for you to integrate the submodule<br>
> with Make?<br>
><br>
> This is fine with me as-is, I just want to know if we can keep it<br>
> supporting both build systems.<br>
><br>
> On Sat, Mar 13, 2021 at 12:50 AM Hesham Almatary<br>
> <<a href="mailto:hesham.almatary@cl.cam.ac.uk" target="_blank" rel="noreferrer">hesham.almatary@cl.cam.ac.uk</a>> wrote:<br>
> ><br>
> > CoreMark's primary goals are simplicity and providing a method for<br>
> > testing only a processor's core features. It is used primarily here as<br>
> > a performance benchmark.<br>
> ><br>
> > Built and tested for RISC-V rv64imafdc_medany on QEMU and HW<br>
> > ---<br>
> > .gitmodules | 3 +++<br>
> > benchmarks/coremark/coremark | 1 +<br>
> > benchmarks/coremark/wscript | 50 ++++++++++++++++++++++++++++++++++++<br>
> > benchmarks/wscript | 2 +-<br>
> > 4 files changed, 55 insertions(+), 1 deletion(-)<br>
> > create mode 160000 benchmarks/coremark/coremark<br>
> > create mode 100644 benchmarks/coremark/wscript<br>
> ><br>
> > diff --git a/.gitmodules b/.gitmodules<br>
> > index ae86e49..d7e52b9 100644<br>
> > --- a/.gitmodules<br>
> > +++ b/.gitmodules<br>
> > @@ -1,3 +1,6 @@<br>
> > [submodule "rtems_waf"]<br>
> > path = rtems_waf<br>
> > url = git://<a href="http://git.rtems.org/rtems_waf.git" rel="noreferrer noreferrer" target="_blank">git.rtems.org/rtems_waf.git</a><br>
> > +[submodule "benchmarks/coremark/coremark"]<br>
> > + path = benchmarks/coremark/coremark<br>
> > + url = git@github.com:eembc/coremark.git<br>
> > diff --git a/benchmarks/coremark/coremark b/benchmarks/coremark/coremark<br>
> > new file mode 160000<br>
> > index 0000000..1541482<br>
> > --- /dev/null<br>
> > +++ b/benchmarks/coremark/coremark<br>
> > @@ -0,0 +1 @@<br>
> > +Subproject commit 1541482bf3e6ef7f5c69f5be76b14537b60833d0<br>
> > diff --git a/benchmarks/coremark/wscript b/benchmarks/coremark/wscript<br>
> > new file mode 100644<br>
> > index 0000000..2ec5f1e<br>
> > --- /dev/null<br>
> > +++ b/benchmarks/coremark/wscript<br>
> > @@ -0,0 +1,50 @@<br>
> > +#-<br>
> > +# SPDX-License-Identifier: BSD-2-Clause<br>
> > +#<br>
> > +# Copyright (c) 2021 Hesham Almatary<br>
> > +#<br>
> > +# This software was developed by SRI International and the University of<br>
> > +# Cambridge Computer Laboratory (Department of Computer Science and<br>
> > +# Technology) under DARPA contract HR0011-18-C-0016 ("ECATS"), as part of the<br>
> > +# DARPA SSITH research programme.<br>
> > +#<br>
> > +# Redistribution and use in source and binary forms, with or without<br>
> > +# modification, are permitted provided that the following conditions<br>
> > +# are met:<br>
> > +# 1. Redistributions of source code must retain the above copyright<br>
> > +# notice, this list of conditions and the following disclaimer.<br>
> > +# 2. Redistributions in binary form must reproduce the above copyright<br>
> > +# notice, this list of conditions and the following disclaimer in the<br>
> > +# documentation and/or other materials provided with the distribution.<br>
> > +#<br>
> > +# THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND<br>
> > +# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE<br>
> > +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE<br>
> > +# ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE<br>
> > +# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL<br>
> > +# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS<br>
> > +# OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)<br>
> > +# HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT<br>
> > +# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY<br>
> > +# OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF<br>
> > +# SUCH DAMAGE.<br>
> > +#<br>
> > +<br>
> > +import rtems_waf.rtems as rtems<br>
> > +<br>
> > +def build(bld):<br>
> > + rtems.build(bld)<br>
> > +<br>
> > + bld(features = 'c cprogram',<br>
> > + target = 'coremark.bin',<br>
> > + includes = ['coremark/', 'coremark/posix/'],<br>
> > + source = ['coremark/rtems/init.c', 'coremark/posix/core_portme.c',<br>
> > + 'coremark/core_list_join.c', 'coremark/core_main.c',<br>
> > + 'coremark/core_matrix.c', 'coremark/core_state.c',<br>
> > + 'coremark/core_util.c'],<br>
> > +<br>
> > + defines = [<br>
> > + # FLAGS_STR is used within CoreMark to print the compiler flags used<br>
> > + 'FLAGS_STR="'+' '.join([str(flag) for flag in bld.env.CFLAGS])+'"'<br>
> > + ]<br>
> > + )<br>
> > diff --git a/benchmarks/wscript b/benchmarks/wscript<br>
> > index 12741e7..0947060 100644<br>
> > --- a/benchmarks/wscript<br>
> > +++ b/benchmarks/wscript<br>
> > @@ -7,4 +7,4 @@ import rtems_waf.rtems as rtems<br>
> ><br>
> > def build(bld):<br>
> > bld.recurse('nbench')<br>
> > -<br>
> > + bld.recurse('coremark')<br>
><br>
> I think we usually keep the blank line at the end of the wscript file.<br>
> Not a hard rule.<br>
><br>
> > --<br>
> > 2.25.1<br>
> ><br>
> > _______________________________________________<br>
> > devel mailing list<br>
> > <a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a><br>
> > <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div></div></div>