<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Mar 16, 2021 at 9:15 AM Ryan Long <<a href="mailto:ryan.long@oarcorp.com">ryan.long@oarcorp.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I found this error yesterday, when doing more testing based on Chris's feedback. I've taken out the _Assert_Unused_variable_equals() in pwdgrp.c and replaced it with just a (void). The test passed afterwards, but Joel wants me to test it a little further. I'll get the patch in to fix that by the end of the day.</blockquote><div><br></div><div>I wanted to see fileio run OK but it looks like the Zynq BSP on Qemu doesn't have working input at the moment. I had Ryan switch over to leon3 just to test this.</div><div><br></div><div>Does console input work for you on Zynq qemu right now? I emailed Jan last night to see if he had tested that.</div><div><br></div><div>--joel</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br>
<br>
-----Original Message-----<br>
From: Sebastian Huber <<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brains.de</a>> <br>
Sent: Tuesday, March 16, 2021 6:33 AM<br>
To: RTEMS <<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a>>; Ryan Long <<a href="mailto:ryan.long@oarcorp.com" target="_blank">ryan.long@oarcorp.com</a>><br>
Subject: Re: [rtems commit] pwdgrp.c: Fix Unchecked return value from library ( CID #1255518)<br>
<br>
On 16/03/2021 12:30, Sebastian Huber wrote:<br>
<br>
> On 08/03/2021 21:56, Joel Sherrill wrote:<br>
><br>
>> Module: rtems<br>
>> Branch: master<br>
>> Commit: 55ba229d228d1b7372256978828c573dd0af56d4<br>
>> Changeset:<a href="http://git.rtems.org/rtems/commit/?id=55ba229d228d1b7372256" rel="noreferrer" target="_blank">http://git.rtems.org/rtems/commit/?id=55ba229d228d1b7372256</a><br>
>> 978828c573dd0af56d4<br>
>><br>
>><br>
>> Author: Ryan Long<<a href="mailto:ryan.long@oarcorp.com" target="_blank">ryan.long@oarcorp.com</a>><br>
>> Date: Tue Mar 2 11:46:02 2021 -0500<br>
>><br>
>> pwdgrp.c: Fix Unchecked return value from library (CID #1255518)<br>
>><br>
>> CID 1255518: Unchecked return value from library in pwdgrp_init().<br>
>><br>
>> Closes #4282<br>
><br>
> I get an assertion in the tests with RTEMS_DEBUG enabled:<br>
><br>
> test start: PWDGRP 1<br>
><br>
> *** BEGIN OF TEST PWDGRP 1 ***<br>
><br>
> *** TEST VERSION: 6.0.0.ca801609a7100804520809d1407174f465befee5<br>
><br>
> *** TEST STATE: EXPECTED_PASS<br>
><br>
> *** TEST BUILD: RTEMS_DEBUG RTEMS_NETWORKING RTEMS_POSIX_API<br>
><br>
> *** TEST TOOLS: 10.2.1 20210315 (RTEMS 6, RSB <br>
> 62363ba982213588ef5d8bc8c4ff3acc28075f3f,<br>
> Newlib d10d0d9)<br>
><br>
> assertion "(sc) == (0)" failed: file <br>
> "/home/EB/sebastian_h/src/rtems/cpukit/libcsupport/src/pwdgrp.c",<br>
> line 72, function: pwdgrp_init<br>
<br>
Also these tests:<br>
<br>
test start: PSXPASSWD 2<br>
<br>
*** BEGIN OF TEST PSXPASSWD 2 ***<br>
<br>
*** TEST VERSION: 6.0.0.ca801609a7100804520809d1407174f465befee5<br>
<br>
*** TEST STATE: EXPECTED_PASS<br>
<br>
*** TEST BUILD: RTEMS_DEBUG RTEMS_NETWORKING RTEMS_POSIX_API<br>
<br>
*** TEST TOOLS: 10.2.1 20210315 (RTEMS 6, RSB 62363ba982213588ef5d8bc8c4ff3acc28075f3f,<br>
Newlib d10d0d9)<br>
<br>
Init - Creating /etc<br>
<br>
Init - Creating /etc/passwd<br>
<br>
Init - Creating /etc/group<br>
<br>
Init - setpwent() -- OK<br>
<br>
assertion "(sc) == (0)" failed: file "/home/EB/sebastian_h/src/rtems/cpukit/libcsupport/src/pwdgrp.c",<br>
<br>
line 72, function: pwdgrp_init<br>
<br>
<br>
test start: SHELL 1<br>
<br>
*** BEGIN OF TEST SHELL 1 ***<br>
<br>
*** TEST VERSION: 6.0.0.ca801609a7100804520809d1407174f465befee5<br>
<br>
*** TEST STATE: EXPECTED_PASS<br>
<br>
*** TEST BUILD: RTEMS_DEBUG RTEMS_NETWORKING RTEMS_POSIX_API<br>
<br>
*** TEST TOOLS: 10.2.1 20210315 (RTEMS 6, RSB 62363ba982213588ef5d8bc8c4ff3acc28075f3f,<br>
Newlib d10d0d9)<br>
<br>
assertion "(sc) == (0)" failed: file "/home/EB/sebastian_h/src/rtems/cpukit/libcsupport/src/pwdgrp.c",<br>
line 72, function: pwdgrp_init<br>
<br>
--<br>
embedded brains GmbH<br>
Herr Sebastian HUBER<br>
Dornierstr. 4<br>
82178 Puchheim<br>
Germany<br>
email: <a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brains.de</a><br>
phone: +49-89-18 94 741 - 16<br>
fax: +49-89-18 94 741 - 08<br>
<br>
Registergericht: Amtsgericht München<br>
Registernummer: HRB 157899<br>
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier:<br>
<a href="https://embedded-brains.de/datenschutzerklaerung/" rel="noreferrer" target="_blank">https://embedded-brains.de/datenschutzerklaerung/</a><br>
<br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a></blockquote></div></div>