<div dir="ltr"><div dir="ltr">After picking on Ryan, Alex, and Sebastian, you get it next. :)<div><br></div><div>"Fix" or "Fixed" in the short commit message title is not useful</div><div>when you browse the log of commits:<br><br><a href="https://git.rtems.org/rtems/log/">https://git.rtems.org/rtems/log/</a><br><br>Something like "Use uint32_t not uintptr_t for portability to 64-bit CPUs"</div><div>says a lot more. Think of yourself reading that list of commits and what</div><div>messages tell you enough and which leave you thinking that you need</div><div>to look at the change to know what was done.</div><div><br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 18, 2021 at 12:33 PM Stephen Clark <<a href="mailto:stephen.clark@oarcorp.com">stephen.clark@oarcorp.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Using 32bit types like uint32_t for pointers creates issues on 64 bit<br>
architectures like AArch64. Replaced occurrences of these with uintptr_t,<br>
which will work for both 32 and 64 bit architectures.<br>
---<br>
cpukit/libdebugger/rtems-debugger-server.c | 4 ++--<br>
cpukit/libdebugger/rtems-debugger-target.c | 2 +-<br>
cpukit/libdebugger/rtems-debugger-target.h | 2 +-<br>
3 files changed, 4 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/cpukit/libdebugger/rtems-debugger-server.c b/cpukit/libdebugger/rtems-debugger-server.c<br>
index 975ec23a30..f8c485a794 100644<br>
--- a/cpukit/libdebugger/rtems-debugger-server.c<br>
+++ b/cpukit/libdebugger/rtems-debugger-server.c<br>
@@ -1438,7 +1438,7 @@ remote_read_memory(uint8_t* buffer, int size)<br>
if (comma == NULL)<br>
remote_packet_out_str(r_E01);<br>
else {<br>
- DB_UINT addr;<br>
+ uintptr_t addr;<br>
DB_UINT length;<br>
int r;<br>
addr = hex_decode_uint(&buffer[1]);<br>
@@ -1468,7 +1468,7 @@ remote_write_memory(uint8_t* buffer, int size)<br>
comma = strchr((const char*) buffer, ',');<br>
colon = strchr((const char*) buffer, ':');<br>
if (comma != NULL && colon != NULL) {<br>
- DB_UINT addr;<br>
+ uintptr_t addr;<br>
DB_UINT length;<br>
int r;<br>
addr = hex_decode_uint(&buffer[1]);</blockquote><div><br></div><div>I think the changes OK but Chris should comment what </div><div>happens on 64-bit address targets.</div><div><br></div><div>I think this may be decoding the gdb protocol message and we need</div><div>to know if the field coming in is OK to decode as a uint. </div><div><br></div><div>Your patch is OK but there may be an issue interfacing with the protocol</div><div>that this points out.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
diff --git a/cpukit/libdebugger/rtems-debugger-target.c b/cpukit/libdebugger/rtems-debugger-target.c<br>
index bf7579700d..34e4e84d2f 100644<br>
--- a/cpukit/libdebugger/rtems-debugger-target.c<br>
+++ b/cpukit/libdebugger/rtems-debugger-target.c<br>
@@ -168,7 +168,7 @@ rtems_debugger_target_reg_table_size(void)<br>
}<br>
<br>
int<br>
-rtems_debugger_target_swbreak_control(bool insert, DB_UINT addr, DB_UINT kind)<br>
+rtems_debugger_target_swbreak_control(bool insert, uintptr_t addr, DB_UINT kind)<br>
{<br>
rtems_debugger_target* target = rtems_debugger->target;<br>
rtems_debugger_target_swbreak* swbreaks;<br>
diff --git a/cpukit/libdebugger/rtems-debugger-target.h b/cpukit/libdebugger/rtems-debugger-target.h<br>
index f2abbe5fd3..db356e1f07 100644<br>
--- a/cpukit/libdebugger/rtems-debugger-target.h<br>
+++ b/cpukit/libdebugger/rtems-debugger-target.h<br>
@@ -200,7 +200,7 @@ extern void rtems_debugger_target_exception_print(CPU_Exception_frame* frame);<br>
* Software breakpoints. These are also referred to as memory breakpoints.<br>
*/<br>
extern int rtems_debugger_target_swbreak_control(bool insert,<br>
- DB_UINT addr,<br>
+ uintptr_t addr,<br>
DB_UINT kind);<br>
<br>
/**<br>
-- <br>
2.27.0<br>
<br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div></div>