<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 18, 2021 at 3:53 PM Gedare Bloom <<a href="mailto:gedare@rtems.org">gedare@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I've lost some context, but wasn't this already addressed?<br>
<a href="https://lists.rtems.org/pipermail/devel/2021-March/065021.html" rel="noreferrer" target="_blank">https://lists.rtems.org/pipermail/devel/2021-March/065021.html</a></blockquote><div><br></div><div>Ryan .. is this a case where the internal tree fixed it one way and </div><div>Sebastian fixed it another? Perhaps Sebastian fixed it while this</div><div>patch was queued up to go out.</div><div><br></div><div>Does aarch64 give a warning or fail without this patch? If not,</div><div>then this patch probably isn't needed.</div><div><br></div><div>Although I think size_t is probably the right type for this. Please check</div><div>that the test has an issue on the master without this patch.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
<br>
On Thu, Mar 18, 2021 at 2:27 PM Ryan Long <<a href="mailto:ryan.long@oarcorp.com" target="_blank">ryan.long@oarcorp.com</a>> wrote:<br>
><br>
> Changed maximum_pending_messages to type size_t to fix the<br>
> ts-validation0 test.<br>
> ---<br>
>  cpukit/include/rtems/rtems/message.h                | 2 +-<br>
>  cpukit/include/rtems/score/coremsgimpl.h            | 2 +-<br>
>  cpukit/score/src/coremsg.c                          | 2 +-<br>
>  testsuites/validation/tc-message-construct-errors.c | 2 +-<br>
>  4 files changed, 4 insertions(+), 4 deletions(-)<br>
><br>
> diff --git a/cpukit/include/rtems/rtems/message.h b/cpukit/include/rtems/rtems/message.h<br>
> index 14083b8..7bb48ba 100644<br>
> --- a/cpukit/include/rtems/rtems/message.h<br>
> +++ b/cpukit/include/rtems/rtems/message.h<br>
> @@ -51,7 +51,7 @@ typedef struct {<br>
>     * @brief This member defines the maximum number of pending messages supported<br>
>     *   by the message queue.<br>
>     */<br>
> -  uint32_t maximum_pending_messages;<br>
> +  size_t maximum_pending_messages;<br>
><br>
>    /**<br>
>     * @brief This member defines the maximum message size supported by the message<br>
> diff --git a/cpukit/include/rtems/score/coremsgimpl.h b/cpukit/include/rtems/score/coremsgimpl.h<br>
> index 6f6a01b..c7a424c 100644<br>
> --- a/cpukit/include/rtems/score/coremsgimpl.h<br>
> +++ b/cpukit/include/rtems/score/coremsgimpl.h<br>
> @@ -144,7 +144,7 @@ void *_CORE_message_queue_Workspace_allocate(<br>
>  Status_Control _CORE_message_queue_Initialize(<br>
>    CORE_message_queue_Control          *the_message_queue,<br>
>    CORE_message_queue_Disciplines       discipline,<br>
> -  uint32_t                             maximum_pending_messages,<br>
> +  size_t                               maximum_pending_messages,<br>
>    size_t                               maximum_message_size,<br>
>    CORE_message_queue_Allocate_buffers  allocate_buffers,<br>
>    const void                          *arg<br>
> diff --git a/cpukit/score/src/coremsg.c b/cpukit/score/src/coremsg.c<br>
> index cf7f44e..530f057 100644<br>
> --- a/cpukit/score/src/coremsg.c<br>
> +++ b/cpukit/score/src/coremsg.c<br>
> @@ -35,7 +35,7 @@ RTEMS_STATIC_ASSERT(<br>
>  Status_Control _CORE_message_queue_Initialize(<br>
>    CORE_message_queue_Control          *the_message_queue,<br>
>    CORE_message_queue_Disciplines       discipline,<br>
> -  uint32_t                             maximum_pending_messages,<br>
> +  size_t                               maximum_pending_messages,<br>
>    size_t                               maximum_message_size,<br>
>    CORE_message_queue_Allocate_buffers  allocate_buffers,<br>
>    const void                          *arg<br>
> diff --git a/testsuites/validation/tc-message-construct-errors.c b/testsuites/validation/tc-message-construct-errors.c<br>
> index 3512b45..170b687 100644<br>
> --- a/testsuites/validation/tc-message-construct-errors.c<br>
> +++ b/testsuites/validation/tc-message-construct-errors.c<br>
> @@ -338,7 +338,7 @@ static void RtemsMessageReqConstructErrors_Pre_MaxPending_Prepare(<br>
>         * configuration shall be big enough so that a calculation to get the<br>
>         * message buffer storage area size overflows.<br>
>         */<br>
> -      ctx->config.maximum_pending_messages = UINT32_MAX;<br>
> +      ctx->config.maximum_pending_messages = SIZE_MAX;<br>
>        break;<br>
>      }<br>
><br>
> --<br>
> 1.8.3.1<br>
><br>
> _______________________________________________<br>
> devel mailing list<br>
> <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
> <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div></div>