<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Yes, a different fix for this went in a couple weeks back. This patch needs to be dropped from the set.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Kinsey<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin-left:.5in"><b>From:</b> devel <devel-bounces@rtems.org>
<b>On Behalf Of </b>Joel Sherrill<br>
<b>Sent:</b> Thursday, March 18, 2021 15:57<br>
<b>To:</b> Gedare Bloom <gedare@rtems.org><br>
<b>Cc:</b> devel@rtems.org<br>
<b>Subject:</b> Re: [PATCH 2/3] Changed variable type to fix AARCH64 test issues<o:p></o:p></p>
</div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal" style="margin-left:.5in">On Thu, Mar 18, 2021 at 3:53 PM Gedare Bloom <<a href="mailto:gedare@rtems.org">gedare@rtems.org</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-left:.5in">I've lost some context, but wasn't this already addressed?<br>
<a href="https://lists.rtems.org/pipermail/devel/2021-March/065021.html" target="_blank">https://lists.rtems.org/pipermail/devel/2021-March/065021.html</a><o:p></o:p></p>
</blockquote>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Ryan .. is this a case where the internal tree fixed it one way and <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Sebastian fixed it another? Perhaps Sebastian fixed it while this<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">patch was queued up to go out.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Does aarch64 give a warning or fail without this patch? If not,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">then this patch probably isn't needed.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Although I think size_t is probably the right type for this. Please check<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">that the test has an issue on the master without this patch.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> <o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-left:.5in"><br>
<br>
On Thu, Mar 18, 2021 at 2:27 PM Ryan Long <<a href="mailto:ryan.long@oarcorp.com" target="_blank">ryan.long@oarcorp.com</a>> wrote:<br>
><br>
> Changed maximum_pending_messages to type size_t to fix the<br>
> ts-validation0 test.<br>
> ---<br>
> cpukit/include/rtems/rtems/message.h | 2 +-<br>
> cpukit/include/rtems/score/coremsgimpl.h | 2 +-<br>
> cpukit/score/src/coremsg.c | 2 +-<br>
> testsuites/validation/tc-message-construct-errors.c | 2 +-<br>
> 4 files changed, 4 insertions(+), 4 deletions(-)<br>
><br>
> diff --git a/cpukit/include/rtems/rtems/message.h b/cpukit/include/rtems/rtems/message.h<br>
> index 14083b8..7bb48ba 100644<br>
> --- a/cpukit/include/rtems/rtems/message.h<br>
> +++ b/cpukit/include/rtems/rtems/message.h<br>
> @@ -51,7 +51,7 @@ typedef struct {<br>
> * @brief This member defines the maximum number of pending messages supported<br>
> * by the message queue.<br>
> */<br>
> - uint32_t maximum_pending_messages;<br>
> + size_t maximum_pending_messages;<br>
><br>
> /**<br>
> * @brief This member defines the maximum message size supported by the message<br>
> diff --git a/cpukit/include/rtems/score/coremsgimpl.h b/cpukit/include/rtems/score/coremsgimpl.h<br>
> index 6f6a01b..c7a424c 100644<br>
> --- a/cpukit/include/rtems/score/coremsgimpl.h<br>
> +++ b/cpukit/include/rtems/score/coremsgimpl.h<br>
> @@ -144,7 +144,7 @@ void *_CORE_message_queue_Workspace_allocate(<br>
> Status_Control _CORE_message_queue_Initialize(<br>
> CORE_message_queue_Control *the_message_queue,<br>
> CORE_message_queue_Disciplines discipline,<br>
> - uint32_t maximum_pending_messages,<br>
> + size_t maximum_pending_messages,<br>
> size_t maximum_message_size,<br>
> CORE_message_queue_Allocate_buffers allocate_buffers,<br>
> const void *arg<br>
> diff --git a/cpukit/score/src/coremsg.c b/cpukit/score/src/coremsg.c<br>
> index cf7f44e..530f057 100644<br>
> --- a/cpukit/score/src/coremsg.c<br>
> +++ b/cpukit/score/src/coremsg.c<br>
> @@ -35,7 +35,7 @@ RTEMS_STATIC_ASSERT(<br>
> Status_Control _CORE_message_queue_Initialize(<br>
> CORE_message_queue_Control *the_message_queue,<br>
> CORE_message_queue_Disciplines discipline,<br>
> - uint32_t maximum_pending_messages,<br>
> + size_t maximum_pending_messages,<br>
> size_t maximum_message_size,<br>
> CORE_message_queue_Allocate_buffers allocate_buffers,<br>
> const void *arg<br>
> diff --git a/testsuites/validation/tc-message-construct-errors.c b/testsuites/validation/tc-message-construct-errors.c<br>
> index 3512b45..170b687 100644<br>
> --- a/testsuites/validation/tc-message-construct-errors.c<br>
> +++ b/testsuites/validation/tc-message-construct-errors.c<br>
> @@ -338,7 +338,7 @@ static void RtemsMessageReqConstructErrors_Pre_MaxPending_Prepare(<br>
> * configuration shall be big enough so that a calculation to get the<br>
> * message buffer storage area size overflows.<br>
> */<br>
> - ctx->config.maximum_pending_messages = UINT32_MAX;<br>
> + ctx->config.maximum_pending_messages = SIZE_MAX;<br>
> break;<br>
> }<br>
><br>
> --<br>
> 1.8.3.1<br>
><br>
> _______________________________________________<br>
> devel mailing list<br>
> <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
> <a href="http://lists.rtems.org/mailman/listinfo/devel" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</body>
</html>