<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Apr 6, 2021 at 3:49 PM Ryan Long <<a href="mailto:ryan.long@oarcorp.com">ryan.long@oarcorp.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Joel says the two are equivalent.<br></blockquote><div><br></div><div>And Joel was wrong in that private conversation. :(</div><div><br></div><div>-DVAR ==> VAR is 1</div><div>#define VAR == VAR is nothing</div><div><br></div><div>The first case is required behavior from POSIX on a C compiler invocation. </div><div><br></div><div>--joel </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
-----Original Message-----<br>
From: devel <<a href="mailto:devel-bounces@rtems.org" target="_blank">devel-bounces@rtems.org</a>> On Behalf Of Ryan Long<br>
Sent: Tuesday, April 6, 2021 3:36 PM<br>
To: Chris Johns <<a href="mailto:chrisj@rtems.org" target="_blank">chrisj@rtems.org</a>><br>
Cc: <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
Subject: RE: [PATCH 1/4] main_cp.c: Unused value (CID #1255344)<br>
<br>
Oh, I definitely missed that. I'm not sure though, but other patches have used #ifdef.  So I should only resubmit this patch then?<br>
<br>
-----Original Message-----<br>
From: Chris Johns <<a href="mailto:chrisj@rtems.org" target="_blank">chrisj@rtems.org</a>> <br>
Sent: Tuesday, April 6, 2021 3:29 PM<br>
To: Ryan Long <<a href="mailto:ryan.long@oarcorp.com" target="_blank">ryan.long@oarcorp.com</a>><br>
Cc: <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
Subject: Re: [PATCH 1/4] main_cp.c: Unused value (CID #1255344)<br>
<br>
<br>
> On 6 Apr 2021, at 5:38 am, Ryan Long <<a href="mailto:ryan.long@oarcorp.com" target="_blank">ryan.long@oarcorp.com</a>> wrote:<br>
> <br>
> CID 1255344: Unused value in copy().<br>
> <br>
> Closes #4339<br>
> ---<br>
> cpukit/libmisc/shell/main_cp.c | 64 <br>
> ++++++++++++++++++++++++++++++++++++++++++<br>
> 1 file changed, 64 insertions(+)<br>
> <br>
> diff --git a/cpukit/libmisc/shell/main_cp.c <br>
> b/cpukit/libmisc/shell/main_cp.c index cddbc95..2984a50 100644<br>
> --- a/cpukit/libmisc/shell/main_cp.c<br>
> +++ b/cpukit/libmisc/shell/main_cp.c<br>
> @@ -310,11 +310,31 @@ copy(rtems_shell_cp_globals* cp_globals,<br>
>        case FTS_ERR:<br>
>            warnx("%s: %s",<br>
>                curr->fts_path, strerror(curr->fts_errno));<br>
> +        #if __rtems__<br>
<br>
Is this ok or should it be #ifdef?<br>
<br>
Chris<br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a></blockquote></div></div>