<div dir="ltr"><div class="gmail_default" style="font-size:small">ping.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 11, 2021 at 1:09 AM Niteesh G. S. <<a href="mailto:niteesh.gs@gmail.com">niteesh.gs@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small">Hello Gedare,</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 10, 2021 at 8:57 PM Gedare Bloom <<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, May 6, 2021 at 8:49 AM Niteesh G. S. <<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a>> wrote:<br>
><br>
> Hi Alan,<br>
><br>
> On Thu, May 6, 2021 at 6:12 PM Alan Cudmore <<a href="mailto:alan.cudmore@gmail.com" target="_blank">alan.cudmore@gmail.com</a>> wrote:<br>
>><br>
>> Hi Niteesh,<br>
>><br>
>> I was hoping to try this out as soon as I get some time. No later than weekend. So if nobody else is able to check it out, I will be able to provide some feedback soon.<br>
>><br>
>> I should be able to bring up the console on a RPi Zero W and RPi3, correct?<br>
><br>
> the consoles should work on Zero W and Pi3 by default. They only fail to work when CONFIGURE_APPLICATION_NEEDS_CONSOLE_DRIVER<br>
> this option is used. This is because when that option is used it calls console_initialize which checks if any boot options were present if none were<br>
> given it defaults to pl011 which is the secondary UART in Zero w and Pi3 so we get no output. This patch defaults to the primary UART instead of<br>
> pl011 depending on the board.<br>
> Also, this patch should be applied on RTEMS 5 since we started supporting Pi3 and Zero w from RTEMS 5.<br>
><br>
You'll need to provide a separate patch with a ticket to close on 5<br>
for a backport. Wait until you get the approval for the master branch<br>
though.</blockquote><div><span class="gmail_default" style="font-size:small">OK. I'll create a ticket and request for a backport once this is pushed on</span></div><div><span class="gmail_default" style="font-size:small">to the current master</span></div><div><span class="gmail_default" style="font-size:small"><br></span></div><div><span class="gmail_default" style="font-size:small">Thanks,</span></div><div><span class="gmail_default" style="font-size:small">Niteesh.</span> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> Thanks,<br>
> Niteesh.<br>
><br>
><br>
>><br>
>> Thanks,<br>
>><br>
>> Alan<br>
>><br>
>><br>
>><br>
>> From: Niteesh G. S.<br>
>> Sent: Thursday, May 6, 2021 4:29 AM<br>
>> To: Joel Sherrill; Christian Mauderer<br>
>> Cc: <a href="mailto:rtems-devel@rtems.org" target="_blank">rtems-devel@rtems.org</a><br>
>> Subject: Re: [PATCH] bsps/raspberrypi/console: Fix default console device<br>
>><br>
>><br>
>><br>
>> ping.<br>
>><br>
>><br>
>><br>
>> On Sat, May 1, 2021 at 9:47 PM Niteesh G. S. <<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a>> wrote:<br>
>><br>
>> On Sat, May 1, 2021 at 8:31 PM Joel Sherrill <<a href="mailto:joel@rtems.org" target="_blank">joel@rtems.org</a>> wrote:<br>
>><br>
>><br>
>><br>
>> On Sat, May 1, 2021, 8:53 AM Niteesh G. S. <<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a>> wrote:<br>
>><br>
>> Just to provide more context,<br>
>><br>
>> When the CONFIGURE_APPLICATION_NEEDS_CONSOLE_DRIVER option is used<br>
>><br>
>> and no --console option is provided, the console driver defaults to PL011.<br>
>><br>
>> In raspberry pi 3 and other models whose primary UART is not PL011, we get no output.<br>
>><br>
>> This patch fixes that by linking the primary UART to the console device.<br>
>><br>
>><br>
>><br>
>> Thanks,<br>
>><br>
>> Niteesh<br>
>><br>
>><br>
>><br>
>> On Sat, May 1, 2021 at 7:05 PM G S Niteesh Babu <<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a>> wrote:<br>
>><br>
>> When no console argument is given, the driver defaults to pl011<br>
>> this results in no output in case of Rpi3 whose primary uart is<br>
>> miniuart.<br>
>> This patch fixes that by defaulting to the primary uart when no<br>
>> console option is provided.<br>
>><br>
>><br>
>><br>
>> Does the default need to vary by model?<br>
>><br>
>> Yes, the primary UART is different across models.<br>
>><br>
>><br>
>><br>
>> Rpi's have two UARTs PL011 and miniuart, on models which have Bluetooth<br>
>><br>
>> the PL011 is used to talk to the Bluetooth and miniuart acts as the primary UART.<br>
>><br>
>> Now we can change this by adding miniuart-bt to config.txt but the miniuart is<br>
>><br>
>> based on the VPU core and requires to add another option which sets the core to<br>
>><br>
>> a fixed freq.<br>
>><br>
>><br>
>><br>
>> ---<br>
>> bsps/arm/raspberrypi/console/console-config.c | 12 +++++++++---<br>
>> 1 file changed, 9 insertions(+), 3 deletions(-)<br>
>><br>
>> diff --git a/bsps/arm/raspberrypi/console/console-config.c b/bsps/arm/raspberrypi/console/console-config.c<br>
>> index 6b8eb80aa4..bd3a8d34c2 100644<br>
>> --- a/bsps/arm/raspberrypi/console/console-config.c<br>
>> +++ b/bsps/arm/raspberrypi/console/console-config.c<br>
>> @@ -165,10 +165,16 @@ static void console_select( void )<br>
>> }<br>
>> }else {<br>
>> /**<br>
>> - * If no command line option was given, default to PL011.<br>
>> + * If no console option was given we default to the primary uarts.<br>
>> + * The initialization of the uart's and BSP_output_char is already done<br>
>> + * in the uart_probe function called before this. So now we can safely<br>
>> + * compare BSP_output_char.<br>
>> */<br>
>> - BSP_output_char = output_char_pl011;<br>
>> - link(PL011, CONSOLE_DEVICE_NAME);<br>
>> + if (BSP_output_char == output_char_pl011) {<br>
>> + link(PL011, CONSOLE_DEVICE_NAME);<br>
>> + }else {<br>
>> + link(MINIUART, CONSOLE_DEVICE_NAME);<br>
>> + }<br>
>> }<br>
>> }<br>
>><br>
>> --<br>
>> 2.17.1<br>
>><br>
>> _______________________________________________<br>
>> devel mailing list<br>
>> <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
>> <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
>><br>
>><br>
><br>
> _______________________________________________<br>
> devel mailing list<br>
> <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
> <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div></div>
</blockquote></div>