<div dir="auto">I have already pushed it. Does a ticket need to be manually closed?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 27, 2021, 9:29 PM Gedare Bloom <<a href="mailto:gedare@rtems.org">gedare@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The patch set looks ok, fixing the ticket number on 2/3.<br>
<br>
On Fri, May 21, 2021 at 3:36 PM Joel Sherrill <<a href="mailto:joel@rtems.org" target="_blank" rel="noreferrer">joel@rtems.org</a>> wrote:<br>
><br>
> This change eliminates a system initialization dependentcy which resulted<br>
> in an application without a file system or console referencing errno being<br>
> forced to include the code to open(/dev/console), close(), atexit(),<br>
> and the unmount infrastructure.<br>
><br>
> Closes #4439.<br>
> ---<br>
> cpukit/include/rtems/confdefs/iodrivers.h | 21 +++++++++++++++++++++<br>
> cpukit/libcsupport/src/libio_init.c | 6 ------<br>
> 2 files changed, 21 insertions(+), 6 deletions(-)<br>
><br>
> diff --git a/cpukit/include/rtems/confdefs/iodrivers.h b/cpukit/include/rtems/confdefs/iodrivers.h<br>
> index e12640624d..a7de77a8c3 100644<br>
> --- a/cpukit/include/rtems/confdefs/iodrivers.h<br>
> +++ b/cpukit/include/rtems/confdefs/iodrivers.h<br>
> @@ -189,6 +189,27 @@ RTEMS_SYSINIT_ITEM(<br>
> || CONFIGURE_APPLICATION_NEEDS_ZERO_DRIVER<br>
> || CONFIGURE_MAXIMUM_DRIVERS */<br>
><br>
> +<br>
> +/*<br>
> + * If any flavor of console driver is configured, then configure the post<br>
> + * driver hook which opens /dev/console as stdin, stdout, and stderr.<br>
> + *<br>
> + * NOTE: This also results in an atexit() handler being registered to close<br>
> + * /dev/console.<br>
> + */<br>
> +#if defined(CONFIGURE_APPLICATION_NEEDS_CONSOLE_DRIVER) || \<br>
> + defined(CONFIGURE_APPLICATION_NEEDS_SIMPLE_CONSOLE_DRIVER) || \<br>
> + defined(CONFIGURE_APPLICATION_NEEDS_SIMPLE_TASK_CONSOLE_DRIVER)<br>
> +<br>
> + #include <rtems/libio.h><br>
> +<br>
> + RTEMS_SYSINIT_ITEM(<br>
> + rtems_libio_post_driver,<br>
> + RTEMS_SYSINIT_STD_FILE_DESCRIPTORS,<br>
> + RTEMS_SYSINIT_ORDER_MIDDLE<br>
> + );<br>
> +#endif<br>
> +<br>
> #endif /* CONFIGURE_INIT */<br>
><br>
> #endif /* _RTEMS_CONFDEFS_IODRIVERS_H */<br>
> diff --git a/cpukit/libcsupport/src/libio_init.c b/cpukit/libcsupport/src/libio_init.c<br>
> index d5814ca5a2..2bfc7664d7 100644<br>
> --- a/cpukit/libcsupport/src/libio_init.c<br>
> +++ b/cpukit/libcsupport/src/libio_init.c<br>
> @@ -65,9 +65,3 @@ RTEMS_SYSINIT_ITEM(<br>
> RTEMS_SYSINIT_LIBIO,<br>
> RTEMS_SYSINIT_ORDER_MIDDLE<br>
> );<br>
> -<br>
> -RTEMS_SYSINIT_ITEM(<br>
> - rtems_libio_post_driver,<br>
> - RTEMS_SYSINIT_STD_FILE_DESCRIPTORS,<br>
> - RTEMS_SYSINIT_ORDER_MIDDLE<br>
> -);<br>
> --<br>
> 2.24.4<br>
><br>
> _______________________________________________<br>
> devel mailing list<br>
> <a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a><br>
> <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div>