<div dir="auto"><div>Hi all,</div><div dir="auto"><br></div><div dir="auto"><br><div class="gmail_quote" dir="auto"><div dir="ltr" class="gmail_attr">On Fri, May 28, 2021, 08:54 Gedare Bloom <<a href="mailto:gedare@rtems.org">gedare@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Are these three still pending? If so, can you ping the other 2 or<br>
advise what is blocking?<br>
<br>
On Mon, Apr 5, 2021 at 7:28 AM Ryan Long <<a href="mailto:ryan.long@oarcorp.com" target="_blank" rel="noreferrer">ryan.long@oarcorp.com</a>> wrote:<br>
><br>
> CID 1437650: Unchecked return value from library in rtems_shell_help().<br>
><br>
> Closes #4291<br>
> ---<br>
>  cpukit/libmisc/shell/main_help.c | 2 +-<br>
>  1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/cpukit/libmisc/shell/main_help.c b/cpukit/libmisc/shell/main_help.c<br>
> index 9f59e9d..564bc30 100644<br>
> --- a/cpukit/libmisc/shell/main_help.c<br>
> +++ b/cpukit/libmisc/shell/main_help.c<br>
> @@ -148,7 +148,7 @@ static int rtems_shell_help(<br>
>          line+= rtems_shell_help_cmd(shell_cmd);<br>
>        if (lines && (line > lines)) {<br>
>          printf("Press any key to continue...");<br></blockquote></div></div><div dir="auto">Unrelated to this patch, but shouldn't the above line say "Press ENTER to continue"? :D</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote" dir="auto"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
> -        getchar();<br>
> +        (void) getchar();<br>
>          printf("\n");<br>
>          line = 0;<br>
>        }<br>
> --<br>
> 1.8.3.1<br>
><br>
> _______________________________________________<br>
> devel mailing list<br>
> <a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a><br>
> <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div></div></div>