<div dir="ltr"><div dir="ltr">Hello Christian,<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jul 28, 2021 at 12:34 AM Christian Mauderer <<a href="mailto:oss@c-mauderer.de">oss@c-mauderer.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello Husni,<br>
<br>
On 27/07/2021 17:04, Ahamed Husni wrote:<br>
> <br>
> <br>
> On Fri, Jul 16, 2021 at 1:25 AM Christian Mauderer <<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a> <br>
> <mailto:<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a>>> wrote:<br>
> <br>
>     On 06/07/2021 19:00, Husni Faiz wrote:<br>
>      > Configure bus for CDC Ethernet<br>
>      > Include CDC Ethernet in Beagle BSP<br>
>      ><br>
>      > Signed-off-by: Husni Faiz <<a href="mailto:ahamedhusni73@gmail.com" target="_blank">ahamedhusni73@gmail.com</a><br>
>     <mailto:<a href="mailto:ahamedhusni73@gmail.com" target="_blank">ahamedhusni73@gmail.com</a>>><br>
>      > ---<br>
>      >   rtemsbsd/include/bsp/nexus-devices.h           |  5 +++++<br>
>      >   rtemsbsd/include/machine/rtems-bsd-nexus-bus.h | 17<br>
>     +++++++++++++++++<br>
>      >   2 files changed, 22 insertions(+)<br>
>      ><br>
>      > diff --git a/rtemsbsd/include/bsp/nexus-devices.h<br>
>     b/rtemsbsd/include/bsp/nexus-devices.h<br>
>      > index e6487470..6a35632e 100644<br>
>      > --- a/rtemsbsd/include/bsp/nexus-devices.h<br>
>      > +++ b/rtemsbsd/include/bsp/nexus-devices.h<br>
>      > @@ -83,6 +83,11 @@ SYSINIT_REFERENCE(rtwn_rtl8188eufw);<br>
>      >   RTEMS_BSD_DRIVER_USB;<br>
>      >   RTEMS_BSD_DRIVER_USB_MASS;<br>
>      ><br>
>      > +#ifdef RTEMS_BSD_MODULE_DEV_USB_TEMPLATE<br>
>      > +RTEMS_BSD_DRIVER_USB_TEMPLATE;<br>
>      > +RTEMS_BSD_DRIVER_CDCE;<br>
>      > +#endif<br>
>      > +<br>
> <br>
>     Same like in patch 2: Shouldn't there be an include for<br>
>     rtems/bsd/modules.h somewhere?<br>
> <br>
> I checked the nexus-devices.h and it already has the modules.h included.<br>
<br>
Sorry. Might have missed that that include in nexus-devices.h. But For <br>
patch 2 it is still necessary, isn't it?<br><br></blockquote><div>I manually removed the  RTEMS_BSD_MODULE_DEV_USB_TEMPLATE <br></div><div>from the modules.h file and rebuilt the libbsd and looked for the symbols to <br></div><div>see if they are included. The symbols weren't there as expected.</div><div><br></div><div>So I thought that the rtems/bsd/modules.h is included in the usb_devices.c indirectly.</div><div>I couldn't track down where it came from. So I might be wrong.<br></div><div><br></div><div>Shall I include the rtems/bsd/modules.h the PATCH V2?</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> <br>
>      >   #elif defined(LIBBSP_ARM_LPC32XX_BSP_H)<br>
>      ><br>
>      >   #include <bsp/irq.h><br>
>      > diff --git a/rtemsbsd/include/machine/rtems-bsd-nexus-bus.h<br>
>     b/rtemsbsd/include/machine/rtems-bsd-nexus-bus.h<br>
>      > index 50a43873..84f561f5 100644<br>
>      > --- a/rtemsbsd/include/machine/rtems-bsd-nexus-bus.h<br>
>      > +++ b/rtemsbsd/include/machine/rtems-bsd-nexus-bus.h<br>
>      > @@ -282,6 +282,15 @@ extern "C" {<br>
>      >       SYSINIT_DRIVER_REFERENCE(umass, uhub)<br>
>      >   #endif /* RTEMS_BSD_DRIVER_USB_MASS */<br>
>      ><br>
>      > +/*<br>
>      > + * USB Template base driver.<br>
>      > + */<br>
>      > +#if !defined(RTEMS_BSD_DRIVER_USB_TEMPLATE)<br>
>      > +  #define RTEMS_BSD_DRIVER_USB_TEMPLATE           \<br>
>      > +    SYSINIT_REFERENCE(usb_temp_init);             \<br>
>      > +    SYSINIT_DRIVER_REFERENCE(usb_template, usb)<br>
>      > +#endif /* RTEMS_BSD_DRIVER_USB_TEMPLATE */<br>
>      > +<br>
>      >   /*<br>
>      >    * USB SAF1761 host controller driver.<br>
>      >    */<br>
>      > @@ -490,6 +499,14 @@ extern "C" {<br>
>      >       SYSINIT_DRIVER_REFERENCE(re, pci);<br>
>      >   #endif /* RTEMS_BSD_DRIVER_PCI_RE */<br>
>      ><br>
>      > +/*<br>
>      > + * CDC Ethernet Driver.<br>
>      > + */<br>
>      > +#if !defined(RTEMS_BSD_DRIVER_CDCE)<br>
>      > +  #define RTEMS_BSD_DRIVER_CDCE                   \<br>
>      > +    SYSINIT_DRIVER_REFERENCE(cdce, uhub);<br>
>      > +#endif /* RTEMS_BSD_DRIVER_FEC */<br>
>      > +<br>
>      >   /**<br>
>      >    ** MMI Physical Layer Support.<br>
>      >    **/<br>
>      ><br>
> <br>
</blockquote></div></div>