<div dir="ltr"><div dir="ltr">Hi Christian,<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Aug 8, 2021 at 1:36 PM Christian Mauderer <<a href="mailto:oss@c-mauderer.de">oss@c-mauderer.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello Husni,<br>
<br>
On 07/08/2021 21:56, Ahamed Husni wrote:<br>
> Hi Christian,<br>
> <br>
> Are there any issues I should address in this patch set?<br>
<br>
I think the big open question is the one from Chris:<br>
<br>
<a href="https://lists.rtems.org/pipermail/devel/2021-July/068634.html" rel="noreferrer" target="_blank">https://lists.rtems.org/pipermail/devel/2021-July/068634.html</a><br>
<br>
You mentioned that you filtered the ones for the imported code. That's <br>
OK for most symbols if they are not relevant for the part where you work <br>
on. But Chris copied a whole block of "extern struct <br>
usb_temp_device_desc *". It's not clear for me whether you filtered some <br>
of them or whether they haven't been generated.<br>
<br></blockquote><div> </div><div>The "extern struct usb_temp_device_desc *" block is in the usb_template.h header.</div><div>These are not generated structs.<br></div><div>These usb device descriptor structs are for each usb device currently supported by</div><div>freebsd. This patch set only imports the CDC Ethernet device template. So we can <br></div><div>exclude the other structs with #ifndef __rtems__ if necessary. If the extra structs should <br></div><div>be excluded, I can send a patch v3.<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
If they are generated: Please keep them. Basically keep everything that <br>
is in one of the files that you touch, except if you have a good reason <br>
why the symbol should _not_ be added.<br>
<br>
If they are not generated: Please clearly say that.<br>
<br></blockquote><div>Those externs are not generated. They are in the original freebsd source.</div><div><a href="https://github.com/freebsd/freebsd-src/blob/main/sys/dev/usb/template/usb_template.h#L106">https://github.com/freebsd/freebsd-src/blob/main/sys/dev/usb/template/usb_template.h#L106</a></div><div><br></div><div>Best regards,</div><div>Husni.<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Best regards<br>
<br>
Christian<br>
<br>
> <br>
> On Mon, Aug 2, 2021 at 12:09 PM Christian MAUDERER <br>
> <<a href="mailto:christian.mauderer@embedded-brains.de" target="_blank">christian.mauderer@embedded-brains.de</a> <br>
> <mailto:<a href="mailto:christian.mauderer@embedded-brains.de" target="_blank">christian.mauderer@embedded-brains.de</a>>> wrote:<br>
> <br>
> Hello Husni,<br>
> <br>
> Am 01.08.21 um 19:59 schrieb Ahamed Husni:<br>
> > Hi Christian,<br>
> ><br>
> > On Sun, Aug 1, 2021 at 4:57 PM Christian Mauderer<br>
> <<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a> <mailto:<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a>><br>
> > <mailto:<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a> <mailto:<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a>>>> wrote:<br>
> ><br>
> > Hello Husni,<br>
> ><br>
> > just tested that and it works fine. With a simple curl I can<br>
> reach<br>
> > about<br>
> > 8.5 MByte/s sending to the beagle and 19.5 MByte/s receiving<br>
> from it.<br>
> ><br>
> > That's 68 Mbps for sending. That's an acceptable speed isn't it?<br>
> ><br>
> <br>
> At the moment I would be OK with basically any speed. It was just some<br>
> information so that someone who finds the mail knows what he can expect.<br>
> <br>
> It would be interesting to see how the speeds compare to a FreeBSD<br>
> setup<br>
> on the Beagle. If there is no bug in our port, it should be about<br>
> the same.<br>
> <br>
> Best regards<br>
> <br>
> Christian<br>
> <br>
> > Please take a look at the points that Chris Johns asked. As<br>
> soon as<br>
> > these are addressed, I think the patches could be merged.<br>
> ><br>
> > I just replied to it now. Sorry for the delay.<br>
> ><br>
> ><br>
> > Please also make the documentation that you started for this more<br>
> > public<br>
> > visible. In other words: Send it as patches to the list and<br>
> not only as<br>
> > a link to some branch!<br>
> ><br>
> > Noted.<br>
> ><br>
> ><br>
> > Best regards<br>
> ><br>
> > Christian<br>
> ><br>
> > On 28/07/2021 13:56, Husni Faiz wrote:<br>
> > > This set of patches import the drivers from freebsd and<br>
> > > configures it for the beagle bsp.<br>
> > ><br>
> > > Github Branch for the commits<br>
> > > <a href="https://github.com/drac98/rtems-libbsd/commits/usb-cdce" rel="noreferrer" target="_blank">https://github.com/drac98/rtems-libbsd/commits/usb-cdce</a><br>
> <<a href="https://github.com/drac98/rtems-libbsd/commits/usb-cdce" rel="noreferrer" target="_blank">https://github.com/drac98/rtems-libbsd/commits/usb-cdce</a>><br>
> > <<a href="https://github.com/drac98/rtems-libbsd/commits/usb-cdce" rel="noreferrer" target="_blank">https://github.com/drac98/rtems-libbsd/commits/usb-cdce</a><br>
> <<a href="https://github.com/drac98/rtems-libbsd/commits/usb-cdce" rel="noreferrer" target="_blank">https://github.com/drac98/rtems-libbsd/commits/usb-cdce</a>>><br>
> > ><br>
> > > Patch for 6-freebsd-12 branch<br>
> > > <a href="https://github.com/drac98/rtems-libbsd/commits/usb-cdce12" rel="noreferrer" target="_blank">https://github.com/drac98/rtems-libbsd/commits/usb-cdce12</a><br>
> <<a href="https://github.com/drac98/rtems-libbsd/commits/usb-cdce12" rel="noreferrer" target="_blank">https://github.com/drac98/rtems-libbsd/commits/usb-cdce12</a>><br>
> > <<a href="https://github.com/drac98/rtems-libbsd/commits/usb-cdce12" rel="noreferrer" target="_blank">https://github.com/drac98/rtems-libbsd/commits/usb-cdce12</a><br>
> <<a href="https://github.com/drac98/rtems-libbsd/commits/usb-cdce12" rel="noreferrer" target="_blank">https://github.com/drac98/rtems-libbsd/commits/usb-cdce12</a>>><br>
> > ><br>
> > > Husni Faiz (5):<br>
> > > usb_template:Import CDC Ethernet<br>
> > > usb_template: Configure template driver only for CDC<br>
> Ethernet<br>
> > > nexus-devices: Include CDC Ethernet for Beagle<br>
> > > libbsd.py: add usb template files<br>
> > > create-kernel-namespace for USB Template driver<br>
> > ><br>
> > > buildset/default.ini | 1 +<br>
> > > buildset/minimal.ini | 3 +-<br>
> > > freebsd/sys/dev/usb/template/usb_template.c | 1493<br>
> > +++++++++++++++++<br>
> > > freebsd/sys/dev/usb/template/usb_template.h | 130 ++<br>
> > > .../sys/dev/usb/template/usb_template_cdce.c | 355 ++++<br>
> > > freebsd/sys/dev/usb/usb_device.c | 8 +-<br>
> > > libbsd.py | 25 +<br>
> > > rtemsbsd/include/bsp/nexus-devices.h | 5 +<br>
> > > .../machine/rtems-bsd-kernel-namespace.h | 5 +<br>
> > > .../include/machine/rtems-bsd-nexus-bus.h | 19 +<br>
> > > 10 files changed, 2041 insertions(+), 3 deletions(-)<br>
> > > create mode 100644<br>
> freebsd/sys/dev/usb/template/usb_template.c<br>
> > > create mode 100644<br>
> freebsd/sys/dev/usb/template/usb_template.h<br>
> > > create mode 100644<br>
> freebsd/sys/dev/usb/template/usb_template_cdce.c<br>
> > ><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > devel mailing list<br>
> > <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a> <mailto:<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a>><br>
> > <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
> <<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a>><br>
> ><br>
> <br>
> -- <br>
> --------------------------------------------<br>
> embedded brains GmbH<br>
> Herr Christian MAUDERER<br>
> Dornierstr. 4<br>
> 82178 Puchheim<br>
> Germany<br>
> email: <a href="mailto:christian.mauderer@embedded-brains.de" target="_blank">christian.mauderer@embedded-brains.de</a><br>
> <mailto:<a href="mailto:christian.mauderer@embedded-brains.de" target="_blank">christian.mauderer@embedded-brains.de</a>><br>
> phone: +49-89-18 94 741 - 18<br>
> fax: +49-89-18 94 741 - 08<br>
> <br>
> Registergericht: Amtsgericht München<br>
> Registernummer: HRB 157899<br>
> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler<br>
> Unsere Datenschutzerklärung finden Sie hier:<br>
> <a href="https://embedded-brains.de/datenschutzerklaerung/" rel="noreferrer" target="_blank">https://embedded-brains.de/datenschutzerklaerung/</a><br>
> <<a href="https://embedded-brains.de/datenschutzerklaerung/" rel="noreferrer" target="_blank">https://embedded-brains.de/datenschutzerklaerung/</a>><br>
> <br>
> <br>
</blockquote></div></div>