<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Aug 5, 2022 at 5:45 AM Sebastian Huber <<a href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@embedded-brains.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 05/08/2022 00:08, Joel Sherrill wrote:<br>
> This adds the configure option CONFIGURE_POSIX_TIMERS_FACE_BEHAVIOR<br>
> which allows the application to choose whether to have the POSIX<br>
> timer_create() function follow the behavior defined by POSIX or<br>
> the FACE Technical Standard.<br>
> <br>
> Updates #4691.<br>
<br>
It would be nice if you could add items for the new option to <br>
rtems-central so that we can use it for the Doxygen documentation and <br>
the manual.<br></blockquote><div><br></div><div>I'll give it a try. Is there a readme or really good example?</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> ---<br>
> cpukit/include/rtems/confdefs.h | 1 +<br>
> cpukit/include/rtems/confdefs/face.h | 71 +++++++++++++++++<br>
> cpukit/include/rtems/posix/timerimpl.h | 11 +++<br>
> cpukit/posix/src/psxtimercreate.c | 19 ++++-<br>
> spec/build/testsuites/psxtests/grp.yml | 2 +<br>
> spec/build/testsuites/psxtests/psxtimer_face01.yml | 20 +++++<br>
> testsuites/psxtests/psxtimer_face01/psxtimer.c | 89 ++++++++++++++++++++++<br>
> .../psxtests/psxtimer_face01/psxtimer_face01.doc | 39 ++++++++++<br>
> .../psxtests/psxtimer_face01/psxtimer_face01.scn | 4 +<br>
> 9 files changed, 255 insertions(+), 1 deletion(-)<br>
> create mode 100644 cpukit/include/rtems/confdefs/face.h<br>
> create mode 100644 spec/build/testsuites/psxtests/psxtimer_face01.yml<br>
> create mode 100644 testsuites/psxtests/psxtimer_face01/psxtimer.c<br>
> create mode 100644 testsuites/psxtests/psxtimer_face01/psxtimer_face01.doc<br>
> create mode 100644 testsuites/psxtests/psxtimer_face01/psxtimer_face01.scn<br>
> <br>
> diff --git a/cpukit/include/rtems/confdefs.h b/cpukit/include/rtems/confdefs.h<br>
> index e6dd3d7..3927d26 100644<br>
> --- a/cpukit/include/rtems/confdefs.h<br>
> +++ b/cpukit/include/rtems/confdefs.h<br>
> @@ -64,6 +64,7 @@<br>
> #include <rtems/confdefs/clock.h><br>
> #include <rtems/confdefs/console.h><br>
> #include <rtems/confdefs/extensions.h><br>
> +#include <rtems/confdefs/face.h><br>
> #include <rtems/confdefs/inittask.h><br>
> #include <rtems/confdefs/initthread.h><br>
> #include <rtems/confdefs/iodrivers.h><br>
> diff --git a/cpukit/include/rtems/confdefs/face.h b/cpukit/include/rtems/confdefs/face.h<br>
> new file mode 100644<br>
> index 0000000..07ab62e<br>
> --- /dev/null<br>
> +++ b/cpukit/include/rtems/confdefs/face.h<br>
> @@ -0,0 +1,71 @@<br>
> +/* SPDX-License-Identifier: BSD-2-Clause */<br>
> +<br>
> +/**<br>
> + * @file<br>
> + *<br>
> + * @ingroup RTEMSImplApplConfig<br>
> + *<br>
> + * @brief This header file evaluates configuration options related to<br>
> + * the FACE Technical Standard.<br>
> + *<br>
> + * The FACE Technical Standard (<a href="https://opengroup.org/face" rel="noreferrer" target="_blank">https://opengroup.org/face</a>) is an<br>
> + * open standard designed for safety critical embedded systems. It<br>
> + * includes POSIX profiles and requirements that promote safety<br>
> + * and portability. As a general rules, the profiles place a minimum<br>
> + * on the services which an operating system must provide. Those<br>
> + * same profile definitions represent the maximum services which<br>
> + * an application may use.<br>
> + */<br>
> +<br>
> +/*<br>
> + * Copyright (C) 2022 On-Line Applications Research Corporation (OAR)<br>
> + *<br>
> + * Redistribution and use in source and binary forms, with or without<br>
> + * modification, are permitted provided that the following conditions<br>
> + * are met:<br>
> + * 1. Redistributions of source code must retain the above copyright<br>
> + * notice, this list of conditions and the following disclaimer.<br>
> + * 2. Redistributions in binary form must reproduce the above copyright<br>
> + * notice, this list of conditions and the following disclaimer in the<br>
> + * documentation and/or other materials provided with the distribution.<br>
> + *<br>
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"<br>
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE<br>
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE<br>
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE<br>
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR<br>
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF<br>
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS<br>
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN<br>
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)<br>
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE<br>
> + * POSSIBILITY OF SUCH DAMAGE.<br>
> + */<br>
> +<br>
> +#ifndef _RTEMS_CONFDEFS_FACE_H<br>
> +#define _RTEMS_CONFDEFS_FACE_H<br>
> +<br>
> +#ifndef __CONFIGURATION_TEMPLATE_h<br>
> +#error "Do not include this file directly, use <rtems/confdefs.h> instead"<br>
> +#endif<br>
> +<br>
> +#ifdef CONFIGURE_INIT<br>
> +<br>
> +#include <rtems/posix/timerimpl.h><br>
> +<br>
> +#ifndef CONFIGURE_POSIX_TIMERS_FACE_BEHAVIOR<br>
> + bool _POSIX_Timer_Is_allowed_on_CLOCK_REALTIME( void )<br>
> + {<br>
> + /*<br>
> + * Per the FACE Technical Standard, POSIX timers should not be<br>
> + * allowed on CLOCK_REALTIME for safety reasons. If the application<br>
> + * wants the FACE behavior, then this method is instantiated.<br>
> + */<br>
> + return false;<br>
> + }<br>
<br>
I would change this to:<br>
<br>
int _POSIX_Timer_Is_clock_valid( clockid_t clock_id )<br>
<br>
It returns an error number or zero.<br></blockquote><div><br></div><div>Perhaps OK on errno or zero but that name isn't right. CLOCK_REALTIME</div><div>is still a valid POSIX clock. There are just strict requirements around its</div><div>use for the FACE profiles. That name implies a general validity. The requirement</div><div>is specifically around creating a timer that uses CLOCK_REALTIME.</div><div><br></div><div>Previous work has addressed the other restrictions. The TOD Hook </div><div>additions do allow a BSP to sync an RTC but the FACE purpose was</div><div>to check if the application (e.g. partition/virtual space) has permission</div><div>to set the clock. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> +<br>
> +#endif /* CONFIGURE_POSIX_TIMERS_FACE_BEHAVIOR */<br>
> +<br>
> +#endif /* CONFIGURE_INIT */<br>
> +<br>
> +#endif /* _RTEMS_CONFDEFS_FACE_H */<br>
> diff --git a/cpukit/include/rtems/posix/timerimpl.h b/cpukit/include/rtems/posix/timerimpl.h<br>
> index 8f92186..c6e3b64 100644<br>
> --- a/cpukit/include/rtems/posix/timerimpl.h<br>
> +++ b/cpukit/include/rtems/posix/timerimpl.h<br>
> @@ -139,6 +139,17 @@ RTEMS_INLINE_ROUTINE void _POSIX_Timer_Release(<br>
> _ISR_lock_ISR_enable( lock_context );<br>
> }<br>
> <br>
> +/**<br>
> + * @brief Follow POSIX or FACE Technical Standard on timer_create<br>
> + *<br>
> + * POSIX allows for the creation of timers based on CLOCK_REALTIME.<br>
> + * This is viewed as a safety issue by the FACE Technical Standard<br>
> + * and required to return an error. These are conflicting behaviors.<br>
> + * This method is instanced by configuration when FACE conformant<br>
> + * behavior is desired by the application.<br>
> + */<br>
> +RTEMS_WEAK bool _POSIX_Timer_Is_allowed_on_CLOCK_REALTIME( void );<br>
<br>
No RTEMS_WEAK in the header file.<br></blockquote><div><br></div><div>OK. Need another include file clearly. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
-- <br>
embedded brains GmbH<br>
Herr Sebastian HUBER<br>
Dornierstr. 4<br>
82178 Puchheim<br>
Germany<br>
email: <a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brains.de</a><br>
phone: +49-89-18 94 741 - 16<br>
fax: +49-89-18 94 741 - 08<br>
<br>
Registergericht: Amtsgericht München<br>
Registernummer: HRB 157899<br>
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler<br>
Unsere Datenschutzerklärung finden Sie hier:<br>
<a href="https://embedded-brains.de/datenschutzerklaerung/" rel="noreferrer" target="_blank">https://embedded-brains.de/datenschutzerklaerung/</a><br>
</blockquote></div></div>