<div dir="auto">Push it Chris.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Sep 16, 2022, 10:01 AM Frank Kühndel <<a href="mailto:frank.kuehndel@embedded-brains.de">frank.kuehndel@embedded-brains.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Chris,<br>
<br>
I checked your two patches in an opensuse leap 15.4 container building <br>
the tools (rtems-source-builder git) for RTEMS 6 and ARM BSP. The build <br>
was OK; the dependencies on "expat-devel" and "gmp-devel" are gone.<br>
<br>
Thanks and have a nice weekend<br>
Frank<br>
<br>
<br>
On 9/16/22 08:59, <a href="mailto:chrisj@rtems.org" target="_blank" rel="noreferrer">chrisj@rtems.org</a> wrote:<br>
> Subject:<br>
> [PATCH 1/2] sb/setbuilder: Install the build when stagging or configured <br>
> to install<br>
> From:<br>
> <a href="mailto:chrisj@rtems.org" target="_blank" rel="noreferrer">chrisj@rtems.org</a><br>
> Date:<br>
> 9/16/22, 08:59<br>
> <br>
> To:<br>
> <a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a><br>
> <br>
> <br>
> From: Chris Johns<<a href="mailto:chrisj@rtems.org" target="_blank" rel="noreferrer">chrisj@rtems.org</a>><br>
> <br>
> ---<br>
>   source-builder/sb/setbuilder.py | 9 ++++++---<br>
>   1 file changed, 6 insertions(+), 3 deletions(-)<br>
> <br>
> diff --git a/source-builder/sb/setbuilder.py b/source-builder/sb/setbuilder.py<br>
> index f24ac87..3e16111 100644<br>
> --- a/source-builder/sb/setbuilder.py<br>
> +++ b/source-builder/sb/setbuilder.py<br>
> @@ -226,6 +226,9 @@ class buildset:<br>
>       def installing(self):<br>
>           return self.install_mode() == 'installing'<br>
>   <br>
> +    def installable(self):<br>
> +        return not self.opts.no_install() or self.staging()<br>
> +<br>
>       def staging(self):<br>
>           return not self.installing()<br>
>   <br>
> @@ -553,14 +556,14 @@ class buildset:<br>
>                          ', '.join([<a href="http://b.name" rel="noreferrer noreferrer" target="_blank">b.name</a>() for b in builds])))<br>
>               if deps is None and not have_errors:<br>
>                   for b in builds:<br>
> -                    log.trace('_bset:   : %s: %r' % (self.install_mode(),<br>
> -                                                     b.installable()))<br>
> +                    log.trace('_bset:   : %s: installable=%r build-installable=%r' % \<br>
> +                              (self.install_mode(), self.installable(), b.installable()))<br>
>                       if b.installable():<br>
>                           prefix = b.config.expand('%{_prefix}')<br>
>                           buildroot = path.join(b.config.expand('%{buildroot}'), prefix)<br>
>                           if self.staging():<br>
>                               prefix = b.config.expand('%{stagingroot}')<br>
> -                        if not self.opts.no_install():<br>
> +                        if self.installable():<br>
>                               self.install(self.install_mode(), <a href="http://b.name" rel="noreferrer noreferrer" target="_blank">b.name</a>(), buildroot, prefix)<br>
>               #<br>
>               # Sizes ...<br>
> -- 2.37.1 _______________________________________________ devel mailing <br>
> list <a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a> <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
> <br>
<br>
-- <br>
embedded brains GmbH<br>
Herr Frank KÜHNDEL<br>
Dornierstr. 4<br>
82178 Puchheim<br>
Germany<br>
email: <a href="mailto:frank.kuehndel@embedded-brains.de" target="_blank" rel="noreferrer">frank.kuehndel@embedded-brains.de</a><br>
phone:  +49-89-18 94 741 - 23<br>
mobile: +49-176-15 22 06 - 11<br>
fax:    +49-89-18 94 741 - 08<br>
<br>
Registergericht: Amtsgericht München<br>
Registernummer: HRB 157899<br>
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler<br>
Unsere Datenschutzerklärung finden Sie hier:<br>
<a href="https://embedded-brains.de/datenschutzerklaerung/" rel="noreferrer noreferrer" target="_blank">https://embedded-brains.de/datenschutzerklaerung/</a><br>
<br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a></blockquote></div>