<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jan 23, 2023, 9:18 AM Gedare Bloom <<a href="mailto:gedare@rtems.org">gedare@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">ok. also ok would have been merging the lines.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">I like not chaining the assignments. I think simple lines are easier for review. I suspect some coding style wouldn't like it anyway.</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On Mon, Jan 23, 2023 at 6:18 AM Sebastian Huber<br>
<<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank" rel="noreferrer">sebastian.huber@embedded-brains.de</a>> wrote:<br>
><br>
> Do not use a chained assignment for code clarity.<br>
><br>
> Update #4818.<br>
> ---<br>
>  cpukit/score/src/threadcreateidle.c | 2 +-<br>
>  1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/cpukit/score/src/threadcreateidle.c b/cpukit/score/src/threadcreateidle.c<br>
> index cb15d5cc3c..4f16a57099 100644<br>
> --- a/cpukit/score/src/threadcreateidle.c<br>
> +++ b/cpukit/score/src/threadcreateidle.c<br>
> @@ -105,7 +105,7 @@ static void _Thread_Create_idle_for_CPU(<br>
>     *  WARNING!!! This is necessary to "kick" start the system and<br>
>     *             MUST be done before _Thread_Start is invoked.<br>
>     */<br>
> -  cpu->heir      =<br>
> +  cpu->heir      = idle;<br>
>    cpu->executing = idle;<br>
>  #if defined(RTEMS_SMP)<br>
>    cpu->ancestor = idle;<br>
> --<br>
> 2.35.3<br>
><br>
> _______________________________________________<br>
> devel mailing list<br>
> <a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a><br>
> <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div></div></div>