<div dir="ltr"><div>I looked at this issue earlier this morning and this fix looks ok.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jan 24, 2023 at 9:56 AM Sebastian Huber <<a href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@embedded-brains.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Several SMP message processing functions returned a value.  This value<br>
was always unused.<br>
<br>
Close #4822.<br>
---<br>
 cpukit/include/rtems/score/smpimpl.h | 15 ++++-----------<br>
 cpukit/score/src/smp.c               |  7 +------<br>
 2 files changed, 5 insertions(+), 17 deletions(-)<br>
<br>
diff --git a/cpukit/include/rtems/score/smpimpl.h b/cpukit/include/rtems/score/smpimpl.h<br>
index ef32687bec..2ffc047070 100644<br>
--- a/cpukit/include/rtems/score/smpimpl.h<br>
+++ b/cpukit/include/rtems/score/smpimpl.h<br>
@@ -166,12 +166,9 @@ RTEMS_NO_RETURN void _SMP_Start_multitasking_on_secondary_processor(<br>
  * @param[in, out] cpu_self is the processor control of the processor executing<br>
  *   this function.<br>
  *<br>
- * @return Returns the processed message.<br>
+ * @param message is the message to process.<br>
  */<br>
-long unsigned _SMP_Process_message(<br>
-  Per_CPU_Control *cpu_self,<br>
-  long unsigned    message<br>
-);<br>
+void _SMP_Process_message( Per_CPU_Control *cpu_self, long unsigned message );<br>
<br>
 /**<br>
  * @brief Tries to process the current SMP message.<br>
@@ -200,10 +197,8 @@ void _SMP_Try_to_process_message(<br>
  *<br>
  * @param[in, out] cpu_self is the processor control of the processor executing<br>
  *   this function.<br>
- *<br>
- * @return Returns the processed message.<br>
  */<br>
-static inline long unsigned _SMP_Inter_processor_interrupt_handler(<br>
+static inline void _SMP_Inter_processor_interrupt_handler(<br>
   Per_CPU_Control *cpu_self<br>
 )<br>
 {<br>
@@ -222,10 +217,8 @@ static inline long unsigned _SMP_Inter_processor_interrupt_handler(<br>
   );<br>
<br>
   if ( RTEMS_PREDICT_FALSE( message != 0 ) ) {<br>
-    return _SMP_Process_message( cpu_self, message );<br>
+    _SMP_Process_message( cpu_self, message );<br>
   }<br>
-<br>
-  return message;<br>
 }<br>
<br>
 /**<br>
diff --git a/cpukit/score/src/smp.c b/cpukit/score/src/smp.c<br>
index 7c068f3c51..75520829e1 100644<br>
--- a/cpukit/score/src/smp.c<br>
+++ b/cpukit/score/src/smp.c<br>
@@ -311,10 +311,7 @@ void _SMP_Request_shutdown( void )<br>
   }<br>
 }<br>
<br>
-long unsigned _SMP_Process_message(<br>
-  Per_CPU_Control *cpu_self,<br>
-  long unsigned    message<br>
-)<br>
+void _SMP_Process_message( Per_CPU_Control *cpu_self, long unsigned message )<br>
 {<br>
   if ( ( message & SMP_MESSAGE_SHUTDOWN ) != 0 ) {<br>
     ISR_Level level;<br>
@@ -332,8 +329,6 @@ long unsigned _SMP_Process_message(<br>
   if ( ( message & SMP_MESSAGE_PERFORM_JOBS ) != 0 ) {<br>
     _Per_CPU_Perform_jobs( cpu_self );<br>
   }<br>
-<br>
-  return message;<br>
 }<br>
<br>
 void _SMP_Try_to_process_message(<br>
-- <br>
2.35.3<br>
<br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div></div>