<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p></p>
<div>Hello,<br>
<br>
As part of an internship at the German Aerospace Center, I am currently working on the implementation of a CAN driver for a Xilinx Zynq SoC.
<span class="HwtZe" lang="en"><span class="jCAhz ChMk0b"><span class="ryNqvb">For this I used the existing CAN framework /dev/can/can.h.</span></span><span class="jCAhz"><span class="ryNqvb">
</span></span><span class="jCAhz ChMk0b"><span class="ryNqvb">A merge request will follow soon.</span></span><span class="jCAhz"><span class="ryNqvb">
</span></span></span><br>
</div>
<div><br>
</div>
<div><br>
Here's what I'd like to add to the framework if it hasn't already been done:<br>
<br>
* RxFIFO. Currently can_bus_read only stores the latest CAN message in can_bus->can_rx_msg.
<br>
</div>
<div>There is a FIXME note on this in can.c, line 188, but I couldn't find an implementation of it.<br>
<br>
* ioctl functionality. can_bus_ioctl does not forward the commands and arguments to can_dev_ops->dev_ioctl.
<br>
</div>
<div>Is there a reason for that? I propose a command enum that would provide consistency.<br>
</div>
<div><br>
</div>
<div><br>
@Prashanth S (fishesprashanth@gmail.com) have you already worked on these points?<br>
<br>
Thanks everyone for your feedback!<br>
<br>
Best regards<br>
Carlo Brokering</div>
<p><br>
</p>
<p><br>
</p>
</div>
</body>
</html>