<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 15, 2023 at 5:41 PM Chris Johns <<a href="mailto:chrisj@rtems.org">chrisj@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
Reviewing the RPU patch I noticed a .inc file being added and I wondered why so<br>
I checked the sources and to my surprise found:<br>
<br>
rtems.git $ find bsps -name \*.inc<br>
bsps/v850/gdbv850sim/config/v850sim.inc<br>
bsps/m68k/genmcf548x/config/genmcf548x.inc<br>
bsps/m68k/gen68340/include/m68340.inc<br>
bsps/m68k/gen68340/include/m68349.inc<br>
bsps/arm/altera-cyclone-v/config/altcycv.inc<br>
bsps/arm/raspberrypi/config/raspberrypi.inc<br>
bsps/arm/lpc32xx/config/lpc32xx.inc<br>
bsps/arm/beagle/config/beagle.inc<br>
bsps/arm/tms570/config/tms570ls3137.inc<br>
bsps/arm/xilinx-zynqmp/config/xilinx_zynqmp.inc<br>
bsps/arm/xilinx-zynq/config/xilinx_zynq.inc<br>
bsps/arm/lpc24xx/config/lpc17xx.inc<br>
bsps/arm/lpc24xx/config/lpc40xx.inc<br>
bsps/arm/lpc24xx/config/lpc24xx.inc<br>
bsps/arm/lm3s69xx/config/lm3s69xx.inc<br>
bsps/powerpc/gen5200/config/gen5200.inc<br>
bsps/powerpc/tqm8xx/config/tqm8xx.inc<br>
bsps/powerpc/mpc55xxevb/config/mpc55xx.inc<br>
bsps/powerpc/qoriq/config/qoriq.inc<br>
bsps/powerpc/gen83xx/config/gen83xx.inc<br></blockquote><div><br></div><div>These likely can. Thinking back, we have cfg files for every BSP</div><div>variant within a family. They often set a variable like CPU and CPU_CFLAGS</div><div>and included a shared .inc file. These all appear to be from BSPs which</div><div>had variants. I think they are remnants and missed when the .cfg files</div><div>were </div><div><br></div><div>Would like someone to concur. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
And for .cfg there is:<br>
<br>
rtems.git $ find bsps -name \*.cfg | wc -l<br>
     191<br></blockquote><div><br></div><div>Are these installed and used by the application Makefile system. If so, no. </div><div><br></div><div>But if these were just the ".cfg" files I mentioned above, then likely yes. We</div><div>probably had 191 BSPs which we switched to waf.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Can these files be removed?<br>
<br>
Chris<br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div></div>