<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 04.01.2024 23:22, Kinsey Moore
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAPycBoj5cRfuqCAFqFGgiGoF=2Jyn1SV-YykhVpMF5vN1h9mPQ@mail.gmail.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div>Comments inline.<br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Thu, Jan 4, 2024 at
12:54 PM <<a href="mailto:berndmoessner80@gmail.com"
moz-do-not-send="true" class="moz-txt-link-freetext">berndmoessner80@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">From:
Bernd Moessner <<a
href="mailto:berndmoessner80@gmail.com" target="_blank"
moz-do-not-send="true" class="moz-txt-link-freetext">berndmoessner80@gmail.com</a>><br>
<br>
---<br>
.../lwip211/src/contrib/ports/xilinx/netif/xadapter.c
| 3 ++-<br>
1 file changed, 2 insertions(+), 1 deletion(-)<br>
<br>
diff --git
a/embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/netif/xadapter.c
b/embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/netif/xadapter.c<br>
index 9594ff5..98e7a8e 100644<br>
---
a/embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/netif/xadapter.c<br>
+++
b/embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/netif/xadapter.c<br>
@@ -184,8 +184,9 @@ xemac_add(struct netif *netif,<br>
#endif<br>
#endif<br>
default:<br>
- xil_printf("unable to
determine type of EMAC with baseaddress 0x%08x\r\n",<br>
+ xil_printf("unable to
determine type of EMAC with baseaddress %" PRIXPTR,<br>
mac_baseaddr);<br>
+ xil_printf("\r\b");<br>
</blockquote>
<div><br>
</div>
<div>The second line has a \b instead of a \n. <br>
</div>
<div><br>
</div>
<div>Beyond that typo, changes in third-party sources in
rtems-lwIP are treated just like they are in rtems-libbsd.
Changes are additive only and gated by __rtems__. So if you
wanted to change line A to line B, you'd have this
construct:</div>
<div><br>
</div>
<div>#ifdef __rtems__</div>
<div>line B</div>
<div>#else</div>
<div>line A</div>
<div>#endif</div>
<div><br>
</div>
<div><br>
</div>
</div>
</div>
</blockquote>
<p>Okay, if fixed it in a later patch. I`ll merge the patches and
add the gates. I guess there are some other places where I ll have
to add the gates. I have reported one of the issues already to
xilinx. I`ll report all of them to Xilinx and until they've
patched their sources we need to stick to the gates.<br>
</p>
<p><br>
</p>
</body>
</html>