<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof"><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">Hi Sebastian, Chris,</span></div>
<div class="elementToProof"><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"><br>
</span></div>
<div class="elementToProof"><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">> I am not sure about this patch. It changes the initialization. The code</span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">> you remove was added by:</span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">> commit 691d0edd34f25a883c5dd0a56051d087b88e4fa4</span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">> Author: Chris Johns <chrisj@rtems.org></span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">> Date: Tue Aug 17 17:57:41 2021 +1000</span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">> arm/xilinx: Fix zynq-uart interrupt receive</span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">> - Trigger on a single character entering the RX FIFO</span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">> - Disable the RX timeout</span></div>
<div class="elementToProof"><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">> - Send up to a FIFO full of data</span></div>
<div class="elementToProof"><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"><br>
</span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">As I wrote in the commit message, I think that a UART driver should not send any characters without being explicitely
told so. The protocol that I'm using gets confused as it does not expect these bytes.</span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"><br>
</span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">I've indeed seen the commit you reference, and the call to `zynq_uart_reset_tx_flush()` which sends these bytes
seems to me unrelated to the bug the commit fixes, which is about the receive interrupt. As such, I believe that my patch should be merged (at least from a functionality point of view, I don't have any feelings about the implementation. For ex, passing a flag
"text"/"raw" or having a global variable "char *initialization_tx_bytes" could also work, although that might not be compatible with the TERMIOS/POSIX way of doing things).</span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"><br>
</span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">That being said, I'm only arguing my particular case, and you as maintainers have the final word.</span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"><br>
</span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">I'm available if you need anything else from me.</span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"><br>
</span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">Best regards,</span></div>
<div class="elementToProof"><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">Adrien Chardon</span></div>
<div id="appendonsend"></div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr style="display: inline-block; width: 98%;">
<div dir="ltr" id="divRplyFwdMsg"><span style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>From:</b> Sebastian Huber <sebastian.huber@embedded-brains.de><br>
<b>Sent:</b> 01 February 2024 08:03<br>
<b>To:</b> devel@rtems.org <devel@rtems.org><br>
<b>Cc:</b> Chris Johns <chrisj@rtems.org>; Adrien Chardon <Adrien@reflexaerospace.com><br>
<b>Subject:</b> Re: [Patch] bsp/tms570/sci: fix bug in tms570_sci_read_received_chars()</span>
<div> </div>
</div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">[You don't often get email from sebastian.huber@embedded-brains.de. Learn why this is important at
<a href="https://aka.ms/LearnAboutSenderIdentification" id="OWAb211271a-b784-b806-e323-359a8c65a01e" class="OWAAutoLink" data-loopstyle="linkonly" data-auth="NotApplicable">
https://aka.ms/LearnAboutSenderIdentification</a> ]<br>
<br>
Hello Adrien,<br>
<br>
On 31.01.24 18:35, Adrien Chardon wrote:<br>
><br>
> While testing the counterpart of my protocol on a Zynq, I found a<br>
> similar issue<br>
> where the UART is assumed to be used for printable text only. The second<br>
> patch<br>
> fixes it.<br>
<br>
I am not sure about this patch. It changes the initialization. The code<br>
you remove was added by:<br>
<br>
commit 691d0edd34f25a883c5dd0a56051d087b88e4fa4<br>
Author: Chris Johns <chrisj@rtems.org><br>
Date: Tue Aug 17 17:57:41 2021 +1000<br>
<br>
arm/xilinx: Fix zynq-uart interrupt receive<br>
<br>
- Trigger on a single character entering the RX FIFO<br>
<br>
- Disable the RX timeout<br>
<br>
- Send up to a FIFO full of data<br>
<br>
--<br>
embedded brains GmbH & Co. KG<br>
Herr Sebastian HUBER<br>
Dornierstr. 4<br>
82178 Puchheim<br>
Germany<br>
email: sebastian.huber@embedded-brains.de<br>
phone: +49-89-18 94 741 - 16<br>
fax: +49-89-18 94 741 - 08<br>
<br>
Registergericht: Amtsgericht München<br>
Registernummer: HRB 157899<br>
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler<br>
Unsere Datenschutzerklärung finden Sie hier:<br>
<a href="https://embedded-brains.de/datenschutzerklaerung/" id="OWA3cfa175a-cb96-81d0-bbd8-f78999d09527" class="OWAAutoLink" data-loopstyle="linkonly" data-auth="NotApplicable">https://embedded-brains.de/datenschutzerklaerung/</a></span></div>
</body>
</html>