<div dir="ltr">Based on Christian saying it works and me confirming that, I pushed this.<div><br></div><div>Thanks a lot Chris! <no sarcasm on that at all><br><div><br></div><div>--joel</div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 21, 2024 at 2:22 AM Christian MAUDERER <<a href="mailto:christian.mauderer@embedded-brains.de">christian.mauderer@embedded-brains.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello Chris,<br>
<br>
On 2024-02-21 06:16, Chris Johns wrote:<br>
> Hi,<br>
> <br>
> I have a patch for rtems-docs.git to move us to the pip installed<br>
> sphinx-rtd-theme removing the custom theme based on sphinx-rtd-theme we<br>
> currently use.<br>
> <br>
<br>
I think reducing RTEMS specific adaptions is a great idea. So thank you <br>
for that.<br>
<br>
> The ticket is #4994.<br>
> <br>
> The patch is over 4M in size as it deletes common/sphinx_rtd_theme_rtems. YOu<br>
> can download it from:<br>
> <br>
>   <a href="https://ftp.rtems.org/pub/rtems/people/chrisj/0001-sphinx-Use-the-pip-installed-sphinx-rtd-theme.patch" rel="noreferrer" target="_blank">https://ftp.rtems.org/pub/rtems/people/chrisj/0001-sphinx-Use-the-pip-installed-sphinx-rtd-theme.patch</a><br>
> <br>
> What I am not sure about is how old Sphinx can be to build the documentation. My<br>
> versions are:<br>
> <br>
>   Sphinx                        7.2.6<br>
>   sphinx-rtd-theme              2.0.0<br>
>   sphinxcontrib-applehelp       1.0.7<br>
>   sphinxcontrib-bibtex          2.6.1<br>
>   sphinxcontrib-devhelp         1.0.5<br>
>   sphinxcontrib-htmlhelp        2.0.4<br>
>   sphinxcontrib-jquery          4.1<br>
>   sphinxcontrib-jsmath          1.0.1<br>
>   sphinxcontrib-qthelp          1.0.6<br>
>   sphinxcontrib-serializinghtml 1.1.9<br>
> <br>
> Is it OK to push?<br>
<br>
I tried building the manuals with your patches on OpenSUSE. It's <br>
basically the same procedure as without the patch except that the <br>
sphinx-rtd-theme is now necessary. The result looks as expected.<br>
<br>
With the patch, the search seems to work again. That hasn't been the <br>
case with the old version.<br>
<br>
So from my point of view, the patch is a great improvement and OK.<br>
<br>
Best regards<br>
<br>
Christian<br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div>