<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hello Sebastian,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I have also reviewed the other changes that we now have since the original BSP patch, and it looks like our current queue for Zynq RPU is empty.</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
We are curious to see which changes/rework for RPU you are preparing.</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Stanislav</div>
<div id="appendonsend"></div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr style="display: inline-block; width: 98%;">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>Von:</b> Sebastian Huber <sebastian.huber@embedded-brains.de><br>
<b>Gesendet:</b> Dienstag, 19. März 2024 11:50<br>
<b>An:</b> Stanislav Pankevich <stanislav@reflexaerospace.com>; devel@rtems.org <devel@rtems.org><br>
<b>Betreff:</b> Re: bsps: xilinx-zynqmp-rpu: fix the integer truncation in Triple Timer Counter clock driver</span>
<div> </div>
</div>
<div><span style="font-size: 11pt;">[Sie erhalten nicht häufig E-Mails von sebastian.huber@embedded-brains.de. Weitere Informationen, warum dies wichtig ist, finden Sie unter
<a href="https://aka.ms/LearnAboutSenderIdentification" id="OWAb9189df6-141b-c61b-1f5e-f51538a92fa9" class="OWAAutoLink" data-auth="NotApplicable" data-loopstyle="linkonly">
https://aka.ms/LearnAboutSenderIdentification</a> ]<br>
<br>
Hello Stanislav,<br>
<br>
that is a nice coincidence. I started to work with this BSP last week<br>
and I also fixed this issue, but I had some other patches in the queue.<br>
I reworked this driver a bit. I will check in your patch first.<br>
<br>
On 19.03.24 10:54, Stanislav Pankevich wrote:<br>
> Dear RTEMS developers,<br>
><br>
> Here is a follow-up patch to our previous work on the Zynq US+ RPU BSP.<br>
><br>
> In fact, we had fixed this issue a few months ago but didn't find a good<br>
> time to upstream it since then.<br>
><br>
> P.S. It is great to see that the migration to GitLab is happening.<br>
><br>
> Thanks,<br>
> Stanislav<br>
><br>
> ---<br>
><br>
> Author: Stanislav Pankevich <stanislav@reflexaerospace.com><br>
> Date: Tue Mar 19 10:34:57 2024 +0100<br>
><br>
> bsps: xilinx-zynqmp-rpu: fix the integer truncation in Triple Timer<br>
> Counter clock driver<br>
> We observed a strange behavior of the 1Hz timer when running cFS on<br>
> Zynq RPU. After some investigation, we reduced the error to the<br>
> truncation issue. This patch fixes the issue.<br>
><br>
> diff --git a/bsps/shared/dev/clock/xil-ttc.c<br>
> b/bsps/shared/dev/clock/xil-ttc.c<br>
> index 2c47684045..5121773a6f 100644<br>
> --- a/bsps/shared/dev/clock/xil-ttc.c<br>
> +++ b/bsps/shared/dev/clock/xil-ttc.c<br>
> @@ -126,7 +126,7 @@ static void<br>
> zynqmp_ttc_clock_driver_support_initialize_hardware(void)<br>
> /* Setup match register to generate tick IRQ */<br>
> ttc_clock_instance.irq_match_interval =<br>
> - (uint32_t) ((frequency * microsec_per_tick) / 1000000);<br>
> + (uint32_t) (((uint64_t)frequency * microsec_per_tick) / 1000000);<br>
> XTtcPs_WriteReg(BSP_SELECTED_TTC_ADDR, XTTCPS_MATCH_0_OFFSET,<br>
> ttc_clock_instance.irq_match_interval);<br>
> /* Clear interupts (clear on read) */<br>
><br>
><br>
> _______________________________________________<br>
> devel mailing list<br>
> devel@rtems.org<br>
> <a href="http://lists.rtems.org/mailman/listinfo/devel" id="OWA69af0ec6-1bd7-67f0-4984-416d6a818ede" class="OWAAutoLink" data-auth="NotApplicable" data-loopstyle="linkonly">
http://lists.rtems.org/mailman/listinfo/devel</a><br>
<br>
--<br>
embedded brains GmbH & Co. KG<br>
Herr Sebastian HUBER<br>
Dornierstr. 4<br>
82178 Puchheim<br>
Germany<br>
email: sebastian.huber@embedded-brains.de<br>
phone: +49-89-18 94 741 - 16<br>
fax: +49-89-18 94 741 - 08<br>
<br>
Registergericht: Amtsgericht München<br>
Registernummer: HRB 157899<br>
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler<br>
Unsere Datenschutzerklärung finden Sie hier:<br>
<a href="https://embedded-brains.de/datenschutzerklaerung/" id="OWAe847abea-47e8-71f6-2ce1-af10ade5f84d" class="OWAAutoLink" data-auth="NotApplicable" data-loopstyle="linkonly">https://embedded-brains.de/datenschutzerklaerung/</a></span></div>
</body>
</html>