<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div dir="ltr"></div><div dir="ltr"><br></div><div dir="ltr"><blockquote type="cite">On 4 Apr 2024, at 3:52 am, Kinsey Moore <kinsey.moore@oarcorp.com> wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr"><meta http-equiv="Content-Type" content="text/html; charset=utf-8"><div dir="ltr"><div>Looks fine overall. Minor nits:</div><div>"host" is set to "freebsd" and is never used.</div></div></div></blockquote><div><br></div>The tool uses simhost so it could be any host listed in that module and it references that table. Nothing is built but needed to creat a build object. Simhost is used to get all sources for all hosts. <div><br><blockquote type="cite"><div dir="ltr"><div dir="ltr"><div>Numeric indexes for repo config details are nice for brevity, but not for readability.</div></div></div></blockquote><div><br></div>I will add something. </div><div><br></div><div>Chris<br><blockquote type="cite"><div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"></blockquote></div>
</div></blockquote></div></body></html>