<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
<br>
<br>
Chris Johns wrote:
<blockquote cite="mid:47A029B0.20900@rtems.org" type="cite">
<pre wrap="">Till Straumann wrote:
</pre>
<blockquote type="cite">
<pre wrap="">With the new flashdisk support there is an opportunity
for me to reiterate my rant at libblock/bdbuf.
</pre>
</blockquote>
<pre wrap=""><!---->
Thanks for raising this issue. I was not aware of it.
</pre>
</blockquote>
I have been working on "stress testing" the bdbuf routine using an
sdcard driver. I occasionally see some lockups. I had one version
that had applied your patches, Till, to eliminate some race conditions
but abandoned them when I was tracking some other issues. I will
reapply them to my current version and retest.<br>
<blockquote cite="mid:47A029B0.20900@rtems.org" type="cite">
<pre wrap=""></pre>
<blockquote type="cite">
<pre wrap="">Could someone familiar with the flashdisk comment, please?
</pre>
</blockquote>
<pre wrap=""><!---->
I think the situation be even longer as segments could be compacted then
erased and there could be a number of these.
</pre>
<blockquote type="cite">
<pre wrap="">Anyways, IMHO libblock/bdbuf should be converted to using mutex protection
(I have started some work in that direction).
</pre>
</blockquote>
<pre wrap=""><!---->
Great. May I suggest opening a PR and attaching your patch as it is and I will
take a look and sort through it. I have a need to look at this code in detail
so this may all tie together.
</pre>
</blockquote>
I agree with the idea of mutex protection.<br>
<br>
I tried a mutex approach with the existing bdbuf function and had
limited success. Perhaps your fresh take on this would help. Do you
have any sort of version of bdbuf.c that I could drop in and try?<br>
<br>
Brett Swimley<br>
<blockquote cite="mid:47A029B0.20900@rtems.org" type="cite">
<pre wrap="">_______________________________________________
rtems-users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:rtems-users@rtems.com">rtems-users@rtems.com</a>
<a class="moz-txt-link-freetext" href="http://rtems.rtems.org/mailman/listinfo/rtems-users">http://rtems.rtems.org/mailman/listinfo/rtems-users</a>
</pre>
</blockquote>
</body>
</html>