<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>change log for rtems-testing (2010-08-02)</title>
</head>
<body text='#000000' bgcolor='#ffffff'>
<a name='cs1'></a>
<table border='0' cellspacing='0' cellpadding='5' width='100%' bgcolor='#eeeeee'>
<tr><td colspan='3' bgcolor='#dddddd'>
<font color='#bb2222'><strong>joel</strong></font>
</td></tr>
<tr><td colspan='3' bgcolor='#dddddd'><pre>2010-08-02 Joel Sherrill <joel.sherrilL@OARcorp.com>
* Explanations.txt: Update. Remove old ones and add a number of new
entries.
</pre></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems-testing/rtems-coverage/ChangeLog.diff?r1=text&tr1=1.287&r2=text&tr2=1.288&diff_format=h">M</a></td><td width='1%'>1.288</td><td width='100%'>rtems-coverage/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems-testing/rtems-coverage/Explanations.txt.diff?r1=text&tr1=1.68&r2=text&tr2=1.69&diff_format=h">M</a></td><td width='1%'>1.69</td><td width='100%'>rtems-coverage/Explanations.txt</td></tr>
</table>
<pre>
<font color='#006600'>diff -u rtems-testing/rtems-coverage/ChangeLog:1.287 rtems-testing/rtems-coverage/ChangeLog:1.288
--- rtems-testing/rtems-coverage/ChangeLog:1.287 Wed Jul 14 11:29:00 2010
+++ rtems-testing/rtems-coverage/ChangeLog Mon Aug 2 11:28:03 2010
</font><font color='#997700'>@@ -1,3 +1,8 @@
</font><font color='#000088'>+2010-08-02 Joel Sherrill <joel.sherrilL@OARcorp.com>
+
+ * Explanations.txt: Update. Remove old ones and add a number of new
+ entries.
+
</font> 2010-07-14 Joel Sherrill <joel.sherrilL@OARcorp.com>
* do_coverage, rtems_items.sed: Include more info in summary.
<font color='#006600'>diff -u rtems-testing/rtems-coverage/Explanations.txt:1.68 rtems-testing/rtems-coverage/Explanations.txt:1.69
--- rtems-testing/rtems-coverage/Explanations.txt:1.68 Mon Jun 21 13:33:06 2010
+++ rtems-testing/rtems-coverage/Explanations.txt Mon Aug 2 11:28:03 2010
</font><font color='#997700'>@@ -1,222 +1,216 @@
</font><font color='#880000'>-bspcmdline_getparam.c:67
</font><font color='#000088'>+privateenv.c:43
</font> Simple Test Case
<font color='#880000'>-Need a test case to return NULL.
</font><font color='#000088'>+free_user_env is never called when (env == &rtems_global_user_env). It is
+possible that this path is impossible but that will require analysis of the
+callers. Since this is static, it is quite possible this is covered by
+the callers.
</font> +++
<font color='#880000'>-bspcmdline_getparamrhs.c:36
</font><font color='#000088'>+imfs_chown.c:46
</font> Simple Test Case
<font color='#880000'>-Need a test case to return NULL. This looks like a parameter of the form
-"LHS" with no "=" or "RHS".
</font><font color='#000088'>+Not root and not owner. Please try to cover all branch paths.
</font> +++
<font color='#880000'>-mknod.c:44
</font><font color='#000088'>+imfs_fchmod.c:42
</font> Simple Test Case
<font color='#880000'>-Call mknod with a mode of 0
</font><font color='#000088'>+Not root and not owner. Please try to cover all branch paths.
</font> +++
<font color='#880000'>-imfs_fifo.c:100
-Bharath Suri
-IMFS_fifo_ioctl should be hit when fifo tests are done if not
-check why.
</font><font color='#000088'>+imfs_fifo.c:61
+Requires Discussion
+This is an error return path which only returns an error when
+pipe_release() returns an error but pipe_release() can't return
+an error. Maybe pipe_release() should be changed to void.
</font> +++
<font color='#880000'>-imfs_fifo.c:125
-Bharath Suri
-IMFS_fifo_lseek should be hit when fifo tests are done if not
-check why.
-+++
-
-imfs_fifo.c:69
-Bharath Suri
-IMFS_fifo_read should be hit when fifo tests are done if not
-check why.
-+++
-
-imfs_fifo.c:84
-Bharath Suri
-IMFS_fifo_write should be hit when fifo tests are done if not
-check why.
-+++
-
-fifo.c:553
-Bharath Suri
-pipe_ioctl should be hit when fifo tests are done if not check
-why.
</font><font color='#000088'>+imfs_getchild.c:51
+Simple Test Case
+Appprently we never call this with ".." for the parent directory.
</font> +++
<font color='#880000'>-fifo.c:582
-Bharath Suri
-pipe_lseek should be hit when fifo tests are done if not check
-why.
</font><font color='#000088'>+imfs_fsunmount.c:86
+Ask Chris Johns
+I think he wrote this code and can probably identify the test case.
</font> +++
<font color='#880000'>-fifo.c:395
-Bharath Suri
-pipe_read should be hit when fifo tests are done if not check
-why.
</font><font color='#000088'>+imfs_fsunmount.c:93
+Ask Chris Johns
+I think he wrote this code and can probably identify the test case.
</font> +++
<font color='#880000'>-fifo.c:467
-Bharath Suri
-pipe_write should be hit when fifo tests are done if not check
-why.
</font><font color='#000088'>+imfs_initsupp.c:55
+Requires Discussion
+I think this is an error case that cannot be reached. The
+bytes_per_block is set by confdefs.h and there are error checks
+in that to prevent a bad value.
</font> +++
<font color='#880000'>-memfile.c:400
-Bharath Suri
-IMFS_memfile_remove_block should be hit when fifo tests are done
-if not check why.
</font><font color='#000088'>+imfs_mount.c:44
+Unreachable?
+We need to ask Chris Johns about this. I believe this is a
+case where the error checking has been done by the system<span style="background-color: #FF0000"> </span>
+call layer. I analyzed the "file handlers" callbacks for
+guarantees on parameters. This indicates the same analysis
+needs to happen for "file system handlers."
</font> +++
<font color='#880000'>-check.c:376
</font><font color='#000088'>+imfs_debug.c:43
</font> Simple Test Case
<font color='#880000'>-Stack_check_Dump_threads_usage should be hit in same test as new
-stack check test for report.
</font><font color='#000088'>+Need to do an IMFS_dump after loading a tarfile from memory.
+I think this is a simple addition to tar01.
</font> +++
<font color='#880000'>-check.c:356
</font><font color='#000088'>+imfs_debug.c:54
</font> Simple Test Case
<font color='#880000'>-Stack_check_find_high_water_mark should be hit in same test as
-new stack check test for report.
</font><font color='#000088'>+Need to do an IMFS_dump on an IMFS filesystem which has a very large
+file in it. I think this is a simple addition to one of the existing
+IMFS tests which creates a large file.
</font> +++
<font color='#880000'>-check.c:470
</font><font color='#000088'>+imfs_debug.c:88
</font> Simple Test Case
<font color='#880000'>-rtems_stack_checker_report_usage_with_plugin should be hit in
-same test as new stack check test for report.
</font><font color='#000088'>+We need to do an IMFS_dump on an IMFS filesystem which has a bad node type
+in it. This may require peeking behind the curtain and changing a value.
</font> +++
<font color='#880000'>-privateenv.c:114
-Simple Test Case
-free_user_env and rtems_libio_share_private_env new test.
</font><font color='#000088'>+imfs_rename.c:40
+Discuss
+I think this is either a simple test or unreachable code. We need
+to discuss this to figure out which.
</font> +++
<font color='#880000'>-privateenv.c:33
-Simple Test Case
-free_user_env and rtems_libio_share_private_env new test.
</font><font color='#000088'>+imfs_unlink.c:51
+Discuss
+I think this is either a simple test or unreachable code. We need
+to discuss this to figure out which.
</font> +++
<font color='#880000'>-check.c:215
-Simple Test Case
-Stack_check_report_blown_task Should be in stack check test check
-why not hit.
</font><font color='#000088'>+imfs_unmount.c:45
+Discuss
+I think this is either a simple test or unreachable code. We need
+to discuss this to figure out which.
</font> +++
<font color='#880000'>-assocnamebad.c:40
-Simple Test Case
-rtems_assoc_name_bad called from new; may want to add for
-associations.
-+++
</font><font color='#000088'>+imfs_unmount.c:52
+Discuss
+I think this is either a simple test or unreachable code. We need
+to discuss this to figure out which.
++++<span style="background-color: #FF0000"> </span>
</font>
<font color='#880000'>-ioman.c:70
</font><font color='#000088'>+dup2.c:51
</font> Simple Test Case
<font color='#880000'>-rtems_io_lookup_name added to existing io dev stub test ?sp19?
-+++
</font><font color='#000088'>+This looks like we never get to the bottom to actually call fcntl()
+which I take to mean that we do not have a test for a working call<span style="background-color: #FF0000"> </span>
+to dup2().
</font>
<font color='#880000'>-error.c:201
-Simple Test Case
-rtems_panic, rtems_verror, rtems_error: New test for collection
-of rtems error reportin routines.
</font><font color='#000088'>+But we need to be careful because fcntl(F_DUPFD) which is called has
+slightly different semantics. I suspect that fcntl(F_DUPFD) is wrong.
+See fcntl.c:55 for more details.
</font> +++
<font color='#880000'>-error.c:109
-Simple Test Case
-rtems_panic, rtems_verror, rtems_error: New test for collection
-of rtems error reportin routines.
</font><font color='#000088'>+fcntl.c:55
+Discuss
+I question that this is correct. We are calling this from dup2()
+and the semantics are slightly different. fcntl is<span style="background-color: #FF0000"> </span>
+I suspect that by adding a shared routine and calling it from fcntl()
+and and dup2() we can fix this.
</font> +++
<font color='#880000'>-error.c:182
</font><font color='#000088'>+fcntl.c:83
</font> Simple Test Case
<font color='#880000'>-rtems_panic, rtems_verror, rtems_error: New test for collection
-of rtems error reportin routines.
</font><font color='#000088'>+We need a test setting close on exec.
</font> +++
<font color='#880000'>-getpwent.c:272
</font><font color='#000088'>+fcntl.c:143
</font> Simple Test Case
<font color='#880000'>-Simple
</font><font color='#000088'>+None of the file system specific handlers have ever returned an error here.
</font> +++
<font color='#880000'>-getpwent.c:413
</font><font color='#000088'>+newlibc_exit.c:89
</font> Simple Test Case
<font color='#880000'>-Simple
</font><font color='#000088'>+libc_wrapup() is never called when the system state is down.
</font> +++
<font color='#880000'>-getpwent.c:441
</font><font color='#000088'>+readv.c:106
</font> Simple Test Case
<font color='#880000'>-Simple
</font><font color='#000088'>+The count needs to be -1 in one of the requests. Also add a test for
+0 value at the same time since it appears that is a missing branch
+condition.
</font> +++
<font color='#880000'>-fcntl.c:186
-Simple Test Case
-This is a function wrapper add a test case calling it where the
-wrapped function is called from
</font><font color='#000088'>+getpwent.c:127
+Discuss
+I think this is detecting whether or not the read can be fulfilled
+from the buffer. But I am not sure.
</font> +++
<font color='#880000'>-getpid.c:43
</font><font color='#000088'>+getpwent.c:141
</font> Simple Test Case
<font color='#880000'>-This is a function wrapper add a test case calling it where the
-wrapped function is called from
</font><font color='#000088'>+I think this is a matter of putting in a VERY large number in
+a numeric field. This is detecting overflow. I think a long
+string of 9's will do most of this.
</font> +++
<font color='#880000'>-_gettod.c:84
</font><font color='#000088'>+getpwent.c:142
</font> Simple Test Case
<font color='#880000'>-This is a function wrapper add a test case calling it where the
-wrapped function is called from
</font><font color='#000088'>+
+See getpwent.c:141
</font> +++
<font color='#880000'>-link.c:103
</font><font color='#000088'>+getpwent.c:112
</font> Simple Test Case
<font color='#880000'>-This is a function wrapper add a test case calling it where the
-wrapped function is called from
</font><font color='#000088'>+
+This is actually the error case at line 103 (*nleft < 2). I think this
+will be hit by having a password entry which does not have enough
+characters left in the user's return buffer while something is
+being copied into it.
</font> +++
<font color='#880000'>-_realloc_r.c:28
</font><font color='#000088'>+writev.c:104
</font> Simple Test Case
<font color='#880000'>-This is a function wrapper add a test case calling it where the
-wrapped function is called from
</font><font color='#000088'>+This is a case of needing 0 values in the write iov entries.
</font> +++
<font color='#880000'>-stat.c:100
</font><font color='#000088'>+writev.c:113
</font> Simple Test Case
<font color='#880000'>-This is a function wrapper add a test case calling it where the
-wrapped function is called from
</font><font color='#000088'>+This is a case of needing negative values in the write iov entries.
</font> +++
<font color='#880000'>-unlink.c:115
</font><font color='#000088'>+vprintk.c:125
</font> Simple Test Case
<font color='#880000'>-This is a function wrapper add a test case calling it where the
-wrapped function is called from
</font><font color='#000088'>+0x6f is a 'o'. It looks like we do not have a printk test which uses %o.
</font> +++
<font color='#880000'>-getpwent.c:406
</font><font color='#000088'>+imfs_load_tar.c:112
</font> Simple Test Case
<font color='#880000'>-This is a function wrapper add a test case calling it where the
-wrapped function is called from
</font><font color='#000088'>+Need to make sure one of the tar tests is configured with the IMFS
+and the other is configured with fifoIMFS.
</font> +++
<font color='#880000'>-getpwent.c:263
</font><font color='#000088'>+imfs_load_tar.c:151
</font> Simple Test Case
<font color='#880000'>-This is a function wrapper add a test case calling it where the
-wrapped function is called from
</font><font color='#000088'>+We apparently only have a relative symbolic link. We need to include
+one which has an absolute path. This will be a broken symlink on the
+host but resolve fine on the target.
</font> +++
<font color='#880000'>-getpwent.c:254
-Simple Test Case
-This is a function wrapper add a test case calling it where the
-wrapped function is called from
</font><font color='#000088'>+imfs_load_tar.c:169
+Medium Test Case
+The eval for make must fail. We will have to ask Jennifer how to
+make this call fail.
</font> +++
<font color='#880000'>-getpwent.c:247
-Simple Test Case
-This is a function wrapper add a test case calling it where the
-wrapped function is called from
</font><font color='#000088'>+rtems_mkdir.c:102
+Email Sebastian
+Sebastian needs to write a test case for this.
</font> +++
<font color='#880000'>-malloc_deferred.c:57
-Simple Test Case
-New test to Free memory from timer service routine. There is a
-send signal from TSR test that can be copied Consider adding test
-template for single operation from tsr. Talk to Joel before
-implementing.
</font><font color='#000088'>+rtems_mkdir.c:110
+Email Sebastian
+Sebastian needs to write a test case for this.
</font> +++
<font color='#000088'>+rtems_mkdir.c:124
+Email Sebastian
+Sebastian needs to write a test case for this.
++++
</font></pre>
<p> </p>
<p>--<br />
<small>Generated by <a href="http://www.codewiz.org/projects/index.html#loginfo">Deluxe Loginfo</a> 2.122 by Bernardo Innocenti <bernie@develer.com></small></p>
</body>
</html>