<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>change log for rtems-testing (2010-08-08)</title>
</head>
<body text='#000000' bgcolor='#ffffff'>
<a name='cs1'></a>
<table border='0' cellspacing='0' cellpadding='5' width='100%' bgcolor='#eeeeee'>
<tr><td colspan='3' bgcolor='#dddddd'>
<font color='#bb2222'><strong>joel</strong></font>
</td></tr>
<tr><td colspan='3' bgcolor='#dddddd'><pre>2010-08-08 Joel Sherrill <joel.sherrill@oarcorp.com>
* check_bsp: Add more checks.
</pre></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems-testing/merge-helpers/ChangeLog.diff?r1=text&tr1=1.3&r2=text&tr2=1.4&diff_format=h">M</a></td><td width='1%'>1.4</td><td width='100%'>merge-helpers/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems-testing/merge-helpers/check_bsp.diff?r1=text&tr1=1.3&r2=text&tr2=1.4&diff_format=h">M</a></td><td width='1%'>1.4</td><td width='100%'>merge-helpers/check_bsp</td></tr>
</table>
<pre>
<font color='#006600'>diff -u rtems-testing/merge-helpers/ChangeLog:1.3 rtems-testing/merge-helpers/ChangeLog:1.4
--- rtems-testing/merge-helpers/ChangeLog:1.3 Thu Sep 10 14:42:35 2009
+++ rtems-testing/merge-helpers/ChangeLog Sun Aug 8 09:52:23 2010
</font><font color='#997700'>@@ -1,3 +1,7 @@
</font><font color='#000088'>+2010-08-08 Joel Sherrill <joel.sherrill@oarcorp.com>
+
+ * check_bsp: Add more checks.
+
</font> 2009-09-10 Joel Sherrill <joel.sherrill@oarcorp.com>
* check_bsp: Clean up check_bsp.
<font color='#006600'>diff -u rtems-testing/merge-helpers/check_bsp:1.3 rtems-testing/merge-helpers/check_bsp:1.4
--- rtems-testing/merge-helpers/check_bsp:1.3 Thu Sep 10 14:42:35 2009
+++ rtems-testing/merge-helpers/check_bsp Sun Aug 8 09:52:23 2010
</font><font color='#997700'>@@ -33,11 +33,24 @@
</font> fi
grep ${2} ${1} >/dev/null
if [ $? -ne 0 ] ; then
<font color='#880000'>- echo NOT in ${bspdir}/${1}
</font><font color='#000088'>+ echo "${2} is NOT in ${bspdir}/${1}"
</font> fi
}
<font color='#000088'>+test_its_NOT_there_all_case()
+{
+ if [ $# -lt 2 ] ; then
+ echo Usage: $0 FILE pattern<span style="background-color: #FF0000"> </span>
+ fi
+ FILE=$1
+ shift
+ grep -i "${*}" ${FILE} >/dev/null
+ if [ $? -eq 0 ] ; then
+ echo "(${*}) SHOULD NOT BE IN ${bspdir}/${FILE} - case independent check"
+ fi
+}
+
</font> test_its_NOT_there()
{
if [ $# -lt 2 ] ; then
<font color='#997700'>@@ -47,9 +60,29 @@
</font> shift
grep "${*}" ${FILE} >/dev/null
if [ $? -eq 0 ] ; then
<font color='#880000'>- echo SHOULD NOT BE IN ${bspdir}/${FILE}
</font><font color='#000088'>+ echo "(${*}) SHOULD NOT BE IN ${bspdir}/${FILE}"
</font> fi
<font color='#000088'>+}
+
+find_source()
+{
+ findArgs=
+ while getopts "cCm" OPT
+ do
+ case "$OPT" in
+ c) findArgs="${findArgs} -o -name configure.ac" ;;
+ C) findArgs="${findArgs} -o -name *.cfg" ;;
+ m) findArgs="${findArgs} -o -name Makefile.am" ;;
+ *) echo "bad arg to find_source ($OPT)" ; exit 1 ;;
+ esac
+ done
+
+ shiftcount=`expr $OPTIND - 1`
+ shift $shiftcount
</font>
<font color='#000088'>+ args=$*
+
+ find . -name "*.[chS]" ${findArgs}
</font> }
if [ -r configure.ac ] ; then
<font color='#997700'>@@ -58,42 +91,77 @@
</font> test_its_there configure.ac RTEMS_BSP_CLEANUP_OPTIONS
fi
<font color='#000088'>+# Verify no lines longer than 80 columns
+echo "=== Checking for lines greater than 79 columns"
+find_source -m -c -C | while read f
+do
+ grep ".\{80,\}" ${f} >/dev/null
+ if [ $? -eq 0 ] ; then
+ echo "${bspdir}/${FILE} has the following lines that are too long"
+ grep -n '.\{80,\}' ${f}
+ fi
+done
+
+# We want CVS Id strings everywhere possible
</font> # really need to make the copyright strings consistent in BSPs
echo "=== Checking for copyright notices"
<font color='#880000'>-find . -name "*.[chS]" | while read f
</font><font color='#000088'>+find_source | while read f
</font> do
<font color='#880000'>- grep -i COPYRIGHT ${f} >/dev/null
- if [ $? -ne 0 ] ; then
- echo Copyright is NOT in ${bspdir}/${f}
- fi
</font><font color='#000088'>+ test_its_NOT_there_all_case ${f} COPYRIGHT
</font> done
# We want CVS Id strings everywhere possible
echo "=== Checking for CVS Id strings"
<font color='#880000'>-find . -name "*.[chS]" -o -name "*.ac" -o -name "Makefile.am" | while read f
</font><font color='#000088'>+find_source | while read f
</font> do
test_its_there ${f} "\$Id"
done
<font color='#880000'>-# We do not want printf in a BSP
-echo "=== Checking for printf"
-find . -name "*.[chS]" -o -name "*.ac" -o -name "Makefile.am" | while read f
</font><font color='#000088'>+# We do not want stdio in a BSP
+echo "=== Checking for stdio"
+find_source -m -c -C | while read f
</font> do
test_its_NOT_there ${f} printf
<font color='#880000'>-done
-
-# We do not want puts in a BSP
-echo "=== Checking for puts"
-find . -name "*.[chS]" -o -name "*.ac" -o -name "Makefile.am" | while read f
-do
</font> test_its_NOT_there ${f} puts
done
# We do not want the reformatted license notice
echo "=== Checking for reformatted RTEMS license notices"
<font color='#880000'>-find . -name "*.[chS]" -o -name "*.ac" -o -name "Makefile.am" | while read f
</font><font color='#000088'>+find_source -m -c -C | while read f
</font> do
test_its_NOT_there ${f} "this file may be found in the file"
done
<font color='#000088'>+# We do not want GPL code
+echo "=== Checking for hints of GPL code"
+find_source -m -c -C | while read f
+do
+ test_its_NOT_there ${f} "Free Software Foundation"
+ test_its_NOT_there ${f} "program is free software"
+ test_its_NOT_there ${f} "General Public License"
+done
+
+# We do not want hints that there are things left to do
+echo "=== Checking for TODO hints"
+find_source -m -c -C | while read f
+do
+ test_its_NOT_there ${f} XXX
+ test_its_NOT_there ${f} TODO
+ test_its_NOT_there ${f} TBD
+done
+
+# If not using -O2, then we really want to know
+echo "=== Checking for not using -O2"
+grep -H "\-O[013456789]" make/custom/*.cfg
+
+# BSPs should not turn on extra warnings
+echo "=== Checking for turning on extra GCC warning checks"
+grep -H "\-W" make/custom/*.cfg
+
+# Hopefully have some output from the tmtests
+echo "=== Checking for timing information"
+c=`ls -1 times* 2>/dev/null | wc -l`
+if [ ${c} -eq 0 ] ; then
+ echo "Please run the timing tests and include the results."
+fi
</font> exit 0
</pre>
<p> </p>
<a name='cs2'></a>
<table border='0' cellspacing='0' cellpadding='5' width='100%' bgcolor='#eeeeee'>
<tr><td colspan='3' bgcolor='#dddddd'>
<font color='#bb2222'><strong>joel</strong></font>
</td></tr>
<tr><td colspan='3' bgcolor='#dddddd'><pre>2010-08-08 Joel Sherrill <joel.sherrill@oarcorp.com>
* check_bsp: Add CVS Id and blanks at EOL.
</pre></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems-testing/merge-helpers/ChangeLog.diff?r1=text&tr1=1.4&r2=text&tr2=1.5&diff_format=h">M</a></td><td width='1%'>1.5</td><td width='100%'>merge-helpers/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems-testing/merge-helpers/check_bsp.diff?r1=text&tr1=1.4&r2=text&tr2=1.5&diff_format=h">M</a></td><td width='1%'>1.5</td><td width='100%'>merge-helpers/check_bsp</td></tr>
</table>
<pre>
<font color='#006600'>diff -u rtems-testing/merge-helpers/ChangeLog:1.4 rtems-testing/merge-helpers/ChangeLog:1.5
--- rtems-testing/merge-helpers/ChangeLog:1.4 Sun Aug 8 09:52:23 2010
+++ rtems-testing/merge-helpers/ChangeLog Sun Aug 8 09:57:41 2010
</font><font color='#997700'>@@ -1,5 +1,9 @@
</font> 2010-08-08 Joel Sherrill <joel.sherrill@oarcorp.com>
<font color='#000088'>+ * check_bsp: Add CVS Id and blanks at EOL.
+
+2010-08-08 Joel Sherrill <joel.sherrill@oarcorp.com>
+
</font> * check_bsp: Add more checks.
2009-09-10 Joel Sherrill <joel.sherrill@oarcorp.com>
<font color='#006600'>diff -u rtems-testing/merge-helpers/check_bsp:1.4 rtems-testing/merge-helpers/check_bsp:1.5
--- rtems-testing/merge-helpers/check_bsp:1.4 Sun Aug 8 09:52:23 2010
+++ rtems-testing/merge-helpers/check_bsp Sun Aug 8 09:57:41 2010
</font><font color='#997700'>@@ -5,6 +5,9 @@
</font> # Test for:
# - presense of BSP_BOOTCARD_OPTIONS
# - XXX
<font color='#000088'>+# - XXX
+#
+# $Id$
</font> #
if [ $# -ne 1 ] ; then
<font color='#997700'>@@ -29,7 +32,7 @@
</font> test_its_there()
{
if [ $# -ne 2 ] ; then
<font color='#880000'>- echo Usage: $0 FILE pattern<span style="background-color: #FF0000"> </span>
</font><font color='#000088'>+ echo Usage: $0 FILE pattern
</font> fi
grep ${2} ${1} >/dev/null
if [ $? -ne 0 ] ; then
<font color='#997700'>@@ -41,7 +44,7 @@
</font> test_its_NOT_there_all_case()
{
if [ $# -lt 2 ] ; then
<font color='#880000'>- echo Usage: $0 FILE pattern<span style="background-color: #FF0000"> </span>
</font><font color='#000088'>+ echo Usage: $0 FILE pattern
</font> fi
FILE=$1
shift
<font color='#997700'>@@ -54,7 +57,7 @@
</font> test_its_NOT_there()
{
if [ $# -lt 2 ] ; then
<font color='#880000'>- echo Usage: $0 FILE pattern<span style="background-color: #FF0000"> </span>
</font><font color='#000088'>+ echo Usage: $0 FILE pattern
</font> fi
FILE=$1
shift
</pre>
<p> </p>
<p>--<br />
<small>Generated by <a href="http://www.codewiz.org/projects/index.html#loginfo">Deluxe Loginfo</a> 2.122 by Bernardo Innocenti <bernie@develer.com></small></p>
</body>
</html>