<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>change log for rtems (2010-08-27)</title>
</head>
<body text='#000000' bgcolor='#ffffff'>
<a name='cs1'></a>
<table border='0' cellspacing='0' cellpadding='5' width='100%' bgcolor='#eeeeee'>
<tr><td colspan='3' bgcolor='#dddddd'>
<font color='#bb2222'><strong>joel</strong></font>
<font color='#225522'><em>(on branch rtems-4-10-branch)</em></font>
</td></tr>
<tr><td colspan='3' bgcolor='#dddddd'><pre>2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
PR 1692/filesystem
* libcsupport/include/rtems/libio.h, libfs/src/devfs/devfs_eval.c,
libfs/src/imfs/imfs_eval.c: Fix implementation and use of
rtems_libio_is_valid_perms().
</pre></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/ChangeLog.diff?r1=text&tr1=1.2611&r2=text&tr2=1.2612&diff_format=h">M</a></td><td width='1%'>1.2612</td><td width='100%'>cpukit/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/ChangeLog.diff?r1=text&tr1=1.2346.2.63&r2=text&tr2=1.2346.2.64&diff_format=h">M</a></td><td width='1%'>1.2346.2.64</td><td width='100%'>cpukit/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libcsupport/include/rtems/libio.h.diff?r1=text&tr1=1.78&r2=text&tr2=1.79&diff_format=h">M</a></td><td width='1%'>1.79</td><td width='100%'>cpukit/libcsupport/include/rtems/libio.h</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libcsupport/include/rtems/libio.h.diff?r1=text&tr1=1.65.2.4&r2=text&tr2=1.65.2.5&diff_format=h">M</a></td><td width='1%'>1.65.2.5</td><td width='100%'>cpukit/libcsupport/include/rtems/libio.h</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libfs/src/devfs/devfs_eval.c.diff?r1=text&tr1=1.6&r2=text&tr2=1.7&diff_format=h">M</a></td><td width='1%'>1.7</td><td width='100%'>cpukit/libfs/src/devfs/devfs_eval.c</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libfs/src/devfs/devfs_eval.c.diff?r1=text&tr1=1.6&r2=text&tr2=1.6.2.1&diff_format=h">M</a></td><td width='1%'>1.6.2.1</td><td width='100%'>cpukit/libfs/src/devfs/devfs_eval.c</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libfs/src/imfs/imfs_eval.c.diff?r1=text&tr1=1.30&r2=text&tr2=1.31&diff_format=h">M</a></td><td width='1%'>1.31</td><td width='100%'>cpukit/libfs/src/imfs/imfs_eval.c</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libfs/src/imfs/imfs_eval.c.diff?r1=text&tr1=1.26&r2=text&tr2=1.26.2.1&diff_format=h">M</a></td><td width='1%'>1.26.2.1</td><td width='100%'>cpukit/libfs/src/imfs/imfs_eval.c</td></tr>
</table>
<pre>
<font color='#006600'>diff -u rtems/cpukit/ChangeLog:1.2611 rtems/cpukit/ChangeLog:1.2612
--- rtems/cpukit/ChangeLog:1.2611 Fri Aug 27 01:42:45 2010
+++ rtems/cpukit/ChangeLog Fri Aug 27 12:32:59 2010
</font><font color='#997700'>@@ -1,3 +1,10 @@
</font><font color='#000088'>+2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
+
+ PR 1692/filesystem
+ * libcsupport/include/rtems/libio.h, libfs/src/devfs/devfs_eval.c,
+ libfs/src/imfs/imfs_eval.c: Fix implementation and use of
+ rtems_libio_is_valid_perms().
+
</font> 2010-08-26 Sebastian Huber <sebastian.huber@embedded-brains.de>
* libfs/src/defaults/default_evalpath.c,
<font color='#006600'>diff -u rtems/cpukit/ChangeLog:1.2346.2.63 rtems/cpukit/ChangeLog:1.2346.2.64
--- rtems/cpukit/ChangeLog:1.2346.2.63 Thu Aug 26 01:35:20 2010
+++ rtems/cpukit/ChangeLog Fri Aug 27 12:33:09 2010
</font><font color='#997700'>@@ -1,3 +1,10 @@
</font><font color='#000088'>+2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
+
+ PR 1692/filesystem
+ * libcsupport/include/rtems/libio.h, libfs/src/devfs/devfs_eval.c,
+ libfs/src/imfs/imfs_eval.c: Fix implementation and use of
+ rtems_libio_is_valid_perms().
+
</font> 2010-08-26 Chris Johns <chrisj@rtems.org>
* libfs/src/rfs/rtems-rfs-file.c: Check then load the inode is not
<font color='#006600'>diff -u rtems/cpukit/libcsupport/include/rtems/libio.h:1.78 rtems/cpukit/libcsupport/include/rtems/libio.h:1.79
--- rtems/cpukit/libcsupport/include/rtems/libio.h:1.78 Thu Jul 15 03:10:46 2010
+++ rtems/cpukit/libcsupport/include/rtems/libio.h Fri Aug 27 12:32:59 2010
</font><font color='#997700'>@@ -1287,7 +1287,7 @@
</font> * Verifies that the permission flag is valid.
*/
#define rtems_libio_is_valid_perms( _perm ) \
<font color='#880000'>- (~ ((~RTEMS_LIBIO_PERMS_RWX) & _perm ))
</font><font color='#000088'>+ (((~RTEMS_LIBIO_PERMS_RWX) & _perm ) == 0)
</font>
/*
* Prototypes for filesystem
<font color='#006600'>diff -u rtems/cpukit/libcsupport/include/rtems/libio.h:1.65.2.4 rtems/cpukit/libcsupport/include/rtems/libio.h:1.65.2.5
--- rtems/cpukit/libcsupport/include/rtems/libio.h:1.65.2.4 Thu Jul 1 10:18:06 2010
+++ rtems/cpukit/libcsupport/include/rtems/libio.h Fri Aug 27 12:33:11 2010
</font><font color='#997700'>@@ -537,7 +537,7 @@
</font> * Verifies that the permission flag is valid.
*/
#define rtems_libio_is_valid_perms( _perm ) \
<font color='#880000'>- (~ ((~RTEMS_LIBIO_PERMS_RWX) & _perm ))
</font><font color='#000088'>+ (((~RTEMS_LIBIO_PERMS_RWX) & _perm ) == 0)
</font>
/*
* Prototypes for filesystem
<font color='#006600'>diff -u rtems/cpukit/libfs/src/devfs/devfs_eval.c:1.6 rtems/cpukit/libfs/src/devfs/devfs_eval.c:1.7
--- rtems/cpukit/libfs/src/devfs/devfs_eval.c:1.6 Mon May 31 08:56:36 2010
+++ rtems/cpukit/libfs/src/devfs/devfs_eval.c Fri Aug 27 12:32:59 2010
</font><font color='#997700'>@@ -40,10 +40,8 @@
</font> rtems_device_name_t *device_name_table;
/* see if 'flags' is valid */
<font color='#880000'>- if ( !rtems_libio_is_valid_perms( flags ) ) {
- assert( 0 );
- rtems_set_errno_and_return_minus_one( EIO );
- }
</font><font color='#000088'>+ if ( !rtems_libio_is_valid_perms( flags ) )
+ rtems_set_errno_and_return_minus_one( EPERM );
</font>
/* get the device name table */
device_name_table = (rtems_device_name_t *)pathloc->node_access;
<font color='#006600'>diff -u rtems/cpukit/libfs/src/devfs/devfs_eval.c:1.6 rtems/cpukit/libfs/src/devfs/devfs_eval.c:1.6.2.1
--- rtems/cpukit/libfs/src/devfs/devfs_eval.c:1.6 Mon May 31 08:56:36 2010
+++ rtems/cpukit/libfs/src/devfs/devfs_eval.c Fri Aug 27 12:33:11 2010
</font><font color='#997700'>@@ -40,10 +40,8 @@
</font> rtems_device_name_t *device_name_table;
/* see if 'flags' is valid */
<font color='#880000'>- if ( !rtems_libio_is_valid_perms( flags ) ) {
- assert( 0 );
- rtems_set_errno_and_return_minus_one( EIO );
- }
</font><font color='#000088'>+ if ( !rtems_libio_is_valid_perms( flags ) )
+ rtems_set_errno_and_return_minus_one( EPERM );
</font>
/* get the device name table */
device_name_table = (rtems_device_name_t *)pathloc->node_access;
<font color='#006600'>diff -u rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.30 rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.31
--- rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.30 Thu Aug 12 23:49:31 2010
+++ rtems/cpukit/libfs/src/imfs/imfs_eval.c Fri Aug 27 12:32:59 2010
</font><font color='#997700'>@@ -80,9 +80,8 @@
</font> IMFS_jnode_t *jnode;
int flags_to_test;
<font color='#880000'>- if ( !rtems_libio_is_valid_perms( flags ) ) {
- rtems_set_errno_and_return_minus_one( EIO );
- }
</font><font color='#000088'>+ if ( !rtems_libio_is_valid_perms( flags ) )
+ rtems_set_errno_and_return_minus_one( EPERM );
</font>
jnode = node->node_access;
<font color='#006600'>diff -u rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.26 rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.26.2.1
--- rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.26 Mon May 31 08:56:36 2010
+++ rtems/cpukit/libfs/src/imfs/imfs_eval.c Fri Aug 27 12:33:11 2010
</font><font color='#997700'>@@ -82,10 +82,8 @@
</font> IMFS_jnode_t *jnode;
int flags_to_test;
<font color='#880000'>- if ( !rtems_libio_is_valid_perms( flags ) ) {
- assert( 0 );
- rtems_set_errno_and_return_minus_one( EIO );
- }
</font><font color='#000088'>+ if ( !rtems_libio_is_valid_perms( flags ) )
+ rtems_set_errno_and_return_minus_one( EPERM );
</font>
jnode = node->node_access;
</pre>
<p> </p>
<a name='cs2'></a>
<table border='0' cellspacing='0' cellpadding='5' width='100%' bgcolor='#eeeeee'>
<tr><td colspan='3' bgcolor='#dddddd'>
<font color='#bb2222'><strong>joel</strong></font>
<font color='#225522'><em>(on branch rtems-4-9-branch)</em></font>
</td></tr>
<tr><td colspan='3' bgcolor='#dddddd'><pre>2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
PR 1692/filesystem
* libcsupport/include/rtems/libio.h, libfs/src/imfs/imfs_eval.c: Fix
implementation and use of rtems_libio_is_valid_perms().
</pre></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/ChangeLog.diff?r1=text&tr1=1.696.2.107&r2=text&tr2=1.696.2.108&diff_format=h">M</a></td><td width='1%'>1.696.2.108</td><td width='100%'>cpukit/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/ChangeLog.diff?r1=text&tr1=1.1080.2.59&r2=text&tr2=1.1080.2.60&diff_format=h">M</a></td><td width='1%'>1.1080.2.60</td><td width='100%'>cpukit/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/ChangeLog.diff?r1=text&tr1=1.1539.2.65&r2=text&tr2=1.1539.2.66&diff_format=h">M</a></td><td width='1%'>1.1539.2.66</td><td width='100%'>cpukit/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libcsupport/include/rtems/libio.h.diff?r1=text&tr1=1.49.2.1&r2=text&tr2=1.49.2.2&diff_format=h">M</a></td><td width='1%'>1.49.2.2</td><td width='100%'>cpukit/libcsupport/include/rtems/libio.h</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libcsupport/include/rtems/libio.h.diff?r1=text&tr1=1.50.2.1&r2=text&tr2=1.50.2.2&diff_format=h">M</a></td><td width='1%'>1.50.2.2</td><td width='100%'>cpukit/libcsupport/include/rtems/libio.h</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libcsupport/include/rtems/libio.h.diff?r1=text&tr1=1.53.2.1&r2=text&tr2=1.53.2.2&diff_format=h">M</a></td><td width='1%'>1.53.2.2</td><td width='100%'>cpukit/libcsupport/include/rtems/libio.h</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libfs/src/imfs/imfs_eval.c.diff?r1=text&tr1=1.19&r2=text&tr2=1.19.4.1&diff_format=h">M</a></td><td width='1%'>1.19.4.1</td><td width='100%'>cpukit/libfs/src/imfs/imfs_eval.c</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libfs/src/imfs/imfs_eval.c.diff?r1=text&tr1=1.19&r2=text&tr2=1.19.2.1&diff_format=h">M</a></td><td width='1%'>1.19.2.1</td><td width='100%'>cpukit/libfs/src/imfs/imfs_eval.c</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libfs/src/imfs/imfs_eval.c.diff?r1=text&tr1=1.20&r2=text&tr2=1.20.2.1&diff_format=h">M</a></td><td width='1%'>1.20.2.1</td><td width='100%'>cpukit/libfs/src/imfs/imfs_eval.c</td></tr>
</table>
<pre>
<font color='#006600'>diff -u rtems/cpukit/ChangeLog:1.696.2.107 rtems/cpukit/ChangeLog:1.696.2.108
--- rtems/cpukit/ChangeLog:1.696.2.107 Mon Jun 21 11:38:55 2010
+++ rtems/cpukit/ChangeLog Fri Aug 27 12:33:40 2010
</font><font color='#997700'>@@ -1,3 +1,9 @@
</font><font color='#000088'>+2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
+
+ PR 1692/filesystem
+ * libcsupport/include/rtems/libio.h, libfs/src/imfs/imfs_eval.c: Fix
+ implementation and use of rtems_libio_is_valid_perms().
+
</font> 2010-06-21 Peter Dufault <dufault@hda.com>
PR 1570/cpukit
<font color='#006600'>diff -u rtems/cpukit/ChangeLog:1.1080.2.59 rtems/cpukit/ChangeLog:1.1080.2.60
--- rtems/cpukit/ChangeLog:1.1080.2.59 Mon Jun 21 11:38:46 2010
+++ rtems/cpukit/ChangeLog Fri Aug 27 12:33:28 2010
</font><font color='#997700'>@@ -1,3 +1,9 @@
</font><font color='#000088'>+2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
+
+ PR 1692/filesystem
+ * libcsupport/include/rtems/libio.h, libfs/src/imfs/imfs_eval.c: Fix
+ implementation and use of rtems_libio_is_valid_perms().
+
</font> 2010-06-21 Peter Dufault <dufault@hda.com>
PR 1570/cpukit
<font color='#006600'>diff -u rtems/cpukit/ChangeLog:1.1539.2.65 rtems/cpukit/ChangeLog:1.1539.2.66
--- rtems/cpukit/ChangeLog:1.1539.2.65 Mon Jun 21 11:38:39 2010
+++ rtems/cpukit/ChangeLog Fri Aug 27 12:33:21 2010
</font><font color='#997700'>@@ -1,3 +1,9 @@
</font><font color='#000088'>+2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
+
+ PR 1692/filesystem
+ * libcsupport/include/rtems/libio.h, libfs/src/imfs/imfs_eval.c: Fix
+ implementation and use of rtems_libio_is_valid_perms().
+
</font> 2010-06-21 Peter Dufault <dufault@hda.com>
PR 1570/cpukit
<font color='#006600'>diff -u rtems/cpukit/libcsupport/include/rtems/libio.h:1.49.2.1 rtems/cpukit/libcsupport/include/rtems/libio.h:1.49.2.2
--- rtems/cpukit/libcsupport/include/rtems/libio.h:1.49.2.1 Fri Dec 8 01:23:00 2006
+++ rtems/cpukit/libcsupport/include/rtems/libio.h Fri Aug 27 12:33:42 2010
</font><font color='#997700'>@@ -529,7 +529,7 @@
</font> * Verifies that the permission flag is valid.
*/
#define rtems_libio_is_valid_perms( _perm ) \
<font color='#880000'>- (~ ((~RTEMS_LIBIO_PERMS_RWX) & _perm ))
</font><font color='#000088'>+ (((~RTEMS_LIBIO_PERMS_RWX) & _perm ) == 0)
</font>
/*
<font color='#006600'>diff -u rtems/cpukit/libcsupport/include/rtems/libio.h:1.50.2.1 rtems/cpukit/libcsupport/include/rtems/libio.h:1.50.2.2
--- rtems/cpukit/libcsupport/include/rtems/libio.h:1.50.2.1 Mon Mar 9 09:13:44 2009
+++ rtems/cpukit/libcsupport/include/rtems/libio.h Fri Aug 27 12:33:30 2010
</font><font color='#997700'>@@ -529,8 +529,7 @@
</font> * Verifies that the permission flag is valid.
*/
#define rtems_libio_is_valid_perms( _perm ) \
<font color='#880000'>- (~ ((~RTEMS_LIBIO_PERMS_RWX) & _perm ))
-
</font><font color='#000088'>+ (((~RTEMS_LIBIO_PERMS_RWX) & _perm ) == 0)
</font>
/*
* Prototypes for filesystem
<font color='#006600'>diff -u rtems/cpukit/libcsupport/include/rtems/libio.h:1.53.2.1 rtems/cpukit/libcsupport/include/rtems/libio.h:1.53.2.2
--- rtems/cpukit/libcsupport/include/rtems/libio.h:1.53.2.1 Mon Mar 9 09:12:57 2009
+++ rtems/cpukit/libcsupport/include/rtems/libio.h Fri Aug 27 12:33:22 2010
</font><font color='#997700'>@@ -530,7 +530,7 @@
</font> * Verifies that the permission flag is valid.
*/
#define rtems_libio_is_valid_perms( _perm ) \
<font color='#880000'>- (~ ((~RTEMS_LIBIO_PERMS_RWX) & _perm ))
</font><font color='#000088'>+ (((~RTEMS_LIBIO_PERMS_RWX) & _perm ) == 0)
</font>
/*
<font color='#006600'>diff -u rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.19 rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.19.4.1
--- rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.19 Tue Feb 8 11:12:54 2005
+++ rtems/cpukit/libfs/src/imfs/imfs_eval.c Fri Aug 27 12:33:30 2010
</font><font color='#997700'>@@ -79,10 +79,8 @@
</font> IMFS_jnode_t *jnode;
int flags_to_test;
<font color='#880000'>- if ( !rtems_libio_is_valid_perms( flags ) ) {
- assert( 0 );
- rtems_set_errno_and_return_minus_one( EIO );
- }
</font><font color='#000088'>+ if ( !rtems_libio_is_valid_perms( flags ) )
+ rtems_set_errno_and_return_minus_one( EPERM );
</font>
jnode = node->node_access;
<font color='#006600'>diff -u rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.19 rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.19.2.1
--- rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.19 Tue Feb 8 11:12:54 2005
+++ rtems/cpukit/libfs/src/imfs/imfs_eval.c Fri Aug 27 12:33:42 2010
</font><font color='#997700'>@@ -79,10 +79,8 @@
</font> IMFS_jnode_t *jnode;
int flags_to_test;
<font color='#880000'>- if ( !rtems_libio_is_valid_perms( flags ) ) {
- assert( 0 );
- rtems_set_errno_and_return_minus_one( EIO );
- }
</font><font color='#000088'>+ if ( !rtems_libio_is_valid_perms( flags ) )
+ rtems_set_errno_and_return_minus_one( EPERM );
</font>
jnode = node->node_access;
<font color='#006600'>diff -u rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.20 rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.20.2.1
--- rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.20 Thu Sep 4 03:16:49 2008
+++ rtems/cpukit/libfs/src/imfs/imfs_eval.c Fri Aug 27 12:33:23 2010
</font><font color='#997700'>@@ -79,10 +79,8 @@
</font> IMFS_jnode_t *jnode;
int flags_to_test;
<font color='#880000'>- if ( !rtems_libio_is_valid_perms( flags ) ) {
- assert( 0 );
- rtems_set_errno_and_return_minus_one( EIO );
- }
</font><font color='#000088'>+ if ( !rtems_libio_is_valid_perms( flags ) )
+ rtems_set_errno_and_return_minus_one( EPERM );
</font>
jnode = node->node_access;
</pre>
<p> </p>
<a name='cs3'></a>
<table border='0' cellspacing='0' cellpadding='5' width='100%' bgcolor='#eeeeee'>
<tr><td colspan='3' bgcolor='#dddddd'>
<font color='#bb2222'><strong>joel</strong></font>
<font color='#225522'><em>(on branch rtems-4-10-branch)</em></font>
</td></tr>
<tr><td colspan='3' bgcolor='#dddddd'><pre>2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
PR 1693/filesystem
* libfs/src/imfs/memfile.c: IMFS_memfile_get_block_pointer() was
checking incorrect pointer and thus had dead code.
</pre></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/ChangeLog.diff?r1=text&tr1=1.2612&r2=text&tr2=1.2613&diff_format=h">M</a></td><td width='1%'>1.2613</td><td width='100%'>cpukit/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/ChangeLog.diff?r1=text&tr1=1.696.2.108&r2=text&tr2=1.696.2.109&diff_format=h">M</a></td><td width='1%'>1.696.2.109</td><td width='100%'>cpukit/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/ChangeLog.diff?r1=text&tr1=1.1080.2.60&r2=text&tr2=1.1080.2.61&diff_format=h">M</a></td><td width='1%'>1.1080.2.61</td><td width='100%'>cpukit/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/ChangeLog.diff?r1=text&tr1=1.1539.2.66&r2=text&tr2=1.1539.2.67&diff_format=h">M</a></td><td width='1%'>1.1539.2.67</td><td width='100%'>cpukit/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/ChangeLog.diff?r1=text&tr1=1.2346.2.64&r2=text&tr2=1.2346.2.65&diff_format=h">M</a></td><td width='1%'>1.2346.2.65</td><td width='100%'>cpukit/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libfs/src/imfs/memfile.c.diff?r1=text&tr1=1.38&r2=text&tr2=1.39&diff_format=h">M</a></td><td width='1%'>1.39</td><td width='100%'>cpukit/libfs/src/imfs/memfile.c</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libfs/src/imfs/memfile.c.diff?r1=text&tr1=1.25.2.1&r2=text&tr2=1.25.2.2&diff_format=h">M</a></td><td width='1%'>1.25.2.2</td><td width='100%'>cpukit/libfs/src/imfs/memfile.c</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libfs/src/imfs/memfile.c.diff?r1=text&tr1=1.26.2.1&r2=text&tr2=1.26.2.2&diff_format=h">M</a></td><td width='1%'>1.26.2.2</td><td width='100%'>cpukit/libfs/src/imfs/memfile.c</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libfs/src/imfs/memfile.c.diff?r1=text&tr1=1.27.2.1&r2=text&tr2=1.27.2.2&diff_format=h">M</a></td><td width='1%'>1.27.2.2</td><td width='100%'>cpukit/libfs/src/imfs/memfile.c</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libfs/src/imfs/memfile.c.diff?r1=text&tr1=1.32&r2=text&tr2=1.32.2.1&diff_format=h">M</a></td><td width='1%'>1.32.2.1</td><td width='100%'>cpukit/libfs/src/imfs/memfile.c</td></tr>
</table>
<pre>
<font color='#006600'>diff -u rtems/cpukit/ChangeLog:1.2612 rtems/cpukit/ChangeLog:1.2613
--- rtems/cpukit/ChangeLog:1.2612 Fri Aug 27 12:32:59 2010
+++ rtems/cpukit/ChangeLog Fri Aug 27 12:43:26 2010
</font><font color='#997700'>@@ -1,5 +1,11 @@
</font> 2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
<font color='#000088'>+ PR 1693/filesystem
+ * libfs/src/imfs/memfile.c: IMFS_memfile_get_block_pointer() was
+ checking incorrect pointer and thus had dead code.
+
+2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
+
</font> PR 1692/filesystem
* libcsupport/include/rtems/libio.h, libfs/src/devfs/devfs_eval.c,
libfs/src/imfs/imfs_eval.c: Fix implementation and use of
<font color='#006600'>diff -u rtems/cpukit/ChangeLog:1.696.2.108 rtems/cpukit/ChangeLog:1.696.2.109
--- rtems/cpukit/ChangeLog:1.696.2.108 Fri Aug 27 12:33:40 2010
+++ rtems/cpukit/ChangeLog Fri Aug 27 12:42:39 2010
</font><font color='#997700'>@@ -1,5 +1,11 @@
</font> 2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
<font color='#000088'>+ PR 1693/filesystem
+ * libfs/src/imfs/memfile.c: IMFS_memfile_get_block_pointer() was
+ checking incorrect pointer and thus had dead code.
+
+2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
+
</font> PR 1692/filesystem
* libcsupport/include/rtems/libio.h, libfs/src/imfs/imfs_eval.c: Fix
implementation and use of rtems_libio_is_valid_perms().
<font color='#006600'>diff -u rtems/cpukit/ChangeLog:1.1080.2.60 rtems/cpukit/ChangeLog:1.1080.2.61
--- rtems/cpukit/ChangeLog:1.1080.2.60 Fri Aug 27 12:33:28 2010
+++ rtems/cpukit/ChangeLog Fri Aug 27 12:42:50 2010
</font><font color='#997700'>@@ -1,5 +1,11 @@
</font> 2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
<font color='#000088'>+ PR 1693/filesystem
+ * libfs/src/imfs/memfile.c: IMFS_memfile_get_block_pointer() was
+ checking incorrect pointer and thus had dead code.
+
+2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
+
</font> PR 1692/filesystem
* libcsupport/include/rtems/libio.h, libfs/src/imfs/imfs_eval.c: Fix
implementation and use of rtems_libio_is_valid_perms().
<font color='#006600'>diff -u rtems/cpukit/ChangeLog:1.1539.2.66 rtems/cpukit/ChangeLog:1.1539.2.67
--- rtems/cpukit/ChangeLog:1.1539.2.66 Fri Aug 27 12:33:21 2010
+++ rtems/cpukit/ChangeLog Fri Aug 27 12:42:59 2010
</font><font color='#997700'>@@ -1,5 +1,11 @@
</font> 2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
<font color='#000088'>+ PR 1693/filesystem
+ * libfs/src/imfs/memfile.c: IMFS_memfile_get_block_pointer() was
+ checking incorrect pointer and thus had dead code.
+
+2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
+
</font> PR 1692/filesystem
* libcsupport/include/rtems/libio.h, libfs/src/imfs/imfs_eval.c: Fix
implementation and use of rtems_libio_is_valid_perms().
<font color='#006600'>diff -u rtems/cpukit/ChangeLog:1.2346.2.64 rtems/cpukit/ChangeLog:1.2346.2.65
--- rtems/cpukit/ChangeLog:1.2346.2.64 Fri Aug 27 12:33:09 2010
+++ rtems/cpukit/ChangeLog Fri Aug 27 12:43:18 2010
</font><font color='#997700'>@@ -1,5 +1,11 @@
</font> 2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
<font color='#000088'>+ PR 1693/filesystem
+ * libfs/src/imfs/memfile.c: IMFS_memfile_get_block_pointer() was
+ checking incorrect pointer and thus had dead code.
+
+2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
+
</font> PR 1692/filesystem
* libcsupport/include/rtems/libio.h, libfs/src/devfs/devfs_eval.c,
libfs/src/imfs/imfs_eval.c: Fix implementation and use of
<font color='#006600'>diff -u rtems/cpukit/libfs/src/imfs/memfile.c:1.38 rtems/cpukit/libfs/src/imfs/memfile.c:1.39
--- rtems/cpukit/libfs/src/imfs/memfile.c:1.38 Fri Jul 30 17:36:32 2010
+++ rtems/cpukit/libfs/src/imfs/memfile.c Fri Aug 27 12:43:26 2010
</font><font color='#997700'>@@ -931,7 +931,7 @@
</font> return 0;
p2 = (block_p *)p1[ doubly ];
<font color='#880000'>- if ( !p )
</font><font color='#000088'>+ if ( !p2 )
</font> return 0;
return (block_p *)&p2[ singly ];
<font color='#006600'>diff -u rtems/cpukit/libfs/src/imfs/memfile.c:1.25.2.1 rtems/cpukit/libfs/src/imfs/memfile.c:1.25.2.2
--- rtems/cpukit/libfs/src/imfs/memfile.c:1.25.2.1 Fri Dec 8 01:23:00 2006
+++ rtems/cpukit/libfs/src/imfs/memfile.c Fri Aug 27 12:42:40 2010
</font><font color='#997700'>@@ -1046,7 +1046,7 @@
</font> return 0;
p2 = (block_p *)p1[ doubly ];
<font color='#880000'>- if ( !p )
</font><font color='#000088'>+ if ( !p2 )
</font> return 0;
return (block_p *)&p2[ singly ];
<font color='#006600'>diff -u rtems/cpukit/libfs/src/imfs/memfile.c:1.26.2.1 rtems/cpukit/libfs/src/imfs/memfile.c:1.26.2.2
--- rtems/cpukit/libfs/src/imfs/memfile.c:1.26.2.1 Mon Mar 9 09:13:44 2009
+++ rtems/cpukit/libfs/src/imfs/memfile.c Fri Aug 27 12:42:52 2010
</font><font color='#997700'>@@ -1046,7 +1046,7 @@
</font> return 0;
p2 = (block_p *)p1[ doubly ];
<font color='#880000'>- if ( !p )
</font><font color='#000088'>+ if ( !p2 )
</font> return 0;
return (block_p *)&p2[ singly ];
<font color='#006600'>diff -u rtems/cpukit/libfs/src/imfs/memfile.c:1.27.2.1 rtems/cpukit/libfs/src/imfs/memfile.c:1.27.2.2
--- rtems/cpukit/libfs/src/imfs/memfile.c:1.27.2.1 Mon Mar 9 09:12:58 2009
+++ rtems/cpukit/libfs/src/imfs/memfile.c Fri Aug 27 12:43:01 2010
</font><font color='#997700'>@@ -1046,7 +1046,7 @@
</font> return 0;
p2 = (block_p *)p1[ doubly ];
<font color='#880000'>- if ( !p )
</font><font color='#000088'>+ if ( !p2 )
</font> return 0;
return (block_p *)&p2[ singly ];
<font color='#006600'>diff -u rtems/cpukit/libfs/src/imfs/memfile.c:1.32 rtems/cpukit/libfs/src/imfs/memfile.c:1.32.2.1
--- rtems/cpukit/libfs/src/imfs/memfile.c:1.32 Mon Jan 18 19:55:28 2010
+++ rtems/cpukit/libfs/src/imfs/memfile.c Fri Aug 27 12:43:18 2010
</font><font color='#997700'>@@ -1048,7 +1048,7 @@
</font> return 0;
p2 = (block_p *)p1[ doubly ];
<font color='#880000'>- if ( !p )
</font><font color='#000088'>+ if ( !p2 )
</font> return 0;
return (block_p *)&p2[ singly ];
</pre>
<p> </p>
<a name='cs4'></a>
<table border='0' cellspacing='0' cellpadding='5' width='100%' bgcolor='#eeeeee'>
<tr><td colspan='3' bgcolor='#dddddd'>
<font color='#bb2222'><strong>joel</strong></font>
</td></tr>
<tr><td colspan='3' bgcolor='#dddddd'><pre>2010-08-27 Joel Sherrill <joel.sherrill@oarcorp.com>
* libmisc/shell/main_date.c: Use snprintf() not sprintf().
</pre></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/ChangeLog.diff?r1=text&tr1=1.2613&r2=text&tr2=1.2614&diff_format=h">M</a></td><td width='1%'>1.2614</td><td width='100%'>cpukit/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libmisc/shell/main_date.c.diff?r1=text&tr1=1.6&r2=text&tr2=1.7&diff_format=h">M</a></td><td width='1%'>1.7</td><td width='100%'>cpukit/libmisc/shell/main_date.c</td></tr>
</table>
<pre>
<font color='#006600'>diff -u rtems/cpukit/ChangeLog:1.2613 rtems/cpukit/ChangeLog:1.2614
--- rtems/cpukit/ChangeLog:1.2613 Fri Aug 27 12:43:26 2010
+++ rtems/cpukit/ChangeLog Fri Aug 27 13:04:28 2010
</font><font color='#997700'>@@ -1,3 +1,7 @@
</font><font color='#000088'>+2010-08-27 Joel Sherrill <joel.sherrill@oarcorp.com>
+
+ * libmisc/shell/main_date.c: Use snprintf() not sprintf().
+
</font> 2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
PR 1693/filesystem
<font color='#006600'>diff -u rtems/cpukit/libmisc/shell/main_date.c:1.6 rtems/cpukit/libmisc/shell/main_date.c:1.7
--- rtems/cpukit/libmisc/shell/main_date.c:1.6 Sun Nov 29 06:12:39 2009
+++ rtems/cpukit/libmisc/shell/main_date.c Fri Aug 27 13:04:28 2010
</font><font color='#997700'>@@ -52,7 +52,7 @@
</font> struct timespec timesp;
char *result;
<font color='#880000'>- sprintf( buf, "%s %s", argv[1], argv[2] );
</font><font color='#000088'>+ snprintf( buf, sizeof(buf), "%s %s", argv[1], argv[2] );
</font> result = strptime(
buf,
"%Y-%m-%d %T",
</pre>
<p> </p>
<a name='cs5'></a>
<table border='0' cellspacing='0' cellpadding='5' width='100%' bgcolor='#eeeeee'>
<tr><td colspan='3' bgcolor='#dddddd'>
<font color='#bb2222'><strong>joel</strong></font>
</td></tr>
<tr><td colspan='3' bgcolor='#dddddd'><pre>2010-08-27 Joel Sherrill <joel.sherrill@oarcorp.com>
* libcsupport/src/ctermid.c: Add comment explaining that this use of
strcpy() is a potential buffer overrun but because the API does not
provide a way to know the length of the user provided buffer, there
is nothing we can do about it.
</pre></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/ChangeLog.diff?r1=text&tr1=1.2614&r2=text&tr2=1.2615&diff_format=h">M</a></td><td width='1%'>1.2615</td><td width='100%'>cpukit/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libcsupport/src/ctermid.c.diff?r1=text&tr1=1.6&r2=text&tr2=1.7&diff_format=h">M</a></td><td width='1%'>1.7</td><td width='100%'>cpukit/libcsupport/src/ctermid.c</td></tr>
</table>
<pre>
<font color='#006600'>diff -u rtems/cpukit/ChangeLog:1.2614 rtems/cpukit/ChangeLog:1.2615
--- rtems/cpukit/ChangeLog:1.2614 Fri Aug 27 13:04:28 2010
+++ rtems/cpukit/ChangeLog Fri Aug 27 13:06:46 2010
</font><font color='#997700'>@@ -1,5 +1,12 @@
</font> 2010-08-27 Joel Sherrill <joel.sherrill@oarcorp.com>
<font color='#000088'>+ * libcsupport/src/ctermid.c: Add comment explaining that this use of
+ strcpy() is a potential buffer overrun but because the API does not
+ provide a way to know the length of the user provided buffer, there
+ is nothing we can do about it.
+
+2010-08-27 Joel Sherrill <joel.sherrill@oarcorp.com>
+
</font> * libmisc/shell/main_date.c: Use snprintf() not sprintf().
2010-08-27 Joel Sherrill <joel.sherrilL@OARcorp.com>
<font color='#006600'>diff -u rtems/cpukit/libcsupport/src/ctermid.c:1.6 rtems/cpukit/libcsupport/src/ctermid.c:1.7
--- rtems/cpukit/libcsupport/src/ctermid.c:1.6 Thu Sep 4 13:54:13 2003
+++ rtems/cpukit/libcsupport/src/ctermid.c Fri Aug 27 13:06:46 2010
</font><font color='#997700'>@@ -30,6 +30,11 @@
</font> if ( !s )
return ctermid_name;
<font color='#000088'>+ /*
+ * We have no way of knowing the length of the user provided buffer.
+ * It may not be large enough but there is no way to know that. :(
+ * So this is a potential buffer owerrun that we can do nothing about.
+ */
</font> strcpy( s, ctermid_name );
return s;
}
</pre>
<p> </p>
<a name='cs6'></a>
<table border='0' cellspacing='0' cellpadding='5' width='100%' bgcolor='#eeeeee'>
<tr><td colspan='3' bgcolor='#dddddd'>
<font color='#bb2222'><strong>joel</strong></font>
</td></tr>
<tr><td colspan='3' bgcolor='#dddddd'><pre>Update date.
</pre></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libcsupport/src/ctermid.c.diff?r1=text&tr1=1.7&r2=text&tr2=1.8&diff_format=h">M</a></td><td width='1%'>1.8</td><td width='100%'>cpukit/libcsupport/src/ctermid.c</td></tr>
</table>
<pre>
<font color='#006600'>diff -u rtems/cpukit/libcsupport/src/ctermid.c:1.7 rtems/cpukit/libcsupport/src/ctermid.c:1.8
--- rtems/cpukit/libcsupport/src/ctermid.c:1.7 Fri Aug 27 13:06:46 2010
+++ rtems/cpukit/libcsupport/src/ctermid.c Fri Aug 27 13:07:03 2010
</font><font color='#997700'>@@ -1,7 +1,7 @@
</font> /*
* ctermid() - POSIX 1003.1b 4.7.1 - Generate Terminal Pathname
*
<font color='#880000'>- * COPYRIGHT (c) 1989-1999.
</font><font color='#000088'>+ * COPYRIGHT (c) 1989-2010.
</font> * On-Line Applications Research Corporation (OAR).
*
* The license and distribution terms for this file may be
</pre>
<p> </p>
<p>--<br />
<small>Generated by <a href="http://www.codewiz.org/projects/index.html#loginfo">Deluxe Loginfo</a> 2.122 by Bernardo Innocenti <bernie@develer.com></small></p>
</body>
</html>