<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>change log for rtems (2010-08-28)</title>
</head>
<body text='#000000' bgcolor='#ffffff'>
<a name='cs1'></a>
<table border='0' cellspacing='0' cellpadding='5' width='100%' bgcolor='#eeeeee'>
<tr><td colspan='3' bgcolor='#dddddd'>
<font color='#bb2222'><strong>joel</strong></font>
</td></tr>
<tr><td colspan='3' bgcolor='#dddddd'><pre>2010-08-28 Joel Sherrill <joel.sherrilL@OARcorp.com>
* libfs/src/pipe/pipe.c: Remove unreachable line flagged by Coverity as
dead code.
</pre></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/ChangeLog.diff?r1=text&tr1=1.2615&r2=text&tr2=1.2616&diff_format=h">M</a></td><td width='1%'>1.2616</td><td width='100%'>cpukit/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libfs/src/pipe/pipe.c.diff?r1=text&tr1=1.7&r2=text&tr2=1.8&diff_format=h">M</a></td><td width='1%'>1.8</td><td width='100%'>cpukit/libfs/src/pipe/pipe.c</td></tr>
</table>
<pre>
<font color='#006600'>diff -u rtems/cpukit/ChangeLog:1.2615 rtems/cpukit/ChangeLog:1.2616
--- rtems/cpukit/ChangeLog:1.2615 Fri Aug 27 13:06:46 2010
+++ rtems/cpukit/ChangeLog Sat Aug 28 14:48:41 2010
</font><font color='#997700'>@@ -1,3 +1,8 @@
</font><font color='#000088'>+2010-08-28 Joel Sherrill <joel.sherrilL@OARcorp.com>
+
+ * libfs/src/pipe/pipe.c: Remove unreachable line flagged by Coverity as
+ dead code.
+
</font> 2010-08-27 Joel Sherrill <joel.sherrill@oarcorp.com>
* libcsupport/src/ctermid.c: Add comment explaining that this use of
<font color='#006600'>diff -u rtems/cpukit/libfs/src/pipe/pipe.c:1.7 rtems/cpukit/libfs/src/pipe/pipe.c:1.8
--- rtems/cpukit/libfs/src/pipe/pipe.c:1.7 Fri Jul 9 13:39:36 2010
+++ rtems/cpukit/libfs/src/pipe/pipe.c Sat Aug 28 14:48:41 2010
</font><font color='#997700'>@@ -48,7 +48,6 @@
</font> }
/* Just try once... */
return -1;
<font color='#880000'>- sprintf(fifopath + 10, "%04x", rtems_pipe_no ++);
</font> }
/* Non-blocking open to avoid waiting for writers */
</pre>
<p> </p>
<a name='cs2'></a>
<table border='0' cellspacing='0' cellpadding='5' width='100%' bgcolor='#eeeeee'>
<tr><td colspan='3' bgcolor='#dddddd'>
<font color='#bb2222'><strong>joel</strong></font>
</td></tr>
<tr><td colspan='3' bgcolor='#dddddd'><pre>Just comment out line.
</pre></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libfs/src/pipe/pipe.c.diff?r1=text&tr1=1.8&r2=text&tr2=1.9&diff_format=h">M</a></td><td width='1%'>1.9</td><td width='100%'>cpukit/libfs/src/pipe/pipe.c</td></tr>
</table>
<pre>
<font color='#006600'>diff -u rtems/cpukit/libfs/src/pipe/pipe.c:1.8 rtems/cpukit/libfs/src/pipe/pipe.c:1.9
--- rtems/cpukit/libfs/src/pipe/pipe.c:1.8 Sat Aug 28 14:48:41 2010
+++ rtems/cpukit/libfs/src/pipe/pipe.c Sat Aug 28 14:49:47 2010
</font><font color='#997700'>@@ -48,6 +48,7 @@
</font> }
/* Just try once... */
return -1;
<font color='#000088'>+ /* sprintf(fifopath + 10, "%04x", rtems_pipe_no ++); */
</font> }
/* Non-blocking open to avoid waiting for writers */
</pre>
<p> </p>
<a name='cs3'></a>
<table border='0' cellspacing='0' cellpadding='5' width='100%' bgcolor='#eeeeee'>
<tr><td colspan='3' bgcolor='#dddddd'>
<font color='#bb2222'><strong>joel</strong></font>
</td></tr>
<tr><td colspan='3' bgcolor='#dddddd'><pre>2010-08-28 Joel Sherrill <joel.sherrill@oarcorp.com>
PR 1694/shell
* libmisc/shell/main_setenv.c: Address memory leak identified by
Coverity.
</pre></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/ChangeLog.diff?r1=text&tr1=1.2616&r2=text&tr2=1.2617&diff_format=h">M</a></td><td width='1%'>1.2617</td><td width='100%'>cpukit/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libmisc/shell/main_setenv.c.diff?r1=text&tr1=1.2&r2=text&tr2=1.3&diff_format=h">M</a></td><td width='1%'>1.3</td><td width='100%'>cpukit/libmisc/shell/main_setenv.c</td></tr>
</table>
<pre>
<font color='#006600'>diff -u rtems/cpukit/ChangeLog:1.2616 rtems/cpukit/ChangeLog:1.2617
--- rtems/cpukit/ChangeLog:1.2616 Sat Aug 28 14:48:41 2010
+++ rtems/cpukit/ChangeLog Sat Aug 28 15:10:00 2010
</font><font color='#997700'>@@ -1,3 +1,9 @@
</font><font color='#000088'>+2010-08-28 Joel Sherrill <joel.sherrill@oarcorp.com>
+
+ PR 1694/shell
+ * libmisc/shell/main_setenv.c: Address memory leak identified by
+ Coverity.
+
</font> 2010-08-28 Joel Sherrill <joel.sherrilL@OARcorp.com>
* libfs/src/pipe/pipe.c: Remove unreachable line flagged by Coverity as
<font color='#006600'>diff -u rtems/cpukit/libmisc/shell/main_setenv.c:1.2 rtems/cpukit/libmisc/shell/main_setenv.c:1.3
--- rtems/cpukit/libmisc/shell/main_setenv.c:1.2 Sun Nov 29 06:12:39 2009
+++ rtems/cpukit/libmisc/shell/main_setenv.c Sat Aug 28 15:10:00 2010
</font><font color='#997700'>@@ -24,44 +24,41 @@
</font> int arg;
char* p;
<font color='#880000'>- if (argc <= 2)
- {
- printf ("error: no variable or string\n");
</font><font color='#000088'>+ if (argc <= 2) {
+ printf("error: no variable or string\n");
</font> return 1;
}
env = argv[1];
for (arg = 2; arg < argc; arg++)
<font color='#880000'>- len += strlen (argv[arg]);
</font><font color='#000088'>+ len += strlen(argv[arg]);
</font>
len += argc - 2 - 1;
<font color='#880000'>- string = malloc (len + 1);
</font><font color='#000088'>+ string = malloc(len + 1);
</font>
<font color='#880000'>- if (!string)
- {
- printf ("error: no memory\n");
</font><font color='#000088'>+ if (!string) {
+ printf("error: no memory\n");
</font> return 1;
}
<font color='#880000'>- for (arg = 2, p = string; arg < argc; arg++)
- {
- strcpy (p, argv[arg]);
- p += strlen (argv[arg]);
- if (arg < (argc - 1))
- {
</font><font color='#000088'>+ for (arg = 2, p = string; arg < argc; arg++) {
+ strcpy(p, argv[arg]);
+ p += strlen(argv[arg]);
+ if (arg < (argc - 1)) {
</font> *p = ' ';
p++;
}
}
<font color='#880000'>- if (setenv (env, string, 1) < 0)
- {
- printf ("error: %s\n", strerror (errno));
</font><font color='#000088'>+ if (setenv(env, string, 1) < 0) {
+ printf( "error: %s\n", strerror(errno) );
+ free( string );
</font> return 1;
}
<font color='#000088'>+ free( string );
</font> return 0;
}
</pre>
<p> </p>
<p>--<br />
<small>Generated by <a href="http://www.codewiz.org/projects/index.html#loginfo">Deluxe Loginfo</a> 2.122 by Bernardo Innocenti <bernie@develer.com></small></p>
</body>
</html>