<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>change log for rtems (2010-11-09)</title>
</head>
<body text='#000000' bgcolor='#ffffff'>
<a name='cs1'></a>
<table border='0' cellspacing='0' cellpadding='5' width='100%' bgcolor='#eeeeee'>
<tr><td colspan='3' bgcolor='#dddddd'>
<font color='#bb2222'><strong>sh</strong></font>
</td></tr>
<tr><td colspan='3' bgcolor='#dddddd'><pre>2010-11-09 Sebastian Huber <sebastian.huber@embedded-brains.de>
* score/src/watchdoginsert.c: Removed superfluous cast and use
appropriate API function. This special case handling is obsolete
since 2006 with the introduction of compiler memory barriers in the
interrupt routines. Removed obsolete comments.
</pre></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/ChangeLog.diff?r1=text&tr1=1.2642&r2=text&tr2=1.2643&diff_format=h">M</a></td><td width='1%'>1.2643</td><td width='100%'>cpukit/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/score/src/watchdoginsert.c.diff?r1=text&tr1=1.10&r2=text&tr2=1.11&diff_format=h">M</a></td><td width='1%'>1.11</td><td width='100%'>cpukit/score/src/watchdoginsert.c</td></tr>
</table>
<pre>
<font color='#006600'>diff -u rtems/cpukit/ChangeLog:1.2642 rtems/cpukit/ChangeLog:1.2643
--- rtems/cpukit/ChangeLog:1.2642 Thu Nov 4 18:00:04 2010
+++ rtems/cpukit/ChangeLog Tue Nov 9 03:14:10 2010
</font><font color='#997700'>@@ -1,3 +1,10 @@
</font><font color='#000088'>+2010-11-09 Sebastian Huber <sebastian.huber@embedded-brains.de>
+
+ * score/src/watchdoginsert.c: Removed superfluous cast and use
+ appropriate API function. This special case handling is obsolete
+ since 2006 with the introduction of compiler memory barriers in the
+ interrupt routines. Removed obsolete comments.
+
</font> 2010-11-04 Joel Sherrill <joel.sherrill@oarcorp.com>
* libmisc/stackchk/check.c: Make compile again.
<font color='#006600'>diff -u rtems/cpukit/score/src/watchdoginsert.c:1.10 rtems/cpukit/score/src/watchdoginsert.c:1.11
--- rtems/cpukit/score/src/watchdoginsert.c:1.10 Wed Aug 17 17:49:56 2005
+++ rtems/cpukit/score/src/watchdoginsert.c Tue Nov 9 03:14:10 2010
</font><font color='#997700'>@@ -59,21 +59,7 @@
</font> restart:
delta_interval = the_watchdog->initial;
<font color='#880000'>- /*
- * We CANT use _Watchdog_First() here, because a TICK interrupt
- * could modify the chain during the _ISR_Flash() below. Hence,
- * the header is pointing to volatile data. The _Watchdog_First()
- * INLINE routine (but not the macro - note the subtle difference)
- * casts away the 'volatile'...
- *
- * Also, this is only necessary because we call no other routine
- * from this piece of code, hence the compiler thinks it's safe to
- * cache *header!!
- *
- * Till Straumann, 7/2003 (gcc-3.2.2 -O4 on powerpc)
- *
- */
- for ( after = (Watchdog_Control *) ((volatile Chain_Control *)header)->first ;
</font><font color='#000088'>+ for ( after = _Watchdog_First( header ) ;
</font> ;
after = _Watchdog_Next( after ) ) {
<font color='#997700'>@@ -87,15 +73,6 @@
</font>
delta_interval -= after->delta_interval;
<font color='#880000'>- /*
- * If you experience problems comment out the _ISR_Flash line.
- * 3.2.0 was the first release with this critical section redesigned.
- * Under certain circumstances, the PREVIOUS critical section algorithm
- * used around this flash point allowed interrupts to execute
- * which violated the design assumptions. The critical section
- * mechanism used here WAS redesigned to address this.
- */
-
</font> _ISR_Flash( level );
if ( the_watchdog->state != WATCHDOG_BEING_INSERTED ) {
</pre>
<p> </p>
<p>--<br />
<small>Generated by <a href="http://www.codewiz.org/projects/index.html#loginfo">Deluxe Loginfo</a> 2.122 by Bernardo Innocenti <bernie@develer.com></small></p>
</body>
</html>