<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>change log for rtems (2011-03-15)</title>
</head>
<body text='#000000' bgcolor='#ffffff'>
<a name='cs1'></a>
<table border='0' cellspacing='0' cellpadding='5' width='100%' bgcolor='#eeeeee'>
<tr><td colspan='3' bgcolor='#dddddd'>
<font color='#bb2222'><strong>joel</strong></font>
</td></tr>
<tr><td colspan='3' bgcolor='#dddddd'><pre>2011-03-15 Joel Sherrill <joel.sherrill@oarcorp.com>
* libmisc/shell/main_setenv.c: Revert after discussion. Mark as
intentional in Coverity.
</pre></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/ChangeLog.diff?r1=text&tr1=1.2779&r2=text&tr2=1.2780&diff_format=h">M</a></td><td width='1%'>1.2780</td><td width='100%'>cpukit/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/libmisc/shell/main_setenv.c.diff?r1=text&tr1=1.4&r2=text&tr2=1.5&diff_format=h">M</a></td><td width='1%'>1.5</td><td width='100%'>cpukit/libmisc/shell/main_setenv.c</td></tr>
</table>
<pre>
<font color='#006600'>diff -u rtems/cpukit/ChangeLog:1.2779 rtems/cpukit/ChangeLog:1.2780
--- rtems/cpukit/ChangeLog:1.2779 Tue Mar 15 10:05:28 2011
+++ rtems/cpukit/ChangeLog Tue Mar 15 10:43:09 2011
</font><font color='#997700'>@@ -1,5 +1,10 @@
</font> 2011-03-15 Joel Sherrill <joel.sherrill@oarcorp.com>
<font color='#000088'>+ * libmisc/shell/main_setenv.c: Revert after discussion. Mark as
+ intentional in Coverity.
+
+2011-03-15 Joel Sherrill <joel.sherrill@oarcorp.com>
+
</font> * libfs/src/dosfs/msdos_format.c: Address Coverity issue 183 which was
where an expression evaluated to a constant and issue 185 which was a
potential (although unlikely in expected usage) time-of-check,
<font color='#006600'>diff -u rtems/cpukit/libmisc/shell/main_setenv.c:1.4 rtems/cpukit/libmisc/shell/main_setenv.c:1.5
--- rtems/cpukit/libmisc/shell/main_setenv.c:1.4 Tue Mar 15 10:02:41 2011
+++ rtems/cpukit/libmisc/shell/main_setenv.c Tue Mar 15 10:43:09 2011
</font><font color='#997700'>@@ -16,13 +16,6 @@
</font> #include <rtems/shell.h>
#include "internal.h"
<font color='#880000'>-/*
- * Limit examining or copying more than 256 characters at a time.
- * Yes, this is very arbitrary. If there are POSIX constants, then
- * they should be used.
- */
-#define MAX 156
-
</font> int rtems_shell_main_setenv(int argc, char *argv[])
{
char* env = NULL;
<font color='#997700'>@@ -39,7 +32,7 @@
</font> env = argv[1];
for (arg = 2; arg < argc; arg++)
<font color='#880000'>- len += strnlen(argv[arg], MAX);
</font><font color='#000088'>+ len += strlen(argv[arg]);
</font>
len += argc - 2 - 1;
<font color='#997700'>@@ -51,8 +44,8 @@
</font> }
for (arg = 2, p = string; arg < argc; arg++) {
<font color='#880000'>- strncpy(p, argv[arg], MAX);
- p += strnlen(argv[arg], MAX);
</font><font color='#000088'>+ strcpy(p, argv[arg]);
+ p += strlen(argv[arg]);
</font> if (arg < (argc - 1)) {
*p = ' ';
p++;
</pre>
<p> </p>
<p>--<br />
<small>Generated by <a href="http://www.codewiz.org/projects/index.html#loginfo">Deluxe Loginfo</a> 2.122 by Bernardo Innocenti <bernie@develer.com></small></p>
</body>
</html>