<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>change log for rtems (2011-07-20)</title>
</head>
<body text='#000000' bgcolor='#ffffff'>
<a name='cs1'></a>
<table border='0' cellspacing='0' cellpadding='5' width='100%' bgcolor='#eeeeee'>
<tr><td colspan='3' bgcolor='#dddddd'>
 <font color='#bb2222'><strong>joel</strong></font>
</td></tr>
<tr><td colspan='3' bgcolor='#dddddd'><pre>2011-07-20 Joel Sherrill <joel.sherrill@oarcorp.com>

        * psxtmmutex05/init.c: Fix test. Pattern was wrong.
</pre></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/testsuites/psxtmtests/ChangeLog.diff?r1=text&tr1=1.23&r2=text&tr2=1.24&diff_format=h">M</a></td><td width='1%'>1.24</td><td width='100%'>testsuites/psxtmtests/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/testsuites/psxtmtests/psxtmmutex05/init.c.diff?r1=text&tr1=1.1&r2=text&tr2=1.2&diff_format=h">M</a></td><td width='1%'>1.2</td><td width='100%'>testsuites/psxtmtests/psxtmmutex05/init.c</td></tr>
</table>
<pre>
<font color='#006600'>diff -u rtems/testsuites/psxtmtests/ChangeLog:1.23 rtems/testsuites/psxtmtests/ChangeLog:1.24
--- rtems/testsuites/psxtmtests/ChangeLog:1.23  Wed Jul 20 15:46:48 2011
+++ rtems/testsuites/psxtmtests/ChangeLog       Wed Jul 20 16:30:01 2011
</font><font color='#997700'>@@ -1,5 +1,9 @@
</font> 2011-07-20        Joel Sherrill <joel.sherrill@oarcorp.com>
 
<font color='#000088'>+   * psxtmmutex05/init.c: Fix test. Pattern was wrong.
+
+2011-07-20     Joel Sherrill <joel.sherrill@oarcorp.com>
+
</font>   * Makefile.am, configure.ac: Add benchmark of pthread_mutex_unlock
        where it is unblocking threads without preemption.
        * psxtmmutex05/.cvsignore, psxtmmutex05/Makefile.am,

<font color='#006600'>diff -u rtems/testsuites/psxtmtests/psxtmmutex05/init.c:1.1 rtems/testsuites/psxtmtests/psxtmmutex05/init.c:1.2
--- rtems/testsuites/psxtmtests/psxtmmutex05/init.c:1.1 Wed Jul 20 15:46:48 2011
+++ rtems/testsuites/psxtmtests/psxtmmutex05/init.c     Wed Jul 20 16:30:02 2011
</font><font color='#997700'>@@ -23,22 +23,13 @@
</font> 
 pthread_mutex_t MutexId;
 
<font color='#880000'>-void *Blockers(
</font><font color='#000088'>+void *Blocker(
</font>   void *argument
 )
 {
<font color='#880000'>-  int status;
-
-  /*
-   * Now we have finished the thread startup overhead,
-   * so let other threads run.  When we return, we can
-   * finish the benchmark.
-   */
-  sched_yield();
-    /* let other threads run */
-
-  status = pthread_mutex_lock( &MutexId );
-  rtems_test_assert( status == 0 );
</font><font color='#000088'>+  (void) pthread_mutex_lock( &MutexId );
+  /* should never return */
+  rtems_test_assert( FALSE );
</font> 
   return NULL;
 }
<font color='#997700'>@@ -47,17 +38,14 @@
</font>   void *argument
 )
 {
<font color='#880000'>-  int        i;
</font>   int        status;
   pthread_t  threadId;
   long       end_time;
 
   puts( "\n\n*** POSIX TIME TEST MUTEX 05 ***" );
 
<font color='#880000'>-  for ( i=0 ; i < OPERATION_COUNT ; i++ ) {
-    status = pthread_create( &threadId, NULL, Blockers, NULL );
-    rtems_test_assert( status == 0 );
-  }
</font><font color='#000088'>+  status = pthread_create( &threadId, NULL, Blocker, NULL );
+  rtems_test_assert( status == 0 );
</font>   
   /*
    * Deliberately create the mutex after the threads.  This way if the
<font color='#997700'>@@ -73,11 +61,11 @@
</font>   rtems_test_assert( status == 0 );
 
   /*
<font color='#880000'>-   * Let the other threads start so the thread startup overhead,
</font><font color='#000088'>+   * Let the other thread start so the thread startup overhead,
</font>    * is accounted for.  When we return, we can start the benchmark.
    */
   sched_yield();
<font color='#880000'>-    /* let other threads run */
</font><font color='#000088'>+    /* let other thread run */
</font> 
   benchmark_timer_initialize();
     status = pthread_mutex_unlock( &MutexId );
<font color='#997700'>@@ -87,7 +75,7 @@
</font>   put_time(
     "pthread_mutex_unlock (no preemption)",
     end_time,
<font color='#880000'>-    OPERATION_COUNT,
</font><font color='#000088'>+    1,
</font>     0,
     0
   );
<font color='#997700'>@@ -103,7 +91,7 @@
</font> #define CONFIGURE_APPLICATION_NEEDS_CONSOLE_DRIVER
 #define CONFIGURE_APPLICATION_NEEDS_TIMER_DRIVER
 
<font color='#880000'>-#define CONFIGURE_MAXIMUM_POSIX_THREADS     OPERATION_COUNT + 1
</font><font color='#000088'>+#define CONFIGURE_MAXIMUM_POSIX_THREADS     2
</font> #define CONFIGURE_MAXIMUM_POSIX_MUTEXES     1
 #define CONFIGURE_POSIX_INIT_THREAD_TABLE
 
</pre>
<p> </p>
<a name='cs2'></a>
<table border='0' cellspacing='0' cellpadding='5' width='100%' bgcolor='#eeeeee'>
<tr><td colspan='3' bgcolor='#dddddd'>
 <font color='#bb2222'><strong>joel</strong></font>
</td></tr>
<tr><td colspan='3' bgcolor='#dddddd'><pre>2011-07-20 Joel Sherrill <joel.sherrill@oarcorp.com>

        * Makefile.am, configure.ac, psxtmtests_plan.csv: Add benchmark of
        pthread_mutex_unlock where it is unblocking threads with preemption.
        * psxtmmutex06/.cvsignore, psxtmmutex06/Makefile.am,
        psxtmmutex06/init.c, psxtmmutex06/psxtmmutex06.doc: New files.
</pre></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/testsuites/psxtmtests/ChangeLog.diff?r1=text&tr1=1.24&r2=text&tr2=1.25&diff_format=h">M</a></td><td width='1%'>1.25</td><td width='100%'>testsuites/psxtmtests/ChangeLog</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/testsuites/psxtmtests/Makefile.am.diff?r1=text&tr1=1.10&r2=text&tr2=1.11&diff_format=h">M</a></td><td width='1%'>1.11</td><td width='100%'>testsuites/psxtmtests/Makefile.am</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/testsuites/psxtmtests/configure.ac.diff?r1=text&tr1=1.13&r2=text&tr2=1.14&diff_format=h">M</a></td><td width='1%'>1.14</td><td width='100%'>testsuites/psxtmtests/configure.ac</td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/testsuites/psxtmtests/psxtmmutex06/.cvsignore?rev=1.1&content-type=text/vnd.viewcvs-markup">A</a></td><td width='1%'><font color="#000088">1.1</font></td><td width='100%'><font color="#000088">testsuites/psxtmtests/psxtmmutex06/.cvsignore</font></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/testsuites/psxtmtests/psxtmmutex06/Makefile.am?rev=1.1&content-type=text/vnd.viewcvs-markup">A</a></td><td width='1%'><font color="#000088">1.1</font></td><td width='100%'><font color="#000088">testsuites/psxtmtests/psxtmmutex06/Makefile.am</font></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/testsuites/psxtmtests/psxtmmutex06/init.c?rev=1.1&content-type=text/vnd.viewcvs-markup">A</a></td><td width='1%'><font color="#000088">1.1</font></td><td width='100%'><font color="#000088">testsuites/psxtmtests/psxtmmutex06/init.c</font></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/testsuites/psxtmtests/psxtmmutex06/psxtmmutex06.doc?rev=1.1&content-type=text/vnd.viewcvs-markup">A</a></td><td width='1%'><font color="#000088">1.1</font></td><td width='100%'><font color="#000088">testsuites/psxtmtests/psxtmmutex06/psxtmmutex06.doc</font></td></tr>
<tr><td width='1%'><a href="http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/testsuites/psxtmtests/psxtmtests_plan.csv.diff?r1=text&tr1=1.13&r2=text&tr2=1.14&diff_format=h">M</a></td><td width='1%'>1.14</td><td width='100%'>testsuites/psxtmtests/psxtmtests_plan.csv</td></tr>
</table>
<pre>
<font color='#006600'>diff -u rtems/testsuites/psxtmtests/ChangeLog:1.24 rtems/testsuites/psxtmtests/ChangeLog:1.25
--- rtems/testsuites/psxtmtests/ChangeLog:1.24  Wed Jul 20 16:30:01 2011
+++ rtems/testsuites/psxtmtests/ChangeLog       Wed Jul 20 16:39:25 2011
</font><font color='#997700'>@@ -1,5 +1,12 @@
</font> 2011-07-20        Joel Sherrill <joel.sherrill@oarcorp.com>
 
<font color='#000088'>+   * Makefile.am, configure.ac, psxtmtests_plan.csv: Add benchmark of
+       pthread_mutex_unlock where it is unblocking threads with preemption.
+       * psxtmmutex06/.cvsignore, psxtmmutex06/Makefile.am,
+       psxtmmutex06/init.c, psxtmmutex06/psxtmmutex06.doc: New files.
+
+2011-07-20     Joel Sherrill <joel.sherrill@oarcorp.com>
+
</font>   * psxtmmutex05/init.c: Fix test. Pattern was wrong.
 
 2011-07-20     Joel Sherrill <joel.sherrill@oarcorp.com>

<font color='#006600'>diff -u rtems/testsuites/psxtmtests/Makefile.am:1.10 rtems/testsuites/psxtmtests/Makefile.am:1.11
--- rtems/testsuites/psxtmtests/Makefile.am:1.10        Wed Jul 20 15:46:48 2011
+++ rtems/testsuites/psxtmtests/Makefile.am     Wed Jul 20 16:39:25 2011
</font><font color='#997700'>@@ -13,6 +13,7 @@
</font> SUBDIRS += psxtmmutex02
 SUBDIRS += psxtmmutex03
 SUBDIRS += psxtmmutex05
<font color='#000088'>+SUBDIRS += psxtmmutex06
</font> SUBDIRS += psxtmmutex07
 SUBDIRS += psxtmnanosleep01
 SUBDIRS += psxtmnanosleep02

<font color='#006600'>diff -u rtems/testsuites/psxtmtests/configure.ac:1.13 rtems/testsuites/psxtmtests/configure.ac:1.14
--- rtems/testsuites/psxtmtests/configure.ac:1.13       Wed Jul 20 15:46:48 2011
+++ rtems/testsuites/psxtmtests/configure.ac    Wed Jul 20 16:39:25 2011
</font><font color='#997700'>@@ -85,6 +85,7 @@
</font> psxtmmutex02/Makefile
 psxtmmutex03/Makefile
 psxtmmutex05/Makefile
<font color='#000088'>+psxtmmutex06/Makefile
</font> psxtmmutex07/Makefile
 psxtmnanosleep01/Makefile
 psxtmnanosleep02/Makefile

<font color='#006600'>diff -u /dev/null rtems/testsuites/psxtmtests/psxtmmutex06/.cvsignore:1.1
--- /dev/null   Wed Jul 20 17:12:02 2011
+++ rtems/testsuites/psxtmtests/psxtmmutex06/.cvsignore Wed Jul 20 16:39:25 2011
</font><font color='#997700'>@@ -0,0 +1,2 @@
</font><font color='#000088'>+Makefile
+Makefile.in
</font>
<font color='#006600'>diff -u /dev/null rtems/testsuites/psxtmtests/psxtmmutex06/Makefile.am:1.1
--- /dev/null   Wed Jul 20 17:12:02 2011
+++ rtems/testsuites/psxtmtests/psxtmmutex06/Makefile.am        Wed Jul 20 16:39:25 2011
</font><font color='#997700'>@@ -0,0 +1,30 @@
</font><font color='#000088'>+##
+## $Id$
+##
+
+MANAGERS = all
+
+rtems_tests_PROGRAMS = psxtmmutex06
+psxtmmutex06_SOURCES = init.c ../../tmtests/include/timesys.h \
+    ../../support/src/tmtests_empty_function.c \
+    ../../support/src/tmtests_support.c
+
+dist_rtems_tests_DATA = psxtmmutex06.doc
+
+include $(RTEMS_ROOT)/make/custom/@RTEMS_BSP@.cfg
+include $(top_srcdir)/../automake/compile.am
+include $(top_srcdir)/../automake/leaf.am
+
+OPERATION_COUNT = @OPERATION_COUNT@
+AM_CPPFLAGS += -I$(top_srcdir)/../tmtests/include
+AM_CPPFLAGS += -DOPERATION_COUNT=$(OPERATION_COUNT)
+AM_CPPFLAGS += -I$(top_srcdir)/../support/include
+
+LINK_OBJS = $(psxtmmutex06_OBJECTS) $(psxtmmutex06_LDADD)
+LINK_LIBS = $(psxtmmutex06_LDLIBS)
+
+psxtmmutex06$(EXEEXT): $(psxtmmutex06_OBJECTS) $(psxtmmutex06_DEPENDENCIES)
+       @rm -f psxtmmutex06$(EXEEXT)
+       $(make-exe)
+
+include $(top_srcdir)/../automake/local.am
</font>
<font color='#006600'>diff -u /dev/null rtems/testsuites/psxtmtests/psxtmmutex06/init.c:1.1
--- /dev/null   Wed Jul 20 17:12:02 2011
+++ rtems/testsuites/psxtmtests/psxtmmutex06/init.c     Wed Jul 20 16:39:25 2011
</font><font color='#997700'>@@ -0,0 +1,154 @@
</font><font color='#000088'>+/*
+ *  COPYRIGHT (c) 1989-2011.
+ *  On-Line Applications Research Corporation (OAR).
+ *
+ *  The license and distribution terms for this file may be
+ *  found in the file LICENSE in this distribution or at
+ *  http://www.rtems.com/license/LICENSE.
+ *
+ *  $Id$
+ */
+
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
+#include <coverhd.h>
+#include <tmacros.h>
+#include <timesys.h>
+#include "test_support.h"
+#include <pthread.h>
+#include <sched.h>
+#include <rtems/timerdrv.h>
+
+pthread_mutex_t MutexId;
+
+void *Low(
+  void *argument
+)
+{
+  int      status;
+  uint32_t end_time;
+
+    status = pthread_mutex_lock( &MutexId );
+  end_time = benchmark_timer_read();
+
+  rtems_test_assert( status == 0 );
+
+  put_time(
+    "pthread_mutex_unlock (unblocking, prempt)",
+    end_time,
+    OPERATION_COUNT,
+    0,
+    0
+  );
+
+  puts( "*** END OF POSIX TIME TEST MUTEX 07 ***" );
+  rtems_test_exit( 0 );
+  return NULL;
+}
+
+void *Middle(
+  void *argument
+)
+{
+  int status;
+
+  status = pthread_mutex_lock( &MutexId );
+  rtems_test_assert( status == 0 );
+
+    /* thread switch occurs */
+
+  status = pthread_mutex_unlock( &MutexId );
+  rtems_test_assert( status == 0 );
+
+    /* thread switch occurs */
+
+  return NULL;
+}
+
+void *POSIX_Init(
+  void *argument
+)
+{
+  int                 i;
+  int                 status;
+  pthread_t           threadId;
+  pthread_attr_t      attr;
+  struct sched_param  param;
+
+  puts( "\n\n*** POSIX TIME TEST MUTEX 02 ***" );
+
+  /*
+   * Deliberately create the mutex BEFORE the threads.  This way the
+   * threads should preempt this thread and block as they are created.
+   */
+  status = pthread_mutex_init( &MutexId, NULL );
+  rtems_test_assert( status == 0 );
+
+  /*
+   * Lock the mutex so the threads will block.
+   */
+  status = pthread_mutex_lock( &MutexId );
+  rtems_test_assert( status == 0 );
+
+  /*
+   * Now lower our priority
+   */
+  status = pthread_attr_init( &attr );
+  rtems_test_assert( status == 0 );
+
+  status = pthread_attr_setinheritsched( &attr, PTHREAD_EXPLICIT_SCHED );
+  rtems_test_assert( status == 0 );
+
+  status = pthread_attr_setschedpolicy( &attr, SCHED_RR );
+  rtems_test_assert( status == 0 );
+
+  param.sched_priority = 2;
+  status = pthread_attr_setschedparam( &attr, &param );
+  rtems_test_assert( status == 0 );
+
+  /*
+   * And create rest of threads as more important than we are.  They
+   * will preempt us as they are created and block.
+   */
+  for ( i=0 ; i < OPERATION_COUNT ; i++ ) {
+
+    param.sched_priority = 3 + i;
+    status = pthread_attr_setschedparam( &attr, &param );
+    rtems_test_assert( status == 0 );
+
+    status = pthread_create(
+      &threadId,
+      &attr,
+      (i == OPERATION_COUNT - 1) ? Low : Middle,
+      NULL
+    );
+    rtems_test_assert( status == 0 );
+  }
+<span style="background-color: #FF0000">  </span>
+  /*
+   * Now start the timer which will be stopped in Low
+   */
+  benchmark_timer_initialize();
+
+    status = pthread_mutex_unlock( &MutexId );
+    rtems_test_assert( status == 0 );
+
+      /* thread switch occurs */
+  return NULL;
+}
+
+/* configuration information */
+
+#define CONFIGURE_APPLICATION_NEEDS_CONSOLE_DRIVER
+#define CONFIGURE_APPLICATION_NEEDS_TIMER_DRIVER
+
+#define CONFIGURE_MAXIMUM_POSIX_THREADS     OPERATION_COUNT + 2
+#define CONFIGURE_MAXIMUM_POSIX_MUTEXES     1
+#define CONFIGURE_POSIX_INIT_THREAD_TABLE
+
+#define CONFIGURE_INIT
+
+#include <rtems/confdefs.h>
+  /* end of file */
</font>
<font color='#006600'>diff -u /dev/null rtems/testsuites/psxtmtests/psxtmmutex06/psxtmmutex06.doc:1.1
--- /dev/null   Wed Jul 20 17:12:02 2011
+++ rtems/testsuites/psxtmtests/psxtmmutex06/psxtmmutex06.doc   Wed Jul 20 16:39:25 2011
</font><font color='#997700'>@@ -0,0 +1,14 @@
</font><font color='#000088'>+#
+#  $Id$
+#
+#  COPYRIGHT (c) 1989-2011.
+#  On-Line Applications Research Corporation (OAR).
+#
+#  The license and distribution terms for this file may be
+#  found in the file LICENSE in this distribution or at
+#  http://www.rtems.com/license/LICENSE.
+#
+
+This test benchmarks the following operations:
+
++ pthread_mutex_unlock - thread waiting, preempt
</font>
<font color='#006600'>diff -u rtems/testsuites/psxtmtests/psxtmtests_plan.csv:1.13 rtems/testsuites/psxtmtests/psxtmtests_plan.csv:1.14
--- rtems/testsuites/psxtmtests/psxtmtests_plan.csv:1.13        Wed Jul 20 08:20:24 2011
+++ rtems/testsuites/psxtmtests/psxtmtests_plan.csv     Wed Jul 20 16:39:25 2011
</font><font color='#997700'>@@ -6,8 +6,8 @@
</font> "pthread_mutex_trylock - available","psxtmmutex03","psxtmtest_single","Yes"
 "pthread_mutex_trylock - not available","psxtmmutex03","psxtmtest_single","Yes"
 "pthread_mutex_unlock - no threads waiting","psxtmmutex03","psxtmtest_single","Yes"
<font color='#880000'>-"pthread_mutex_unlock - thread waiting, no preempt","psxtmmutex05","psxtmtest_unblocking_nopreempt",
-"pthread_mutex_unlock - thread waiting, preempt","psxtmmutex06","psxtmtest_unblocking_preempt",
</font><font color='#000088'>+"pthread_mutex_unlock - thread waiting, no preempt","psxtmmutex05","psxtmtest_unblocking_nopreempt","Yes"
+"pthread_mutex_unlock - thread waiting, preempt","psxtmmutex06","psxtmtest_unblocking_preempt","Yes"
</font> "pthread_mutex_timedlock - available","psxtmmutex03","psxtmtest_single","Yes"
 "pthread_mutex_timedlock - not available, block","psxtmmutex04","psxtmtest_blocking","Yes"
 "pthread_mutex_setprioceiling","psxtmmutex07","psxtmtest_single","Yes"
</pre>
<p> </p>

<p>--<br />
<small>Generated by <a href="http://www.codewiz.org/projects/index.html#loginfo">Deluxe Loginfo</a> 2.122 by Bernardo Innocenti <bernie@develer.com></small></p>
</body>
</html>