[Bug 1229] New: linesw symbol clashes

[rtems-bugs at rtems.org]

http://www.rtems.org/bugzilla/show_bug.cgi?id=1229

           Summary: linesw symbol clashes
           Product: RTEMS
           Version: 4.7
          Platform: All
        OS/Version: RTEMS
            Status: NEW
          Severity: normal
          Priority: P3
         Component: cpukit
        AssignedTo: joel.sherrill at oarcorp.com
        ReportedBy: ralf.corsepius at rtems.org


libnetworking and termios define several clashing symbols (vars and types)
related to "linesw":

# grep -R linesw cpukit
cpukit/libnetworking/sys/conf.h:struct linesw {
cpukit/libnetworking/sys/conf.h:extern struct linesw linesw[];
cpukit/libnetworking/sys/conf.h:extern int nlinesw;

cpukit/libnetworking/net/ppp_tty.c:static struct linesw pppdisc = {
cpukit/libnetworking/net/ppp_tty.c:    linesw[PPPDISC] = pppdisc;

cpukit/libcsupport/include/rtems/termiostypes.h:struct linesw {
cpukit/libcsupport/include/rtems/termiostypes.h:extern struct linesw linesw[];
cpukit/libcsupport/include/rtems/termiostypes.h:extern int nlinesw;

Looking into the code shows that both ppp and termios use the termios' versions
of the "linesw" symbols and that the BSD "linesw" symbols are unused inside of
RTEMS.

For 4.8, I am proposing to remove the BSD "linesw" symbols and to prefix the
termios "linesw" symbols with "rtems_termios_*"

For 4.7, prefixing would break the API. Therefore I am proposing to remove the
BSD "linesw" only.


-- 
Configure bugmail: http://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You reported the bug, or are watching the reporter.