[Bug 1257] missing compiler memory barrier when using _CPU_ISR_Disable()/_CPU_ISR_Enable()

rtems-bugs at rtems.org rtems-bugs at rtems.org
Tue Sep 11 23:22:36 UTC 2007


http://www.rtems.org/bugzilla/show_bug.cgi?id=1257


joel.sherrill at oarcorp.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #513 is|0                           |1
           obsolete|                            |
 Attachment #514 is|0                           |1
           obsolete|                            |




------- Comment #4 from joel.sherrill at oarcorp.com  2007-09-11 18:22 -------
Created an attachment (id=515)
 --> (http://www.rtems.org/bugzilla/attachment.cgi?id=515&action=view)
Manually verified.. version of previous patch

I just ran an analysis of the attached patch and think it is OK.  I would
appreciate someone else doing a second similar review.  I did this:

cat -n DIFF_FILE | grep _[dD]isable | less
cat -n DIFF_FILE | grep _[eN]isable | less

When my changes are correct the line numbers should be N and N+1 for the "-" 
and "+" lines to indicate the old and new lines.  Even with my style changes,
there were never more than 5 lines difference. I think these are OK.

I am NOT committing tonight.  I will compile everything again overnight. 
Please, please review.


-- 
Configure bugmail: http://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You reported the bug, or are watching the reporter.



More information about the bugs mailing list