[Bug 949] MSG_DONTWAIT not available to applications

[bugzilla-daemon at rtems.org]

http://www.rtems.org/bugzilla/show_bug.cgi?id=949


Joel Sherrill <joel.sherrill at oarcorp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED

Ralf Corsepius <ralf.corsepius at rtems.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |WAITING

Joel Sherrill <joel.sherrill at oarcorp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
           Platform|                            |All
         Resolution|                            |INVALID
   Target Milestone|---                         |4.9


I include <sys/socket.h> in my application but MSG_DONTWAIT is not defined.
This is due to a missplaced "#if __BSD_VISIBLE" in that header file. The
attached patch fixes this problem. Please apply.

Regards
Lars Munch

Release:
unknown

Environment:
Target pc386, but this applies to all targets


--- Comment #1 from Joel Sherrill <joel.sherrill at oarcorp.com>  2006-04-12 16:00:10 ---
State-Changed-From-To: open->closed
State-Changed-Why: Applied to CVS head aka 4.7.


--- Comment #2 from Ralf Corsepius <ralf.corsepius at rtems.org>  2006-04-13 03:58:24 ---
State-Changed-From-To: closed->feedback
State-Changed-Why: The patch is not correct.


--- Comment #3 from Ralf Corsepius <ralf.corsepius at rtems.org>  2006-04-13 10:57:26 ---
From: Ralf Corsepius <ralf.corsepius at rtems.org>
To: bugs at rtems.com
Cc: lars at segv.dk, mayes at oarcorp.com, chrisj at rtems.com, ralf_corsepius at rtems.org,  jennifer at oarcorp.com, jmj at oarcorp.com, joel at oarcorp.com, norume at aps.anl.gov
Subject: Re: RTEMS Re: networking/949
Date: Thu, 13 Apr 2006 10:57:26 +0200

 On Wed, 2006-04-12 at 21:00 +0000, RTEMS-gnats at rtems.com wrote:
 > Synopsis: MSG_DONTWAIT not available to applications
 > 
 > State-Changed-From-To: open->closed
 > State-Changed-By: joel
 > State-Changed-When: Wed, 12 Apr 2006 16:00:10 -0500
 > State-Changed-Why:
 > Applied to CVS head aka 4.7.  
 > 
 > 
 > 
 > 
 >  http://www.rtems.com/cgi-bin/gnatsweb.pl?cmd=view&database=RTEMS&pr=949
 
 The patch is wrong.
 
 MSG_DONTWAIT is BSD proprietary and not covered by any standard.
 Therefore it should be guarded by __BSD_VISIBLE and not available to
 applications by defaut.
 
 Applications wanting to use it are nonportable and therefore should
 -D__BSD_VISIBLE, themselves
 
 Joel, please revert this change.
 
 Ralf
  
 


--- Comment #4 from lars at segv.dk  2006-04-13 12:25:44 ---
From: lars at segv.dk (Lars Munch)
To: Ralf Corsepius <ralf.corsepius at rtems.org>
Cc: bugs at rtems.com, lars at segv.dk, mayes at oarcorp.com,
	chrisj at rtems.com, ralf_corsepius at rtems.org, jennifer at oarcorp.com,
	jmj at oarcorp.com, joel at oarcorp.com, norume at aps.anl.gov
Subject: Re: RTEMS Re: networking/949
Date: Thu, 13 Apr 2006 12:25:44 +0200

 On Thu, Apr 13, 2006 at 10:57:26AM +0200, Ralf Corsepius wrote:
 > On Wed, 2006-04-12 at 21:00 +0000, RTEMS-gnats at rtems.com wrote:
 > > Synopsis: MSG_DONTWAIT not available to applications
 > > 
 > > State-Changed-From-To: open->closed
 > > State-Changed-By: joel
 > > State-Changed-When: Wed, 12 Apr 2006 16:00:10 -0500
 > > State-Changed-Why:
 > > Applied to CVS head aka 4.7.  
 > > 
 > > 
 > > 
 > > 
 > >  http://www.rtems.com/cgi-bin/gnatsweb.pl?cmd=view&database=RTEMS&pr=949
 > 
 > The patch is wrong.
 > 
 > MSG_DONTWAIT is BSD proprietary and not covered by any standard.
 > Therefore it should be guarded by __BSD_VISIBLE and not available to
 > applications by defaut.
 > 
 > Applications wanting to use it are nonportable and therefore should
 > -D__BSD_VISIBLE, themselves
 > 
 > Joel, please revert this change.
 > 
 > Ralf
 > 
 
 Hello
 
 Sorry for the confusion, I did not check the POSIX standard before
 submitting the patch and my man page on revc did not cover
 MSG_DONTWAIT as an exception to the POSIX standard.
 
 I'll add a define for __BSD_VISIBLE in my program instead.
 	
 Thanks
 Lars Munch

--- Comment #5 from Joel Sherrill <joel.sherrill at oarcorp.com>  2008-08-05 11:00:07 ---
Should have been closed long ago


-- 
Configure bugmail: http://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.