[Bug 500] Termios tty->buf overflow correction

[bugzilla-daemon at rtems.org]

http://www.rtems.org/bugzilla/show_bug.cgi?id=500


Joel Sherrill <joel.sherrill at oarcorp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|joel                        |eric

Chris Johns <chrisj at rtems.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|eric                        |chrisj

Joel Sherrill <joel.sherrill at oarcorp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|chrisj                      |eric
             Status|ASSIGNED                    |WAITING
           Platform|                            |All
   Target Milestone|---                         |4.9


Evenif you will have hardware flowcontrol enable,
you will have some overflow in interrupt mode.
Flow control can avoid
overflow of raw_inbuf but don't care of tty->buf, and
fillbufferQueue don't care about tty->buf size. Just
care about this size in fillbufferqueue avoid of
this overflow.

Disable interrupt in fillBufferQueue() before modify
tty->flow_ctrl. It could have some trouble when
you are at lowwater and if some serial interrupt come
on fill the buffer and ask to stopremotetx. They only
happend in low performance cpu.

Release:
RTEMS-4.6

How-To-Repeat:
Just transfert a big file with overflow enable, you will
lose many character.

--- Comment #1 from cedric_aubert at yahoo.fr  2003-09-25 03:30:01 ---
Fix:
Apply patch, this succesfully work and be tested on my board

CCJ: Added the second patch posted to the mail list on 18-Feb-2004.

--- Comment #2 from Joel Sherrill <joel.sherrill at oarcorp.com>  2003-09-26 12:44:12 ---
Responsible-Changed-From-To: joel->eric
Responsible-Changed-Why: Could you please look at this one?


--- Comment #3 from Chris Johns <chrisj at rtems.org>  2004-02-17 23:32:33 ---
Responsible-Changed-From-To: eric->chrisj
Responsible-Changed-Why: Joel asked if Eric or I could take a look. I will.


--- Comment #4 from Joel Sherrill <joel.sherrill at oarcorp.com>  2005-09-01 10:01:39 ---
Responsible-Changed-From-To: chrisj->eric
Responsible-Changed-Why: Previously set to unknown.


--- Comment #5 from Joel Sherrill <joel.sherrill at oarcorp.com>  2006-09-08 15:46:18 ---
State-Changed-From-To: open->feedback
State-Changed-Why: Come on folks.  Let's review this.  If it is OK, commit it.
 If it is no longer a bug or has been fixed in a different
way, someone please close this.


--- Comment #6 from Joel Sherrill <joel.sherrill at oarcorp.com>  2008-08-05 12:16:13 ---
Ping?


-- 
Configure bugmail: http://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.