[Bug 1657] New BSP code inclusion in CVS HEAD - Milkymist

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=1657

--- Comment #4 from Joel Sherrill <joel.sherrill at oarcorp.com> 2010-08-08 09:56:38 CDT ---
Comments in no particular order.  

+ no ChangeLog entries.  BSP is empty

+ Fix warnings when building BSP.

+ rtems-testing has a script named "check_bsp" which has identified some
  common issues.  Please address them.

+ Makefile.am has some lines longer than 80 columns.

+ include/bsp.h
  - comment block. 
  - does lm32 use Simple Vectored Interrupts? Is so then you need
    set_vector. and it should be prototyped here.
  - 80 columns.

+ use shared coverhd.h 

+ We really could use a shared tm27.h which is a stub.  BUT... you need to
implement a way to cause an interrupt so tm27 can be run for benchmark
performance.

+ Please update
http://wiki.rtems.org/wiki/index.php/BoardSupportPackageInformation to include
this board.  Also add a page to
this which instructions from where to get a simulator, board, etc.  How
to run, debug, simulate.  

+ Add script support to rtems-testing/sim-scripts to run the simulator.

All in all it is close.  Thanks to check_bsp, I am able to be pickier in
the review.  You are the first new BSP I got to use it on. :)

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.