[Bug 1636] Refactor Rate Monotonic Manager into a generic Periodic Manager

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Wed Aug 11 16:53:37 UTC 2010


https://www.rtems.org/bugzilla/show_bug.cgi?id=1636

--- Comment #8 from Gedare <giddyup44 at yahoo.com> 2010-08-11 11:53:37 CDT ---
(In reply to comment #7)
> + If I am right, I think you rename rate_monotonic_period_XXX
> to rate_periodic_XXX and I can't accept that part of the patch. This
> would break API compatibility and although it can be argued that
> the rate monotonic name obscures the fundamental nature of the periodic
> blocking service being implemented, it is really the theoretical reason
> this manager exists.  So can your periodicXXX be moved to ratemonXXX and
> fixed?
> 
Actually I copied rtems_rate_monotonic_XXX to rtems_periodic_XXX, and turned
the rtems_rate_monotonic_XXX into a wrapper that simply calls the
rtems_periodic_XXX routine.  This maintains the existing API, while enabling
new applications to use the more generic Periodic routines.  I guess if this is
OK then I should create user documentation for the rtems_periodic_XXX API
routines.

> + You can't have objects with Ids in the score.  They all have to take
> pointers.  You combine score handlers with object control structure to
> create API level objects.  So this periodic thing in the core needs to
> change to more of a support service.  I think it is close.  I suspect 
> you just need to remove the Object_Control field from the structure
> and add it at the ratemon level.  You never really used the id anyway
> as best I can tell.
> 
OK I think I can fix this.  This was a relic of simply copying the Rate
Monotonic implementation into the score. I think that I can fix this part easy
enough.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the bugs mailing list