[Bug 1607] __RTEMS_SIZEOF_VOID_P__ flawed design

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=1607

Sebastian Huber <sebastian.huber at embedded-brains.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sebastian.huber at embedded-br
                   |                            |ains.de

--- Comment #1 from Sebastian Huber <sebastian.huber at embedded-brains.de> 2010-07-07 09:45:16 CDT ---
(In reply to comment #0)
> This change is a massive design flaw:
> 
> > 2010-06-29 Joel Sherrill <joel.sherrill at oarcorp.com>
> > 
> > * configure.ac, score/include/rtems/score/percpu.h: Add
> > __RTEMS_SIZEOF_VOID_P__ to cpuopts.h so percpu.h has this information
> > available during build and after installation.
> 
> Sizes are compile time constants and therefore may depend upon compiler 
> flags (e.g. multilibs) flags. Defining them in a globally exported 
> header being shared by different architecture variants qualifies is absurd.
> 
> Proposal: Joel to revert his whole __RTEMS_SIZEOF_VOID_P__ patch-set.

Maybe we should add this define to a no-installation header file?

Btw. is SIZEOF_CPU_CONTEXT also something suspicious in cpuopts.h?

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.