[Bug 1593] RTEMS Sequenced Initialization API

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=1593

--- Comment #14 from Sebastian Huber <sebastian.huber at embedded-brains.de> 2010-07-23 04:05:36 CDT ---
(In reply to comment #11)
> Created an attachment (id=902)
 --> (https://www.rtems.org/bugzilla/attachment.cgi?id=902) [details]

The bugzilla as a feature to obsolete previous attachments.

1. The no-*.c files contain now no definitions.  Why do we still need all these
header file includes? A comment in these now virtually empty files would be
nice.  Something like this:

These files are present to not break user Makefiles.

2. Comments like

+/**
+ *  This macro define Sysinit entry of Barrier Manager, it will be 
+ *  referenced in the barriercreate.c
+ *
+ *  Input parameters:   
+ *    handler  -  _Barrier_Manager_Sysinit
+ *    group  -  SYSINIT_GROUP_BARRIER
+ */

add no information.

3. The sysinit handlers like _Barrier_Manager_Sysinit() are only used locally,
please make them static.

4. You add the sysinit entries to the initialization manager and add a
reference to the create modules.  This is not necessary.  Simply add the
sysinit entry to the create modules.  This avoids the references.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.