[Bug 1556] New: rfs type efs violate type naming conventions

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Mon Jun 14 14:13:27 UTC 2010


https://www.rtems.org/bugzilla/show_bug.cgi?id=1556

           Summary: rfs type efs violate type naming conventions
           Product: RTEMS
           Version: 4.10
          Platform: All
        OS/Version: RTEMS
            Status: NEW
          Severity: blocker
          Priority: P3
         Component: cpukit
        AssignedTo: joel.sherrill at oarcorp.com
        ReportedBy: ralf.corsepius at rtems.org
                CC: chrisj at rtems.org


The rfs code applies this kind of typedefs

typedef struct xxxx_t {
...
} xxxx;

This violates the conventions POSIX and RTEMS apply on types' naming:

*_t is meant to be a typedef.

i.e. these typedefs are *all* reversed and should be renamed such that the *_t
are the typedefs.

Proposal: drop the structs and use typedefs only, i.e.
typedef struct {
...
} xxx_t;

Alternatively 
typedef struct xxxx_s {
...
} xxx_t;

I haven't checked it this also affects rtems-4.10, but marking this as a
blocker bug for 4.10 until this has been verified.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the bugs mailing list