[Bug 1657] New BSP code inclusion in CVS HEAD - Milkymist
bugzilla-daemon at rtems.org
bugzilla-daemon at rtems.org
Fri Sep 3 20:20:51 UTC 2010
https://www.rtems.org/bugzilla/show_bug.cgi?id=1657
--- Comment #20 from Michael Walle <michael at walle.cc> 2010-09-03 15:20:48 CDT ---
Comments in no particular order:
+ declare interrupts with IRQ number, not a bitmask. then use (1 <<
IRQ_UART_RX)
+ define register offsets to a base address in the device drivers. declare the
offsets within the driver and the base address within the bsp include
(system_conf.h see below). This allows the reuse of the driver within other
bsps :)
+ rename system_conf.h to milkymist.h
+ move IRQ definitions to bsp include
+ move timer offsets to clock.h
+ no framebuffer.h ?
+ hardcoded values in gpio.c -> missing gpio.h
--
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
More information about the bugs
mailing list