[Bug 1781] Adding Support for Analog Devices Blackfin 52x DSP processors.

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=1781

--- Comment #1 from Joel Sherrill <joel.sherrill at oarcorp.com> 2011-04-18 17:38:24 CDT ---
Odd questions and issues as I merge and review this.

+ The following files were flagged as not having copyright statements.

COPYRIGHT is NOT in ././console/console.c - case independent check
COPYRIGHT is NOT in ././startup/bspstart.c - case independent check
COPYRIGHT is NOT in ././include/bsp.h - case independent check
COPYRIGHT is NOT in ././include/tm27.h - case independent check

+ The following issues were spotted by the checker script in the
libcpu/bfin/bf52x code:

=== Checking for lines greater than 79 columns
./ has the following lines that are too long
40: *    * Array to hold isr function pointers IRQ_MAX(56)*sizeof(bfin_isr_t)=
896B
54: *       additional pointers                                       
56*7*4=1568B
74:
******************************************************************************/
103: * @brief Contains a table of ISR and arguments. The ISR jumps directly to
these
231: * This function registers a new ISR. It will write a new entry to the IVT
table
./ has the following lines that are too long
115: * This function registers a new ISR. It will write a new entry to the IVT
table
=== Checking for copyright notices
COPYRIGHT is NOT in ././interrupt/interrupt.c - case independent check
COPYRIGHT is NOT in ././interrupt/interrupt.h - case independent check
COPYRIGHT is NOT in ././include/bf52x.h - case independent check

+ Do all source files have a license in them?  If not, please add
the standard RTEMS license.

+ I am attaching a replacement for your bsp's Makefile.am to not make .rel
"lumps".  This will keep the linked executables smaller.

+ I did not see warnings for the BSP but libcpu has warnings in a file you
touched.  I don't know if these were present before you made your changes.  If
you introduced them or see the fix, please include it in the next patch:

../../../../../../../rtems/c/src/lib/libcpu/bfin/serial/uart.c:145:12: warning:
variable 'r' set but not used [-Wunused-but-set-variable]
../../../../../../../rtems/c/src/lib/libcpu/bfin/serial/uart.c:143:12: warning:
variable 'rx_dma_base' set but not used [-Wunused-but-set-variable]
../../../../../../../rtems/c/src/lib/libcpu/bfin/serial/uart.c:476:25: warning:
variable 'base' set but not used [-Wunused-but-set-variable]

I compiled this for 4.10 and 4.11.  The attached Makefile.am is for your bsp
subdirectory.

Clean these up and it will be ready.  I want to merge it onto 4.10 and 4.11
since this board is part of university labs and we want a stable RTEMS to be
available for it.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.