[Bug 1869] Full port to the Milkymist One

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=1869

--- Comment #3 from Joel Sherrill <joel.sherrill at oarcorp.com> 2011-08-01 08:50:55 CDT ---
First.  Thanks.  And the BSP is committed.  

There were a few issues which are easier to do with a follow up patch.  There
is a script in rtems-testing named "check_bsp" which flagged a few issues in
the shared code.  It found no significant issues in the milkymist BSP
directory.
The following issues were in the libbsp/lm32/shared directory. Fix these and
follow up with a patch.

=== Checking for lines greater than 79 columns
./ has the following lines that are too long
38:    rtems_interrupt_catch( handler, vector, (rtems_isr_entry *)
&previous_isr );
./ has the following lines that are too long
65:/* BUFMAX defines the maximum number of characters in inbound/outbound
buffers */
73: * Set by debugger to indicate that when handling memory faults (bus
errors), the
420:   * Executing this does no harm on CPUs without a cache. We flush data
cache as
./ has the following lines that are too long
103:  return *((uint16_t *)(TS_MAC_CORE_BASE_ADDRESS + LM32_TSMAC_MAC_REGS_DATA
+ 2));
108:  *((uint16_t *)(TS_MAC_CORE_BASE_ADDRESS + LM32_TSMAC_MAC_REGS_DATA + 2))
= value;
434:  printk(TSMAC_NAME ": MAC TX_RX_CTL %04x\n",
tsmacregread(LM32_TSMAC_TX_RX_CTL_BYTE0));
435:  printk(TSMAC_NAME ": MAC MAX_PKT_SIZE %04x\n",
tsmacregread(LM32_TSMAC_MAX_PKT_SIZE_BYTE0));
436:  printk(TSMAC_NAME ": MAC IPG_VAL %04x\n",
tsmacregread(LM32_TSMAC_IPG_VAL_BYTE0));
705:int rtems_tsmac_driver_attach(struct rtems_bsdnet_ifconfig *config, int
attaching)
737:      printk(TSMAC_NAME ": Using default base address 0x%08x.\n",
TS_MAC_CORE_BASE_ADDRESS);
=== Checking for copyright notices
COPYRIGHT is NOT in ././start/start.S - case independent check
COPYRIGHT is NOT in ././gdbstub/lm32-debug.S - case independent check
=== Checking for CVS Id strings
=== Checking for stdio
(printf) SHOULD NOT BE IN ././milkymist_flash/flash.c
(printf) SHOULD NOT BE IN ././milkymist_versions/versions.c
=== Checking for reformatted RTEMS license notices
=== Checking for hints of GPL code
=== Checking for TODO hints
(XXX) SHOULD NOT BE IN ././startup/setvec.c
(XXX) SHOULD NOT BE IN ././timer/timer.c
=== Checking for not using -O2
=== Checking for turning on extra GCC warning checks
=== Checking for timing information
Please run the timing tests and include the results.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.