[Bug 1869] Full port to the Milkymist One

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=1869

--- Comment #6 from Sebastien Bourdeauducq <sebastien.bourdeauducq at gmail.com> 2011-08-02 06:57:09 CDT ---
Thanks for the speedy merge!

Most of the check_bsp errors you mentioned are from the initial LM32 EVR port
and were already there before this patch (or any form of specific Milkymist SoC
support). I'll send you a patch against them anyway...

The two warnings about "printf" correspond in fact to uses of sprintf(). Is it
incorrect to call sprintf() from a driver? What is the recommended way to
format strings in drivers?

Also, you forgot little bits of the patch:
* delete c/src/lib/libbsp/lm32/shared/milkymist_networking/mm_crc32.c (this is
dead/duplicate code)
* move the contents of c/src/lib/libbsp/lm32/README into
c/src/lib/libbsp/lm32/lm32_evr/README (the text there is specific to the LM32
EVR and not to LM32 processors in general)
* I also have removed set_vector() (and setvec.c), since we use
rtems_interrupt_catch() and I remember reading somewhere that set_vector() was
deprecated. Correct me if I am wrong.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.