[Bug 1976] New: c/src/libchip/serial/z85c30.c:707:18: warning: variable 'ulCtrlPort2' set but not used

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Thu Dec 1 02:43:11 UTC 2011


https://www.rtems.org/bugzilla/show_bug.cgi?id=1976

           Summary: c/src/libchip/serial/z85c30.c:707:18: warning:
                    variable 'ulCtrlPort2' set but not used
           Product: RTEMS
           Version: HEAD
          Platform: All
        OS/Version: RTEMS
            Status: NEW
          Severity: normal
          Priority: P3
         Component: misc
        AssignedTo: joel.sherrill at oarcorp.com
        ReportedBy: ralf.corsepius at rtems.org


GCC raises the warning from the subject, which is pointing to this code:

...
Z85C30_STATIC void z85c30_initialize_interrupts(
  int minor
)
{
  uint32_t       ulCtrlPort1;
  uint32_t       ulCtrlPort2;
  setRegister_f  setReg;

  ulCtrlPort1 = Console_Port_Tbl[minor]->ulCtrlPort1;
  ulCtrlPort2 = Console_Port_Tbl[minor]->ulCtrlPort2;
  setReg      = Console_Port_Tbl[minor]->setRegister;
...

=> ulCtrlPort2 is not used.

Removing the 2 lines referring to ulCtrlPort2 would silence GCC, 
but I am not sure if this warning actually points to a defect.

It seems to me, as if the original author of this code had wanted to initialize
something related to "ulCtrlPort2", which was never implemented, lost or else
throughout this file's history - I don't know.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the bugs mailing list