[Bug 1729] SMP Step #2

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=1729

--- Comment #21 from Joel Sherrill <joel.sherrill at oarcorp.com> 2011-02-23 08:09:36 CST ---
(In reply to comment #20)
> (In reply to comment #19)
> > (In reply to comment #18)
> > > Created an attachment (id=1107)
 --> (https://www.rtems.org/bugzilla/attachment.cgi?id=1107) [details]
[details] [details]
> > > SMP Patch with suggested modifications
> > 
> > How many #if defined(__i386__) and similar to we have currently in the cpukit
> > outside score/cpu before and after this patch?  We should leave all CPU
> > dependent things inside score/cpu.
> ACK. E.g. cpukit/score/src/smplock.c doesn't seem sound to me. I am inclined to
> reject at least this file.


I should have caught that. I meant to split that file and have a small file
inside each port or an inline method which mostly wrapped an inline asm.

Suggestions on the name are welcomed.

> > I still think that the explicit BSP dependencies are not good inside the
> > cpukit.
> That's not strong enough: BSP deps inside of cpukit are strictly prohibited and
> will immediately be reverted.

It isn't dependent on the BSP.  These are CPU dependent bus lock compare and
swap or exchange type instructions.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.