[Bug 1742] Warnings in system headers

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=1742

Ralf Corsepius <ralf.corsepius at rtems.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX

--- Comment #6 from Ralf Corsepius <ralf.corsepius at rtems.org> 2011-02-24 04:29:46 CST ---
(In reply to comment #5)
> (In reply to comment #4)
> > Seems to me as if you haven't understood how these things work.
> > 
> > The 1st patch is worth deeper investigation, but the second definitely is wrong
> > without any doubt.
> 
> At present <sys/cdefs.h> and <rtems/bsd/sys/cdefs.h> do not include other
> header files. 
Exactly ... that's how things are supposed to be.

> The <sys/cdefs.h> is a part of Newlib and thus more general than
> the RTEMS specific <rtems/bsd/sys/cdefs.h>. 
That's your thinko. <rtems/bsd/sys/cdefs.h> is RTEMS internal and _more_
general counter part of _any_ <sys/cdefs.h>.

> The <rtems/bsd/sys/cdefs.h>
> defines things also defined in <sys/cdefs.h>. 
Correct.

> Thus it is natural to use the
> definitions from <sys/cdefs.h> in <rtems/bsd/sys/cdefs.h>.
No ... <rtems/bsd/sys/cdefs.h> _replaces_ <sys/cdefs.h>

> What is here definitely wrong without any doubt?
Your reasoning and you trying to fix non-bugs.

Duplicate defines are no bugs unless they collide. Right they trigger warnings
when using overzealous warning options, but that's it.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.