[Bug 1845] arm/rtl22xx_t fails to configure

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Fri Jul 22 12:56:10 UTC 2011


https://www.rtems.org/bugzilla/show_bug.cgi?id=1845

--- Comment #2 from Joel Sherrill <joel.sherrill at oarcorp.com> 2011-07-22 07:56:09 CDT ---
(In reply to comment #1)
> This BSP's *.cfg on 4-10-branch is using an invalid syntax:
> 
> # cvs diff -u -r rtems-4-10-branch c/src/lib/libbsp/arm/rtl22xx/make/custom
> cvs diff: Diffing c/src/lib/libbsp/arm/rtl22xx/make/custom
> Index: c/src/lib/libbsp/arm/rtl22xx/make/custom/rtl22xx_t.cfg
> ===================================================================
> RCS file:
> /usr1/CVS/rtems/c/src/lib/libbsp/arm/rtl22xx/make/custom/rtl22xx_t.cfg,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -r1.2 -r1.3
> --- c/src/lib/libbsp/arm/rtl22xx/make/custom/rtl22xx_t.cfg    20 May 2010
> 13:00:41 -0000    1.2
> +++ c/src/lib/libbsp/arm/rtl22xx/make/custom/rtl22xx_t.cfg    6 Dec 2010
> 23:13:11 -0000    1.3
> @@ -3,7 +3,7 @@
>  #
>  #  $Id$
>  #
> -set USE_THUMB_MODE=YES
> +USE_THUMB_MODE=YES
> 

I don't dispute but it has been there since the file was added. Why
did it start to break around December of last year?  Apparently this 
wasn't a problem on the head until last December.  I just ran into 
it again on the older branches. 


>  #  This contains the compiler options necessary to select the CPU model
>  #  and (hopefully) optimize for it. 
> 
> 
> 
> Apart of this, 
> a) USE_THUMB_MODE is not used anywhere.
> => it is meaningless.
> 
> b) USE_THUMB_MODE violates the working principles of the *.cfgs.

My grep showed that also and I was going to remove it.

> c) This BSP had never been part of 4-9-branch
> => it should not be part of updates to 4.9.

No.  You are mistaken.  

rtl22xx BSP itself was added 25 April 2007.
rtl22xx_t.cfg was added 6 Nov 2007.
4.9 branch was cut between 7 Sept 2008 and 10 Sept 2008
based on history of cpukit/ChangeLog

> # cvs diff -u -r rtems-4-9-branch c/src/lib/libbsp/arm/rtl22xx/make/custom
> cvs diff: Diffing c/src/lib/libbsp/arm/rtl22xx/make/custom
> cvs diff: tag rtems-4-9-branch is not in file
> c/src/lib/libbsp/arm/rtl22xx/make/custom/rtl22xx.cfg
> cvs diff: tag rtems-4-9-branch is not in file
> c/src/lib/libbsp/arm/rtl22xx/make/custom/rtl22xx_t.cfg

I don't know why you aren't seeing it that way but it clearly shows as being
tagged on the 4.9 branch when you view it graphically.  It was there when
the branch was made and has been part of every branch.

http://www.rtems.org/viewvc/rtems/make/custom/rtl22xx_t.cfg?hideattic=0&view=graph

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the bugs mailing list