[Bug 1802] smp support for i386

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=1802

Jennifer Averett <jennifer.averett at oarcorp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1179|0                           |1
        is obsolete|                            |

--- Comment #2 from Jennifer Averett <jennifer.averett at oarcorp.com> 2011-07-27 14:00:16 CDT ---
Created attachment 1245
  --> https://www.rtems.org/bugzilla/attachment.cgi?id=1245
i386 smp implementation

> why not integrate appcpustart.S with start.S as is done with the leon?

Merged appcpustart.S into start16.S

> +pc386_delay:
> +_pc386_delay:
> IIRC this type of routine was the reason for an rtems_bsp_delay in the first
> place.

This method was already in existance in start16.S and the problem will
be resolved with PR1794 which will do a sweep of all bsp's.

> smp-imps.c:
> +#define __RTEMS_VIOLATE_KERNEL_VISIBILITY__
> What is this for?

Removed

> +/* base address of applciation processor reset code at 0x70000 */
> typo s/applciation/application
> +extern char _binary_appstart_bin_start[];
> +extern char _binary_appstart_bin_size[];
> +
> +extern void _pc386_delay(void);
> These should probably be declared in smp-imps.h?

Moved

> There are a number of printks that should be #ifdef'd out for production.
>
  I feel these should be left in at least until the smp is more mature. The
  noise that comes out identifes how many cpus were found and how many came
  out of reset.  Most other prints are error print messages.


> +/*
> + *  RTEMS SMP BSP Support
> + */
> Everything below / including this should probably go in separate file(s)

This would require static methods from smp-imps to become non-static so that
they could be called from the new file.  Due to this we felt leaving them in
one file was the better option.

> smp-imps.h:
> Are the exported globals required?

Removed

Additionally, modifications were made to bring the i386 patch in sync with 
the working smp tree.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.