[Bug 1823] Add new framebuffer ioctl to switch video modes

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Tue Jul 12 12:40:31 UTC 2011


https://www.rtems.org/bugzilla/show_bug.cgi?id=1823

--- Comment #22 from Ralf Corsepius <ralf.corsepius at rtems.org> 2011-07-12 07:40:29 CDT ---
(In reply to comment #21)
> I also agree with the committed patch in the context of the current fb API and
> therefore resolve in the context it was raised.

a) 

# grep -R FBIOSETBUFFERMODE .
./c/src/lib/libbsp/lm32/shared/milkymist_framebuffer/framebuffer.c:    case
FBIOSETBUFFERMODE:
./cpukit/libmisc/fb/fb.h:#define FBIOSETBUFFERMODE       0x4608

=> This ioctl is milkymist proprietary. To all other BSPs and CPUs, this define
is just "preprocessor name space pollution", which may cause clashes elsewhere.

=> It is mal-located and needs to be moved into something lm32 proprietary.

b) Whether this milkymist proprietary define can be generalized is
questionable.


c) ioctls in RTEMS are 32bits ... none of the fb.h ioctls defines currently is
properly typed

[NB: There was another PR, related to casting ioctls on the lm32 - This is the
origin of that issue]

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the bugs mailing list